35189 Commits

Author SHA1 Message Date
Abhishek Kumar
5f29bc2b80
server: publish ip6 assign event with route, always for vpc (#6389)
* server: publish ip6 assign event for vpc always

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* refactor event message, fix event publish

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* unused import

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* Fix event string
2022-05-16 16:29:02 -03:00
Sina Kashipazha
1964b7fda3
Fix, change network.disable.rpfilter type from integer to boolean. (#6380)
* Fix, change network.disable.rpfilter type from integer to boolean.

`network.disable.rpfilter` global setting doesn't accept boolean values.

* Changed consoleproxy.disable.rpfilter global setting type from integer to boolean.
2022-05-13 09:21:22 -03:00
Harikrishna
57ecdf9ea6
Fix changeOfferingForVolume API to consider storage type in the disk offering (#6377) 2022-05-13 08:21:15 -03:00
Nicolas Vazquez
ea37d757d3
Reword KVM snapshot without memory error message (#6387) 2022-05-13 08:19:54 -03:00
Nicolas Vazquez
07cabb5890
Fix: Cannot import Vmware instances (#6384) 2022-05-13 07:46:53 -03:00
João Jandre
867cb30efb
Add new labels (#6378)
Co-authored-by: Joao <JoaoJandre@gitlab.com>
2022-05-12 08:59:35 -03:00
dahn
b3861d5900
removed unused field (#6383) 2022-05-12 08:28:54 -03:00
Nicolas Vazquez
0ab0c35549
UI: Add missing tooltips on service offering creation (#6376)
* UI: Add missing tooltips on service offering creation

* Refactor - use translation

* Corrected message for compute only offering tool tip

Co-authored-by: Harikrishna Patnala <harikrishna.patnala@gmail.com>
2022-05-12 07:26:15 -03:00
Nicolas Vazquez
8aca2b67f0
UI: Fix hypervisor list after zone validation when registering a template (#6382) 2022-05-12 07:17:28 -03:00
nvazquez
c0176b24ab
Merge branch '4.16' 2022-05-12 07:16:31 -03:00
Suresh Kumar Anaparti
d373f973ba
Update VM name, when the new name provided in updateVirtualMachine API in different case. (#6379) 2022-05-12 07:15:19 -03:00
Wei Zhou
8f39a049bb
agent: enable ssl only for kvm agent (not in system vms) (#6371)
* agent: enable ssl only for kvm agent (not in system vms)

* Revert "agent: enable ssl only for kvm agent (not in system vms)"

This reverts commit b2d76bad2e9455384c4ac34cee6763014e255eb6.

* Revert "KVM: Enable SSL if keystore exists (#6200)"

This reverts commit 4525f8c8e7ffecf50eff586ccfbc3d498f1b8021.

* KVM: Enable SSL if keystore exists in LibvirtComputingResource.java
2022-05-12 07:01:55 -03:00
Pearl Dsilva
c0124e2753
ui: Allow editing host and storage tags in updateHost & updatStoragePool forms (#6375) 2022-05-11 08:06:19 -03:00
Wei Zhou
eb9c00f26f
CKS: fix error with pulling weaveworks images when create k8s ISO (#6368)
this fixes the error below when create K8S ISO using scripts/util/create-kubernetes-binaries-iso.sh

```
+ echo 'Downloading image weaveworks/weave-kube:latest ---'
Downloading image weaveworks/weave-kube:latest ---
+ [[ weaveworks/weave-kube:latest == kubernetesui* ]]
+ [[ weaveworks/weave-kube:latest == apache* ]]
+ sudo ctr image pull weaveworks/weave-kube:latest
INFO[0000] trying next host                              error="failed to do request: Head https://weaveworks/v2/weave-kube/manifests/latest: dial tcp: lookup weaveworks: no such host" host=weaveworks
ctr: failed to resolve reference "weaveworks/weave-kube:latest": failed to do request: Head https://weaveworks/v2/weave-kube/manifests/latest: dial tcp: lookup weaveworks: no such host
```
2022-05-10 23:11:23 -03:00
Nicolas Vazquez
7af8eb3c56
UI: Fix refresh button on Metrics (#6370) 2022-05-10 23:06:07 -03:00
Wei Zhou
c1691a9e2d
ipv6: set default_egress_policy for ingress rules (#6364)
The issue is found in the smoke test `test/integration/smoke/test_network_ipv6.py`.
sometimes the test failed with error below
```
FAIL: Test to verify IPv6 network
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/marvin/lib/decoratorGenerators.py", line 30, in test_wrapper
    return test(self, *args, **kwargs)
  File "/marvin/test_network_ipv6.py", line 1215, in test_01_verify_ipv6_network
    self.checkNetworkRouting()
  File "/marvin/test_network_ipv6.py", line 1060, in checkNetworkRouting
    "Ping from VM %s of network %s to VM %s of network %s is unsuccessful" % (self.routing_test_vm.id, self.routing_test_network.id, self.virtual_machine.id, self.network.id))
AssertionError: False is not true : Ping from VM 0aa36a76-09c6-476f-97c5-b9cea27a5b7c of network 27a2b244-e319-46c5-a779-d6ae73eb9ac2 to VM ae13ea17-1f35-4ca7-83c1-e13126f8df79 of network 1f38a686-69f3-41ed-a75e-cd3f822497d8 is unsuccessful
```

After investigation, we found the egress traffic is dropped by `nft`.

a correct nft chain looks like
```
root@r-282-VM:~# nft list chain ip6 ip6_firewall fw_chain_egress
table ip6 ip6_firewall {
	chain fw_chain_egress {
		counter packets 0 bytes 0 accept
	}
}
```

However, some VRs has the following nft chain
```
root@r-280-VM:~# nft list chain ip6 ip6_firewall fw_chain_egress
table ip6 ip6_firewall {
	chain fw_chain_egress {
		counter packets 0 bytes 0 drop
	}
}
```

It is because the ingress rule does not have correct `default_egress_policy`
```
root@r-280-VM:~# cat /etc/cloudstack/ipv6firewallrules.json
{
  "0": {
    "already_added": false,
    "default_egress_policy": true,
    "dest_cidr_list": [],
    "guest_ip6_cidr": "fd17:ac56:1234:1a96::/64",
    "id": 0,
    "protocol": "all",
    "purpose": "Ipv6Firewall",
    "revoked": false,
    "source_cidr_list": [],
    "src_ip": "",
    "traffic_type": "Egress"
  },
  "1263": {
    "already_added": false,
    "default_egress_policy": false,
    "dest_cidr_list": [
      "::/0"
    ],
    "guest_ip6_cidr": "fd17:ac56:1234:1a96::/64",
    "icmp_code": -1,
    "icmp_type": -1,
    "id": 1263,
    "protocol": "icmp",
    "purpose": "Ipv6Firewall",
    "revoked": false,
    "source_cidr_list": [
      "::/0"
    ],
    "traffic_type": "Ingress"
  },
  "id": "ipv6firewallrules"
}
```

in mose time, the Egress rule is processed before Ingress rule.
But when the Ingress rule is processed at first, the nft chain will be wrong.
2022-05-07 09:37:42 -03:00
Wei Zhou
3c55806324
test_network_ipv6.py : remove wrong icmp type (#6361) 2022-05-06 22:01:34 +02:00
Nicolas Vazquez
362488ee3d
Bugfix: no support for XCPng 8.2.1 (#6362)
* Initial support for XCPng 8.2.1

* Refactor
2022-05-06 13:04:52 -03:00
Abhishek Kumar
bcf05c090c
schema,upgrade: fix wrong comment for new columns of cloud.event (#6363)
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-05-06 13:00:13 -03:00
Pearl Dsilva
d739db1970
ui: Fix adding tags to compute and disk offering (#6360) 2022-05-06 07:52:12 -03:00
dahn
f572c7ab74
Gateways after Nic update on Shared Network tests (#6355)
* initial code to set up test

* validations in marvin test
2022-05-05 19:53:31 -03:00
nvazquez
5bdfa35b3d
Merge branch '4.16' 2022-05-04 23:16:01 -03:00
Pearl Dsilva
556f9dac0f
ui: Network offerings not listed if listVPCs not available in the account Role (#6354) 2022-05-04 23:14:47 -03:00
Marcus Sorensen
3dcb93d981
maven: Move apache DS dependencies to test scope (#6347)
Fixes: #6346

Move LDAP embedded server dependencies to test scope so they aren't packaged in final management server jar.

Co-authored-by: Marcus Sorensen <mls@apple.com>
2022-05-04 11:49:29 +05:30
Pearl Dsilva
74c42ee3b1
ui: Fix live patch of routers (#6353) 2022-05-03 18:21:10 -03:00
Rohit Yadav
470de7fb54 .github: run coverage for pushes to main branch
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-05-04 02:23:47 +05:30
Abhishek Kumar
d42c0eeb11
systemvm: setup radvd correctly (#6343)
* systemvm: setup radvd correctly

Fixes radvd setup on VR for isolated network

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* donot start radvd on startup

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* Revert "donot start radvd on startup"

This reverts commit 2a8f737f3cf548386f025a436da5e66f59af858b.

* ipv6: do not start radvd in common.sh

* ipv6: do not add radvd to enabled_svcs in CsRedundant.py

* systemvm: add radvd to /var/cache/cloud/enabled_svcs when enable radvd

* test: fix test_network_ipv6.py

Co-authored-by: Wei Zhou <weizhou@apache.org>
2022-05-03 17:53:32 -03:00
Rohit Yadav
17afe0510e .github: add support for PR decoration
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-05-04 01:02:38 +05:30
nvazquez
1967b64b2b
Merge branch '4.16' 2022-05-03 14:00:16 -03:00
Nicolas Vazquez
efb1f2b719
UI: Fix templates page redirection after delete job is finished (#6345) 2022-05-03 13:59:47 -03:00
Rohit Yadav
41cf721868 README: update badget based on new sonarcloud.io project
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-05-03 21:04:14 +05:30
Rohit Yadav
2326b5e22a maven: update sonarcloud project
https://sonarcloud.io/project/configuration?id=apache_cloudstack

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-05-03 18:55:20 +05:30
Pearl Dsilva
887153197d
ui: Fix template delete issue (#6340) 2022-04-29 13:20:32 -03:00
Wei Zhou
3c63e57590
UI: show startip and endip if network offering support specified ip ranges (#6336) 2022-04-29 09:13:34 -03:00
Pearl Dsilva
76b3066d52
ui: Fix migrate systemVM icon when stopped (#6337) 2022-04-29 07:44:47 -03:00
Pearl Dsilva
3bd723ca06
Change patch path during live patching of systemVMs (#6328)
* Improve log when live patching fails

* change patching path from /tmp to /var/cache/clou

* add iptable rule for console proxy (novnc)

* temporary template paths

* revert pom xml to original paths
2022-04-29 00:01:11 -03:00
Nicolas Vazquez
e0487c43fb
UI: Fix detail settings (#6335) 2022-04-28 23:37:28 -03:00
Abhishek Kumar
23f6db7735
test: fix ipv6 network test for xenserver (#6329)
Default ACS Xenserver template, CentOS 5.6, has IPv6 disabled.
/etc/modeprobe.conf shows "options ipv6 disable=1"
To run IPv6 network test successfully on Xenserver smoketest run get_test_template will be used instead of get_template while deploying guest VM in the IPv6 guest network.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-04-28 23:28:41 -03:00
Pearl Dsilva
923a5a4425
Improve log when live patching fails (#6324) 2022-04-28 13:01:15 -03:00
João Jandre
fd8dfa108e
Added allowuserdrivenbackups toggle to the edit backup offering button (#6323)
Co-authored-by: Joao <JoaoJandre@gitlab.com>
2022-04-28 11:09:12 -03:00
David Jumani
b85d5e491a
ui: Fix groupaction for nw cleanup and Notify when groupaction fails (#6333) 2022-04-28 09:21:43 -03:00
Nicolas Vazquez
87a402cc2b
UI: Fix filter width to fix options (#6325) 2022-04-27 22:30:34 -03:00
Rohit Yadav
c379430dab .github: sonarcloud integration fixes
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-27 18:15:27 +05:30
JoaoJandre
c315724e76
Fix grammatical errors on en.json (#6281)
* Fix grammatical errors on en.json

* Removed duplicated labels caused by merging branches

* Address review

Co-authored-by: João Paraquetti <joao@scclouds.com.br>
Co-authored-by: Joao <JoaoJandre@gitlab.com>
2022-04-27 09:29:27 -03:00
Abhishek Kumar
d039753994
ui: add route for network acl event resource (#6322)
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-04-27 09:26:46 -03:00
Nicolas Vazquez
06e2c38679
Fix user shared networks tests (#6319) 2022-04-27 07:30:44 -03:00
slavkap
453bb57fd2
Disable creating StorPool logs when there isn't StorPool primary storage (#6317)
There is not need to create log files for StorPool driver when there
isn't a StorPool primary storage
2022-04-27 07:24:44 -03:00
Abhishek Kumar
f8920b9312
ui,api: fix api resourcename and user/project event resource (#6315)
For user and project dashborad event resource details were not showing as shown in admin dashboard.
API, UI shows name of the resource as event resourcename. Changed it to displaytext of the resource for consistency

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
2022-04-26 23:32:18 -03:00
Abhishek Kumar
e53ed9e350
network: fix event, acl, firewall for ipv6 nw (#6314)
* add guest ipv6 cidr for fw rule

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

* fix fw, acl nft chains

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

* remove unnecessary log

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

* api response should return default internet protocol

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

* event resource fix for ipv6 firewall rule events

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

* fix radvd, restore ipv6 intf in vm type script

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

* fix dadfailed with rvr

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
2022-04-26 23:30:44 -03:00
SadiJr
4cc830d04a
[VMWare] error when detaching volume (#6283)
* Fix exception, in VMWare 6.5, when trying to detach volume

* Address reviews

* Address reviews

Co-authored-by: SadiJr <sadi@scclouds.com.br>
2022-04-26 23:29:17 -03:00