apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

[VMWare] error when detaching volume (#6283)

Browse Source 
* Fix exception, in VMWare 6.5, when trying to detach volume

* Address reviews

* Address reviews

Co-authored-by: SadiJr <sadi@scclouds.com.br>
This commit is contained in:
SadiJr 2022-04-26 23:29:17 -03:00 committed by GitHub
parent a2abd7fdc2
commit 4cc830d04a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageLayoutHelper.java
View File

@ -247,10 +247,26 @@ public class VmwareStorageLayoutHelper implements Configurable {
s_logger.info("Fixup folder-synchronization. move " + fileDsFullPath + " -> " + targetPath);
ds.moveDatastoreFile(fileDsFullPath, dcMo.getMor(), ds.getMor(), targetPath, dcMo.getMor(), true);
if (folderName != null) {
String[] files = ds.listDirContent(folderName);
if (files == null || files.length == 0) {
ds.deleteFolder(folderName, dcMo.getMor());
try {
if (folderName != null) {
String[] files = ds.listDirContent(folderName);
if (files == null || files.length == 0) {
ds.deleteFolder(folderName, dcMo.getMor());
}
}
} catch (Exception e) {
if (e.getMessage().toLowerCase().startsWith("server returned http response code: 500 for url: ") &&
e.getMessage().contains(vmName)) {
String link = "https://github.com/apache/cloudstack/pull/6283";
String message = String.format("Failed to list folder content of VM [name: %s] due to: [%s]. For more information about this error, or "
+ "to know why ACS tries to check folder content, please check this link [%s]. This error apparently only occurs with datastores that use the NFS protocol and "
+ "in specific versions of VMWare. Users using VMFS or VMWare versions greater than 6.7 have not reported this error. If the operation performed is a volume detach, "
+ "it was successful. If you want to know why this error occurs in VMWare, please contact VMWare's technical support.",
vmName, e.getMessage(), link);
s_logger.warn(message, e);
} else {
s_logger.error(String.format("Failed to sync volume [%s] of VM [%s] due to: [%s].", vmdkName, vmName, e.getMessage()), e);
throw e;
}
}
}