119 Commits

Author SHA1 Message Date
Hugo Trippaers
7e58a278a0 CID-1232335/CID-1232336 Fix potential XSS 2014-11-18 14:40:13 +01:00
Hugo Trippaers
9eb2b2763c Fix for CID-1232333, CID-1232334, CID-1232335, CID-1232336 and
CID-1232337
2014-09-23 11:23:20 +02:00
Santhosh Edukulla
4a6560a9ee Fixed few coverity defects 2014-08-21 12:43:11 +05:30
Santhosh Edukulla
4825017cc7 Fixed coveirty defects for concurrency, variable comparison etc
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-08-14 21:54:46 +05:30
Santhosh Edukulla
c2c63ffd61 Fixed Coverity Issue 2014-07-25 17:12:46 +05:30
Prachi Damle
2f2efb0954 CS-19828: EC2 API tool errors while parsing response for detachVolume, describeAddress and revokeSecurityGroupIngress
Changes:
    - Set the mandatory response properties in case of DetachVolume and DescribeAddress API responses
    - Use the correct CS API responsename for revokesecuritygroupingress

Conflicts:
	awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java
2014-07-16 14:28:11 -07:00
Likitha Shetty
56e37243b8 CLOUDSTACK-7114. [EC2 QueryAPI] Inconsistency in mapping the "Allocated" state of a Volume to "Available". 2014-07-16 15:22:40 +05:30
Hugo Trippaers
5c29f3ffd7 Fix CID 1116694 Resource leak 2014-07-04 13:50:31 +02:00
Tim Mackey
a8212d9ef4 Cleanup of Xen and XenServer terms. Cloned xen plugin creating a xenserver plugin, then removed xen plugin
Signed-off-by: Tim Mackey <tmackey@gmail.com>
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-06-07 04:50:23 -04:00
Laszlo Hornyak
6617187193 some String instantiations removed
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-30 10:31:42 +02:00
Daan Hoogland
40f4b371b7 Revert "cloudstack api post and ssl fix"
This reverts commit d5333f4596460c7123b66ad5c19fc69442696ea2.
2014-03-26 14:31:18 +01:00
Daan Hoogland
42516216e6 Revert "Fix license headers and remove @author tag"
This reverts commit f848c779c032bafa05bf6be269cceb34c942149a.
2014-03-26 14:30:44 +01:00
Sebastien Goasguen
f848c779c0 Fix license headers and remove @author tag 2014-03-24 16:52:50 +01:00
Dmitry Batkovich
d5333f4596 cloudstack api post and ssl fix
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-03-24 15:59:10 +01:00
Likitha Shetty
7f6b3c08db CLOUDSTACK-5998. [AWSAPI] describe addresses call returns a fault with "domain cannot be null!!". 2014-01-31 10:52:50 +05:30
Daan Hoogland
c6118ad92e findbugs bitwise or guaranteed positively bitfields 2014-01-30 23:16:24 +01:00
Daan Hoogland
41fd0a2ab7 findbugs equals on same type of objects 2014-01-30 22:58:52 +01:00
Likitha Shetty
226b749131 CLOUDSTACK-5915. [AWSAPI] Instance launch is inconsistent if there are deleted service offerings
Use CS API listServiceOfferingsCmd to retrieve appropriate service offerings
2014-01-21 14:52:38 +05:30
Alex Huang
be5e5cc641 All Checkstyle problems corrected 2013-12-12 12:26:07 -08:00
wilderrodrigues
d19688103b Fixing coverity issues related to resource leak on FileInputStream being created anonymously
Signed-off-by: Daan Hoogland <daan@onecht.net>
2013-11-27 12:51:44 +01:00
Alex Huang
170f32f171 Broke up some long strings 2013-11-21 07:25:01 -08:00
Alex Huang
d620df2bdd Reformatted all of the code. 2013-11-21 06:15:26 -08:00
Alex Huang
eaa250fd3c Formatted again after all the tab expansions and eol removals 2013-11-21 04:47:01 -08:00
Alex Huang
224f479974 Removed trailing spaces 2013-11-21 04:08:01 -08:00
Alex Huang
e4b22d0fca Replace all tabs, particularly the ones in the comments 2013-11-21 03:39:58 -08:00
Alex Huang
62e9273581 Removed trailing spaces 2013-11-21 03:12:05 -08:00
Alex Huang
8d62744681 Reformat all source code. Added checkstyle to check the source code 2013-11-20 07:26:53 -08:00
Darren Shepherd
1460196496 Centralize loading of db.properties to one place
There is now a method DbProperites.getDbProperties() that will load the
db.properties in one place and do the proper decryption of values if needed
2013-10-30 17:03:13 -07:00
Darren Shepherd
f62e28c1ec New Transaction API
Introduction of a new Transaction API that is more consistent with the style
of Spring's transaction managment.  The existing Transaction class was renamed
to TransactionLegacy.  All of the non-DAO code in the management server has been
updated to use the new Transaction API.
2013-10-16 09:21:00 -07:00
Darren Shepherd
aed5e9dc2a Add Manage Context framework
The managed context framework provides a simple way to add logic
to ACS at the various entry points of the system.  As threads are
launched and ran listeners can be registered for onEntry or onLeave
of the managed context.  This framework will be used specifically
to handle DB transaction checking and setting up the CallContext.
This framework is need to transition away from ACS custom AOP to
Spring AOP.
2013-10-02 13:09:52 -07:00
Likitha Shetty
24e9797807 CLOUDSTACK-3112. UserCredentials that is injected in AuthenticationHandler is not picked up 2013-07-08 15:37:57 +05:30
Likitha Shetty
4bf6c1e2f7 CLOUDSTACK-1444. Adding ASF license header to the regenerated JAVA files
[Support for EC2 API version 2012-08-15]
2013-07-04 11:59:36 +05:30
Likitha Shetty
4cda7a5d97 CLOUDSTACK-1444. Adding ASF license header to the regenerated JAVA files
[Support for EC2 API version 2012-08-15]
2013-07-04 11:58:23 +05:30
Likitha Shetty
26af71b23b CLOUDSTACK-1444. Adding ASF license header to the regenerated JAVA files
[Support for EC2 API version 2012-08-15]
2013-07-04 11:11:21 +05:30
Likitha Shetty
d908f85749 CLOUDSTACK-1444. Fix EC2 Query API to support latest ec2 api version 2012-08-15 [Support for EC2 API version 2012-08-15]
Signed-off-by: Likitha Shetty <likitha.shetty@citrix.com>
2013-07-04 10:09:00 +05:30
Likitha Shetty
3cfaa92917 CLOUDSTACK-3258. In AWSAPI provide Tags support for resource 'security group'
Signed-off-by: Likitha Shetty <likitha.shetty@citrix.com>
2013-07-04 10:08:42 +05:30
Likitha Shetty
135b688a00 CLOUDSTACK-1444. Updated EC2SoapService and EC2SoapServiceImpl to be compatible with the java stubs generated from EC2 WSDL 2012-08-15.
- by adding stubs for the new EC2 APIs (unsupported by CS AWSAPI)
  - by setting the new EC2 API response elements
  - by adding support for the new EC2 API request elements
[Support for EC2 API version 2012-08-15]
2013-07-04 10:06:51 +05:30
Likitha Shetty
33df54edaf CLOUDSTACK-1444. Contains regenerated JAVA stubs and services.xml obtained by generating code from ec2 wsdl 2012-08-15 [Support for EC2 API version 2012-08-15]
Signed-off-by: Likitha Shetty <likitha.shetty@citrix.com>
2013-07-04 10:01:19 +05:30
Likitha Shetty
c08b927b86 CLOUDSTACK-3295. Code should look for xes.keystore under cloud-awsapi-4.2.0-SNAPSHOT and not under generated-webapp. 2013-07-04 09:46:41 +05:30
Prachi Damle
6c9383bd76 CLOUDSTACK-3336 AWSAPI - createVolume API with custom size should prefer a non-tagged custom sized disk offering first over a tagged offering
Changes:
For createVolume API with custom size the awsapi component chooses the custom size disk offering present on CloudStack, sice CS createVolume API needs an offering Id.

But if there are multiple custom size disk offerings, and some of the offerings have tags, awsapi should try to choose a non-tagged custom offering first. There is a reason for people to tag a disk offering and using that on every user API call may not be preferable.

If all disk offerings are tagged however, awsapi will choose one of them.
2013-07-02 15:18:49 -07:00
Prachi Damle
4858bd1df3 CLOUDSTACK-3251 AWSAPI - runInstances should not error out if instanceType provided is a valid ServiceOffering on CloudStack
Changes: - If instanceType value corresponds to a valid serviceoffering on CloudStack, dont error out on runInstances even if thats not an AWS name
2013-06-27 15:59:26 -07:00
Prachi Damle
f88590f6db CLOUDSTACK-3218: AWSAPI - For runInstances, awsapi need not send networkId information in case of advance zone
Changes:
 awsapi will not pass networkId in case of Advance Zone and let CS identify which network to deploy VM in. The same case applies to allocateAddress API too.
2013-06-27 15:49:31 -07:00
Likitha Shetty
dc242039b3 CLOUDSTACK-305. Everytime a SOAP call is made some transactions are rolled back because the transactions are not committed. 2013-06-24 14:21:59 +05:30
Likitha Shetty
77674721ca CLOUDSTACK-308. ec2-describe-instances - Instance type should return right service offering name 2013-06-24 11:29:12 +05:30
Likitha Shetty
bbfa9bfcbd CLOUDSTACK-2862. EC2Engine is not injected correctly 2013-06-11 10:58:49 +05:30
Likitha Shetty
9a33fd181f CLOUDSTACK-2623. Provide appropriate AWS EC2 error codes in error thrown by CS AWSAPI. Since CS has very few generic errorcode groups, in AWSAPI parse the response message and translate the CS error to AWS EC2 error code.
Provide support for the following error codes -
AuthFailure, DependencyViolation, IncorrectState, InvalidAMIID.NotFound, InvalidAttachment.NotFound, InvalidDevice.InUse, InvalidFilter, InvalidGroup.Duplicate, InvalidGroup.InUse, InvalidGroup.NotFound
InvalidInstanceID.NotFound, InvalidKeyPair.Duplicate, InvalidKeyPair.Format, InvalidKeyPair.NotFound, InvalidParameterCombinatio, InvalidParameterValue, InvalidPermission.Duplicate, InvalidPermission.Malformed
InvalidSnapshot.NotFound, InvalidVolume.NotFound, InvalidVolumeID.Duplicate, InvalidZone.NotFound, MissingParameter, UnsupportedOperation, SignatureDoesNotMatch, InternalError, AddressLimitExceeded, InstanceLimitExceeded
VolumeLimitExceeded, Unavailable, ResourceLimitExceeded

CLOUDSTACK-2624. Support ModifyInstanceAttribute API in AWSAPI.
2 AWS instance attributes will be supported, 'InstanceType' and 'UserData'
As per AWS EC2, to modify both the attributes, the instance must be stopped. If not throw 'IncorrectInstanceState' error
2013-05-22 18:17:11 +05:30
Likitha Shetty
eb92135d55 CLOUDSTACK-2603. EC2RunInstances return xen or ovm as the response value for attribute "hypervisor" 2013-05-21 15:15:35 +05:30
Likitha Shetty
6217b0fb4c CLOUDSTACK-2600. Fix CS AWSAPI to add the below filters that are missing in DescribeImages API-
architecture
description
image-id
image-type
is-public
name
owner-id
state
tag-key
tag-value
tag:key
hypervisor
2013-05-21 12:10:52 +05:30
Likitha Shetty
503392119d CLOUDSTACK-2599. Fix EC2 Rest to support tag related EC2 API's - CreateTags/DeleteTags/DescribeTags 2013-05-21 11:33:33 +05:30
Likitha Shetty
8986e16e5f CLOUDSTACK-2576. AWS API not returning values in CFSimpleXML Object format.
PHP SDK calls the CFSimpleXML parser class to parse the response body into CFSimpleXML Object format.
In AWSAPI added an XML declaration during serialization of Axis beans to XML output
2013-05-20 15:01:57 +05:30