apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-11-03 04:12:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixed Coverity Issue

Browse Source
This commit is contained in:
Santhosh Edukulla 2014-07-25 17:12:46 +05:30
parent cd67db395a
commit c2c63ffd61
1 changed files with 23 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
awsapi/src/com/cloud/bridge/io/S3FileSystemBucketAdapter.java
View File

@ -152,30 +152,33 @@ public class S3FileSystemBucketAdapter implements S3BucketAdapter {
file.delete();
file.createNewFile();
final FileOutputStream fos = new FileOutputStream(file);
byte[] buffer = new byte[4096];
try(final FileOutputStream fos = new FileOutputStream(file);) {
byte[] buffer = new byte[4096];
// -> get the input stream for the next file part
for (int i = 0; i < parts.length; i++) {
DataHandler nextPart = loadObject(mountedRoot, sourceBucket, parts[i].getPath());
InputStream is = nextPart.getInputStream();
// -> get the input stream for the next file part
for (int i = 0; i < parts.length; i++) {
DataHandler nextPart = loadObject(mountedRoot, sourceBucket, parts[i].getPath());
InputStream is = nextPart.getInputStream();
int len = 0;
while ((len = is.read(buffer)) > 0) {
fos.write(buffer, 0, len);
md5.update(buffer, 0, len);
totalLength += len;
}
is.close();
// -> after each file write tell the client we are still here to keep connection alive
if (null != client) {
client.write(new String(" ").getBytes());
client.flush();
int len = 0;
while ((len = is.read(buffer)) > 0) {
fos.write(buffer, 0, len);
md5.update(buffer, 0, len);
totalLength += len;
}
is.close();
// -> after each file write tell the client we are still here to keep connection alive
if (null != client) {
client.write(new String(" ").getBytes());
client.flush();
}
}
return new OrderedPair<String, Long>(StringHelper.toHexString(md5.digest()), new Long(totalLength));
}catch (IOException e) {
logger.error("concatentateObjects unexpected exception " + e.getMessage(), e);
throw new OutOfStorageException(e);
}
fos.close();
return new OrderedPair<String, Long>(StringHelper.toHexString(md5.digest()), new Long(totalLength));
//Create an ordered pair whose first element is the MD4 digest as a (lowercase) hex String
} catch (IOException e) {
logger.error("concatentateObjects unexpected exception " + e.getMessage(), e);