220 Commits

Author SHA1 Message Date
Rohit Yadav
d08369ad06 services, awsapi: use better string comparision
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-22 18:09:16 +05:30
Hugo Trippaers
dc3f0cbc63 Improve the handling of the findbug exclude files 2014-09-03 10:41:22 +02:00
Santhosh Edukulla
4a6560a9ee Fixed few coverity defects 2014-08-21 12:43:11 +05:30
Santhosh Edukulla
4825017cc7 Fixed coveirty defects for concurrency, variable comparison etc
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-08-14 21:54:46 +05:30
Santhosh Edukulla
c2c63ffd61 Fixed Coverity Issue 2014-07-25 17:12:46 +05:30
Prachi Damle
2f2efb0954 CS-19828: EC2 API tool errors while parsing response for detachVolume, describeAddress and revokeSecurityGroupIngress
Changes:
    - Set the mandatory response properties in case of DetachVolume and DescribeAddress API responses
    - Use the correct CS API responsename for revokesecuritygroupingress

Conflicts:
	awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java
2014-07-16 14:28:11 -07:00
Likitha Shetty
56e37243b8 CLOUDSTACK-7114. [EC2 QueryAPI] Inconsistency in mapping the "Allocated" state of a Volume to "Available". 2014-07-16 15:22:40 +05:30
Hugo Trippaers
5c29f3ffd7 Fix CID 1116694 Resource leak 2014-07-04 13:50:31 +02:00
Tim Mackey
a8212d9ef4 Cleanup of Xen and XenServer terms. Cloned xen plugin creating a xenserver plugin, then removed xen plugin
Signed-off-by: Tim Mackey <tmackey@gmail.com>
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-06-07 04:50:23 -04:00
Laszlo Hornyak
6617187193 some String instantiations removed
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-30 10:31:42 +02:00
Daan Hoogland
8b62b2cb92 findbugs: exclude known spiffy hacks a.k.a. false positives 2014-03-28 14:28:10 +01:00
Daan Hoogland
40f4b371b7 Revert "cloudstack api post and ssl fix"
This reverts commit d5333f4596460c7123b66ad5c19fc69442696ea2.
2014-03-26 14:31:18 +01:00
Daan Hoogland
42516216e6 Revert "Fix license headers and remove @author tag"
This reverts commit f848c779c032bafa05bf6be269cceb34c942149a.
2014-03-26 14:30:44 +01:00
Sebastien Goasguen
f848c779c0 Fix license headers and remove @author tag 2014-03-24 16:52:50 +01:00
Dmitry Batkovich
d5333f4596 cloudstack api post and ssl fix
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-03-24 15:59:10 +01:00
John Kinsella
4494cbb4c3 CLOUDSTACK-6156: removing rampart maven dependencies from awsapi
The removed dependencies don't seem to be used in code, and their
presence is causing at least some people to be unable to build awsapi
and RPM packages.

Signed-off-by: John Kinsella <jlk@stratosec.co> 1395207698 -0700
2014-03-18 22:41:38 -07:00
Hugo Trippaers
4402685e11 Update master to 4.5.0-SNAPSHOT 2014-03-14 14:55:26 +01:00
Hugo Trippaers
ac00ab0087 Cleanup all mysql dependencies and set all to provided. 2014-02-21 14:55:11 +01:00
Likitha Shetty
7f6b3c08db CLOUDSTACK-5998. [AWSAPI] describe addresses call returns a fault with "domain cannot be null!!". 2014-01-31 10:52:50 +05:30
Daan Hoogland
c6118ad92e findbugs bitwise or guaranteed positively bitfields 2014-01-30 23:16:24 +01:00
Daan Hoogland
41fd0a2ab7 findbugs equals on same type of objects 2014-01-30 22:58:52 +01:00
Hugo Trippaers
997c0f8d15 Fix the exclusion for opensaml1, this should take care of the repository dependencies causing grief on the jenkins slaves. 2014-01-28 10:33:31 +01:00
Likitha Shetty
226b749131 CLOUDSTACK-5915. [AWSAPI] Instance launch is inconsistent if there are deleted service offerings
Use CS API listServiceOfferingsCmd to retrieve appropriate service offerings
2014-01-21 14:52:38 +05:30
Hugo Trippaers
2a93464431 Fix ids in the awsapi and xapi poms so checkstyle is properly excluded 2014-01-15 13:07:34 +01:00
Alex Huang
68b8891c62 Removed all reminants of the IdentityService. Created the KeysManager to move the management
of keys out of management server
2014-01-14 13:11:35 -08:00
Hugo Trippaers
b61f0a74ca Centralize all eclipse m2e excludes in the main pom.xml 2014-01-14 09:39:42 +01:00
Hugo Trippaers
7c8facf3c9 Change checkstyle to run on every sub project, so it will also run when you build an individual module 2014-01-09 17:00:11 +01:00
Alex Huang
c2baed665b Moved the check-style.xml into the tools directory given that we're not using the project to reference the style any longer. Fixed problems with eclipse complaining about copy-dependencies 2013-12-20 17:21:34 -08:00
Alex Huang
be5e5cc641 All Checkstyle problems corrected 2013-12-12 12:26:07 -08:00
wilderrodrigues
d19688103b Fixing coverity issues related to resource leak on FileInputStream being created anonymously
Signed-off-by: Daan Hoogland <daan@onecht.net>
2013-11-27 12:51:44 +01:00
Alex Huang
433a631916 Reformat of source code to set a stable base for the future. I couldn't get checkstyle enabled. There's still about a thousand errors from checkstyle. Most of it from length errors from comments and strings. Will attempt to remove those tonight. This change is so large I just want to get it in before any merge nightmares. The changes are fairly minor though and I did a full compile and start a server with the reformat code. 2013-11-21 07:56:47 -08:00
Alex Huang
170f32f171 Broke up some long strings 2013-11-21 07:25:01 -08:00
Hugo Trippaers
cf715ff491 Bump 4.3.0 to 4.4.0 in master 2013-11-21 16:01:15 +01:00
Alex Huang
d620df2bdd Reformatted all of the code. 2013-11-21 06:15:26 -08:00
Alex Huang
eaa250fd3c Formatted again after all the tab expansions and eol removals 2013-11-21 04:47:01 -08:00
Alex Huang
224f479974 Removed trailing spaces 2013-11-21 04:08:01 -08:00
Alex Huang
e4b22d0fca Replace all tabs, particularly the ones in the comments 2013-11-21 03:39:58 -08:00
Alex Huang
62e9273581 Removed trailing spaces 2013-11-21 03:12:05 -08:00
Alex Huang
8d62744681 Reformat all source code. Added checkstyle to check the source code 2013-11-20 07:26:53 -08:00
Darren Shepherd
1460196496 Centralize loading of db.properties to one place
There is now a method DbProperites.getDbProperties() that will load the
db.properties in one place and do the proper decryption of values if needed
2013-10-30 17:03:13 -07:00
Darren Shepherd
f62e28c1ec New Transaction API
Introduction of a new Transaction API that is more consistent with the style
of Spring's transaction managment.  The existing Transaction class was renamed
to TransactionLegacy.  All of the non-DAO code in the management server has been
updated to use the new Transaction API.
2013-10-16 09:21:00 -07:00
Darren Shepherd
aed5e9dc2a Add Manage Context framework
The managed context framework provides a simple way to add logic
to ACS at the various entry points of the system.  As threads are
launched and ran listeners can be registered for onEntry or onLeave
of the managed context.  This framework will be used specifically
to handle DB transaction checking and setting up the CallContext.
This framework is need to transition away from ACS custom AOP to
Spring AOP.
2013-10-02 13:09:52 -07:00
Hugo Trippaers
cc6edbdbfe Fix a few warnings in the awsapi pom
Apply formatting
2013-09-21 15:49:54 +08:00
Kelven Yang
170e21246e apply https://reviews.apache.org/r/13732/
Signed-off-by: Kelven Yang <kelveny@gmail.com>
2013-09-04 14:49:46 -07:00
Anshul Gangwar
bf5e86eb22 CLOUDSTACK-2187: fixed by adding snmp-alerts and syslog-alerts plugin dependency to awsapi
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-08 10:28:43 +05:30
Chip Childers
8225374138 Updating pom.xml version numbers for release 4.3.0-SNAPSHOT
Signed-off-by: Chip Childers <chipchilders@apache.org>
2013-08-01 10:35:00 -04:00
Alex Huang
c2752ba93c Removed mysql as any dependency 2013-07-26 20:35:48 -07:00
Alex Huang
f5e5b39c9b Moved the DB layer code into framework-db and change only the necessary projects to refer to it. Cut down on the dependencies introduced with all the code in utils. 2013-07-26 15:02:10 -07:00
Alex Huang
b18c72626b Moved the SprintUtils which is for testing only to be in test directory. Changed pom.xml for different projects to use the utils test-jar. Removed some @Component annotations. Moved majority of the dependencies from cloudstack pom to utils pom 2013-07-18 21:53:51 -07:00
Likitha Shetty
58d648345e CLOUDSTACK-2777. Apache build should create jar file cloud-ec2.aar and package it under webapps7080/awsapi/WEB-INF/services 2013-07-09 15:24:41 +05:30