24242 Commits

Author SHA1 Message Date
Rohit Yadav
7ada4ad50b NetUtils: Check for NPE in getDefaultHostIp method when processing nic/mac
On hosts or containers where they don't have valid mac address on nic resulting
in null, NetUtils.getNetworkParam can throw NPE.

This was a case found on TravisCI where OpenVZ containers are used. This method
(getDefaultHostIp) is used at several other places within the ACS codebase to
get the host IP and if null is caught we fallback to localhost or 127.0.0.1, so
we therefore set info to null before trying to process network param and if we
fail we return null and expect other layers to use localhost.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-21 11:41:07 +02:00
Rohit Yadav
e3b3a18aef ConfigurationManagerImpl: Fix NPE when trying to access method on null object
Before checking obj.length, the fix is to check that the obj is not null

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-21 11:34:44 +02:00
Santhosh Edukulla
4a6560a9ee Fixed few coverity defects 2014-08-21 12:43:11 +05:30
Gaurav Aradhye
ac80535574 CLOUDSTACK-7368: Fixed network cleanup issue in test_add_remove_network.py 2014-08-21 11:34:44 +05:30
sanjeevneelarapu
76d050ba53 CLOUDSTACK-4282: [SharedNetworks] Unable to create multiple shared networks with different VLAN but with same CIDR
Signed-off-by: sanjeev <sanjeev@apache.org>

Incorporated review comments provided in review request 23610
2014-08-21 10:22:19 +05:30
Bharat Kumar
cab2b12d7d CLOUDSTACK-7155 Re-copying templates to other zones doesn't work 2014-08-21 09:50:54 +05:30
Mike Tutkowski
ffa4d73290 Update to volume-resize logic 2014-08-20 13:18:33 -06:00
Harikrishna Patnala
8d0817860f CLOUDSTACK-7337: Volume state remains in allocated after volume creation faliure from snapshot Volume should be marked to Destroy state after creation faliure.
Signed-off-by: Koushik Das <koushik@apache.org>
2014-08-20 17:39:53 +05:30
Wido den Hollander
ab7c1f34d6 kvm: Do not print the whole exception when pool is not found in libvirt
This causes the logs to be filled with Exceptions which aren't nice for
users to read
2014-08-20 14:00:29 +02:00
Wido den Hollander
1ed0fe4ee7 kvm: Throw a proper exception when pool could not be fetched from libvirt
Otherwise NULL is returned and leads to a NPE further up the chain.
2014-08-20 13:39:52 +02:00
Rajani Karuturi
14f3ad55ec Fixed CLOUDSTACK-7374: added PaginationControl while querying ldap users 2014-08-20 15:58:08 +05:30
Rohit Yadav
28ad34e31e CLOUDSTACK-7038: Add mysql client dependency for mgmt server, rpms and debs
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 6a26e77514b955e5c9cbb00e51183ec74d3887a3)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-20 12:17:34 +02:00
Sanjay Tripathi
1354605073 CLOUDSTACK-7373: Incorrect Japanese keyboard mapping with CentOS CLI guestOS on VMware host.
This fix is to correct the JP keyboard mapping for VMs with windows and centOS GUI
and CLI OS on VMware hypervisor. Also fixed some known issues on centOS CLI on XS
hypervisor. Fix is not causing any regression.
2014-08-20 14:34:28 +05:30
Likitha Shetty
7dbff9b42c CLOUDSTACK-7371. [VMware] Enabling primary storage maintenance fails when storages are across cluster.
1. While destroying a ROOT volume do the lookup of the associated VM under the DC and not just cluster.
2. In case of VMware, during VM start if a volume is being recreated no need to detach the old volume because
we now expunge it immediately and don't wait for the storage cleanup task to run.
2014-08-20 10:51:18 +05:30
Likitha Shetty
8bb4022f37 CLOUDSTACK-4587. System VMs fail to start when the primary storage that has the System VMs is put into maintenance.
During VM start while configuring its disk devices, obtain the matching disk for a volume in storage
using both the volume's path and volume's datastore information.
2014-08-20 10:51:18 +05:30
seif
4e5dc59218 Support a new control for storage tags on the Add Compute Offering and Add Disk Offering windows 2014-08-19 18:03:48 -06:00
Frank.Zhang
0dc5cb4287 CloudStackCLOUDSTACK-7366
Baremetal agent is not including in RPM spec file
2014-08-19 12:52:59 -07:00
Anthony Xu
beb5575e1e added created time for new added guest OSes 2014-08-19 11:30:40 -07:00
Santhosh Edukulla
023811286e Fixed few coverity issues
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-08-19 22:01:15 +05:30
Anthony Xu
dbe950a27e avoid creating same primary storage multiple times for XenServer 2014-08-18 17:55:34 -07:00
Anthony Xu
81c5e184ba clean up XenServer resource code 2014-08-18 17:25:10 -07:00
Wido den Hollander
097b2d711f debian: Do not depend on tomcat for building
No need for Tomcat when building the packages
2014-08-19 00:00:15 +02:00
Wido den Hollander
eeac81838f kvm: Return capitalized NONE when no disk cache mode is set
This caused Instances not to start under rare circumstances
2014-08-18 23:58:50 +02:00
seif
c319c0b3e0 Make using a hint (or no results) text more flexible 2014-08-18 15:07:03 -06:00
seif
f2781a5ce3 Update the hint appropriately 2014-08-18 12:48:14 -06:00
Frank.Zhang
a0f1012903 CloudStackCLOUDSTACK-7366
Baremetal agent is not including in RPM spec file
2014-08-18 11:23:46 -07:00
Alex Brett
fd1a71603f CLOUDSTACK-7363 test_vmware_drs.py should skip on non-VMWare hypervisors
Make the tests check if the hypervisor being used is VMWare, and skip if not

Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-08-18 22:16:47 +05:30
Gaurav Aradhye
762f831c28 CLOUDSTACK-7352: Fixed issue in test_escalations_vpncustomergateways.py 2014-08-18 20:31:25 +05:30
John Dilley
b9079f3db1 CLOUDSTACK-7346: Skip iSCSI primary storage test for VMWare
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-08-18 20:18:17 +05:30
Sebastien Goasguen
758a73d7c9 Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cloudstack 2014-08-18 10:37:04 -04:00
Vincent Bernat
53650ed7bf CLOUDSTACK-7193: handle domain ID being an int
Recent versions of libvirt (at least 0.9.8) will return an int when
queried for the ID of a domain, not a string. This breaks some parts of
the `security_group.py` script which expects a string containing an
int. Notably, this breaks the part handling VM reboots which is
therefore not executed.

Signed-off-by: Vincent Bernat <Vincent.Bernat@exoscale.ch>
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-08-18 10:36:21 -04:00
Girish Shilamkar
bbd1da19d4 CLOUDSTACK-7353: Fixed issue with list VM in test_projects.py 2014-08-18 20:04:12 +05:30
Wei Zhou
880bff28e0 CLOUDSTACK-7362: fix wrong uuid issue for resource tags
(cherry picked from commit 838a1a8476cfb4308103b3797a281f843e208d38)
2014-08-18 16:17:36 +02:00
Wei Zhou
b035a444c6 CLOUDSTACK-7308: add tags to all security group rules
(cherry picked from commit ae1b87ca23997bcba75bfc7f59e83026e31a68fc)
2014-08-18 16:17:28 +02:00
Olivier Lemasle
de424061b2 CLOUDSTACK-7006: Restore template ID in ROOT volume usages
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-08-18 10:14:26 -04:00
Rohit Yadav
6a8f8317fd CLOUDSTACK-7361: Fix SAML2UserAuthenticator to not let every login credential
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-18 11:41:32 +02:00
Sateesh Chodapuneedi
a1d0925f90 CLOUDSTACK-7360 [vmware] Add host to existing cluster fails if the cluster is using Nexus 1000v as backend for atleast one traffic type.
While adding host to existing cluster which is using Nexus 1000v as a network backend, skip validation of Nexus VSM as it was already done while adding that cluster.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-08-18 07:18:13 +05:30
Devdeep Singh
f099732be7 CLOUDSTACK-7359. Make sure timeout value is set for the MigrateVolumeCommand. This will
make sure the agent waits for the resource to complete (success/failure) migration of
volume on the hypervisor.
2014-08-18 11:38:29 +05:30
Anshul Gangwar
1c688f40e1 CLOUDSTACK-7277: [Hyper-V] For vmsync first VMs are listed and their power state is
determined. To exclude hosted system we filter the result on Caption='Virtual Machine'
but this string is locale dependent so it may not not work properly for locales other
than english. To overcome this now we started using ProcessId >= 0 filter
2014-08-18 11:38:29 +05:30
Anshul Gangwar
d1796c5f58 CLOUDSTACK-7235: [Hyper-V] In case of any exception in ModifyStoragePoolCommand, now we are returning appropriate error 2014-08-18 11:38:29 +05:30
Anshul Gangwar
0ecc9f79af CLOUDSTACK-7234: stop sending smb credentials to Hyper-v agent 2014-08-18 11:38:29 +05:30
Anshul Gangwar
97f5281cf4 CLOUDSTACK-7177: Fixed AlertSyslogAppender does not honor a non-default port in sysloghost parameter 2014-08-18 11:38:29 +05:30
seif
aadb5f4ad5 GUI modifications related to host tags 2014-08-17 23:44:35 -06:00
Koushik Das
8bc7ae695d CLOUDSTACK-7182: NPE while trying to deploy VMs in parallel in isolated network
- Check to see if network is implemented changed from 'state == Implementing||Implemented' to 'state == Implemented'.
The earlier check was a hack to prevent the issue described below.
- At the time of implementing network (using implementNetwork() method), if the VR needs to be deployed then it follows
the same path of regular VM deployment. This leads to a nested call to implementNetwork() while preparing VR nics. This
flow creates issues in dealing with network state transitions. The original call puts network in "Implementing" state
and then the nested call again tries to put it into same state resulting in issues. In order to avoid it, implementNetwork()
call for VR is replaced with below code.
2014-08-18 10:43:04 +05:30
seif
59ea2e2960 Added the listHostTags API command 2014-08-17 20:38:46 -06:00
seif
fd6d083ad6 GUI changes to leverage a new control for storage tags 2014-08-17 17:18:51 -06:00
Santhosh Edukulla
34b698d44d Added few change for test suite result location
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-08-16 01:06:41 +05:30
Anthony Xu
2be02d1f51 added XS 6.5 beta1 support, will change the version after XS 6.5 is released 2014-08-15 11:45:24 -07:00
Mihaela Stoica
f212aa57c3 CLOUDSTACK-7293: UI: Fixed localization issues on the login page
- Reverted the validator.messages to the original values (jquery.validator.js).
- Added a function to localize validator.messages which is called before login.

Signed-off-by: Brian Federle <brian.federle@citrix.com>
2014-08-15 10:51:28 -07:00
Wido den Hollander
aac8b91cbe debian: Depend on qemu-system-x86 or qemu-kvm
The qemu-kvm package has become deprecated in Ubuntu 14.04 and
the right package to install would be qemu-system-x86

To maintain backwards compatibility for older Ubuntu LTS releases
we depend on qemu-system-x86 or qemu-kvm
2014-08-15 16:13:49 +02:00