apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity
22,408 Commits 304 Branches 324 Tags
Commit Graph

22408 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Hugo Trippaers
594b51c629 Fixup the license headers in the utils project. All files now use the same license header and this is enforced by the maven-license-check plugin. 2014-02-18 12:08:36 +01:00
Ashutosh K
860b020950 CLOUDSTACK-4840: Adding first set of test cases for Multiple IPs per NIC feature 2014-02-18 15:51:57 +05:30
Hugo Trippaers
a369647bca Fix license headers 2014-02-18 10:16:31 +01:00
Antonio Fornie
510972abde Nvp and rest refactoring and more tests 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-18 09:51:54 +01:00
John Kinsella
dda47dbd67 package.sh: cleaning up formatting 
No logic changes made. Tested no syntax errors added.
 2014-02-17 10:51:34 -08:00
John Kinsella
9dd57c22b0 CLOUDSTACK-6129: removing hard-coded script names 
Replacing whatami with $0 which is how UNIX shell scripts should get the
script's name.

BUG-ID: CLOUDSTACK-6129
Bugfix-for:
Reviewed-by:
Reported-by:
Signed-off-by: John Kinsella <jlk@stratosec.co> 1392660036 -0800
 2014-02-17 10:00:36 -08:00
John Kinsella
9f72443bb1 CLOUDSTACK-6123: Ensuring no color in grep output 2014-02-15 21:26:40 -08:00
Sheng Yang
2b1b4352bc Revert "CLOUDSTACK-5779: Fix missing clean up period for VR" 
This reverts commit 161e7d93ca9d03e9aa7e7be9e12d1ad337de9b14.

Duplicate code, bad memory...
 2014-02-14 19:40:00 -08:00
Sheng Yang
cc8eebeca5 CLOUDSTACK-5779: Fix VR commands which didn't use accessIp to VR 2014-02-14 19:20:00 -08:00
Sheng Yang
deb55acd14 CLOUDSTACK-6047: Made VR scripts name to constant string 2014-02-14 18:10:11 -08:00
Sheng Yang
6bde675f87 Remove SetupGuestNetworkAnswer 
It's unnecessary and not different from Answer itself.
 2014-02-14 18:10:05 -08:00
Sheng Yang
161e7d93ca CLOUDSTACK-5779: Fix missing clean up period for VR 2014-02-14 18:10:00 -08:00
Jessica Wang
e1e16a2301 CLOUDSTACK-6120: UI > listView widget > sorting order > fire only one sorting API call(updateXXXXXXX&sortKey=n&id=UUID) for items who have the same UUID. 
e.g. An Template/ISO of multiple zones have the same UUID.
 2014-02-14 12:55:53 -08:00
Hugo Trippaers
443acac927 Fix functional issue introduced by some findbug changes. 2014-02-14 18:37:47 +01:00
Hugo Trippaers
97bad4f9b3 Fix checkstyle and license issues 2014-02-14 18:37:47 +01:00
Daan Hoogland
15fa2ef8df findbugs: check for system template id == -> equals() 2014-02-14 18:37:47 +01:00
Daan Hoogland
0d7a96526c error message containing array content instead of array 2014-02-14 18:37:47 +01:00
wrodrigues
3199de69fe Fixes on Contrail and Mon InMemory plugins; adding comments about the changes. 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:47 +01:00
Antonio Fornie
cbea6d26e8 Fix and test GroupBy SQL query creation 
Signed-off-by: Ian Southam <isoutham@schubergphilis.com>
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:46 +01:00
Miguel Ferreira
8649fa005a Fix findbugs findings in cloud-plugin-network-elb 
Findings:
    - comparing Longs by reference
    - possible null pointer dereference

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:46 +01:00
Ian Southam
5a6ad11fa2 findbugs findings 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:46 +01:00
Ian Southam
33c2c87287 Findbugs finding 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:46 +01:00
miguelaferreira
1237bf3222 Fix findbugs findings in cloudstack-service-console-proxy-rdpclient 
Findings:
- 32 int shifted by an amount not in range -31..31:
	The shifts by 32 bits don't actually have any effect on the value
	(as shown by the tests)
- possible null pointer dereference
- repeated conditional test
- field only ever set to null
	All other uses of the field were to check if it was null,
	which it was, so it was removed

Other actions:
- Upgrade jUnit to version 4
- Add PowerMock dependency

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:46 +01:00
Hugo Trippaers
ef2ced7564 Fix findbugs findings in cloud-plugin-network-ovs 
OvsTunnelManagerImpl.java:456, RC_REF_COMPARISON, Priority: High

Serveral low priority fixes
 2014-02-14 18:37:46 +01:00
Hugo Trippaers
cc6938e3a8 Findbugs : Fix several "of concern" findings. 2014-02-14 18:37:46 +01:00
Hugo Trippaers
091694ceb2 Findbugs : NP_NULL_PARAM_DEREF_NONVIRTUAL fixed 2014-02-14 18:37:45 +01:00
Hugo Trippaers
26b32141a8 Findbugs : Fixes for several findings 
Made a comment on the use of ConcurrentHashMap for _agent
Conflicts:
	engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
 2014-02-14 18:37:45 +01:00
Hugo Trippaers
9b841af529 Findbugs : A map can't retrieve an object by index, so get(0) would 
return null. Changed to retrieve the first entry in the map.

Removed the ExecutionException try catch, this would prevent the
unittest from giving accurate information on exceptions. Avoid catching
checked exceptions in a unittest, use expected keyword on @Test instead.
 2014-02-14 18:37:45 +01:00
Hugo Trippaers
d4d49578dc Findbugs : Fix a number of potential NPEs and minor findings 2014-02-14 18:37:45 +01:00
Alex Hitchins
e0a4b7c891 Findbugs - Long equality fix. 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:45 +01:00
Alex Hitchins
39cfc4968c AJH Findbugs [8] - Added .toString() to enum. 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:45 +01:00
Alex Hitchins
b8c228e151 AJH Findbugs [9] - Added object to map rather than string 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:45 +01:00
wrodrigues
f414018a60 adding fix and unit tests for cloud-engine-api scariest 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:44 +01:00
wrodrigues
0ff943337c fixing FindBugs scariest for replaceFirst() method call that does not assign the return value 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:44 +01:00
Sander Botman
16aa73c2c8 Fixing some of the scary bugs possible null pointer: created testSetNicDevIdIfCorrectVifIsNotNull 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:44 +01:00
vetrivelc
e171cb181c Fixed-Hardcoding-Issues 2014-02-14 07:44:54 -08:00
Likitha Shetty
db91e54bf3 CLOUDSTACK-6112. Adding VPC router to a guest network fails with StringIndexOutOfBoundsException. 2014-02-14 17:01:27 +05:30
Marcus Sorensen
ce6539bd43 add new devcloud-kvm config 2014-02-09 00:20:01 -07:00
Marcus Sorensen
df77c4310a CLOUDSTACK-6103: Pass VM iso information along with 
PrepareForMigrationCommand, so that destination hypervisor can
mount pool. This further exposed an issue for KVM where iso
was not getting cleaned up upon successful migration, fixed as well.
 2014-02-14 00:34:48 -07:00
Brian Federle
63c22a1508 Session expire: show overlay on dialog to prevent clicking in UI 2014-02-13 15:06:09 -08:00
Brian Federle
0ea93d6904 Form dialog UI: Support on cancel action 
If args.cancel is passed to createForm widget, call it when cancel button is
clicked.

Example:

createForm: {
    cancel: function() { ... },
    ...
}
 2014-02-13 14:33:53 -08:00
Daan Hoogland
8e4d020cf8 remove nic with dhcp and tests 
Signed-off-by: Alena Prokharchyk <alena.prokharchyk@citrix.com>
 2014-02-13 10:39:02 -08:00
Jayapal
3136401d40 CLOUDSTACK-6083 corrected firewall rule cidr load issue 2014-02-13 14:42:38 +05:30
Marcus Sorensen
b77b55f040 CLOUDSTACK-6089: Use resource tag's key to determine match in 
equals() method for ResourceTagResponse
 2014-02-12 17:00:10 -07:00
Marcus Sorensen
7064972997 Fix someone's broken push due to bad checkstyle (VMwareGuru.java unused imports) 2014-02-12 16:26:33 -07:00
Marcus Sorensen
d33798f0d9 CLOUDSTACK-6089: Implement equals() method for ResourceTagResponse 
so that the java Set can properly determine if a ResourceTagResponse
is unique. This ensures we don't get duplicate resource tags showing
up any time a UserVmResponse is crafted (which can be quite often
due to the way the responses are crafted).
 2014-02-12 16:10:48 -07:00
Likitha Shetty
9f597ef130 CLOUDSTACK-6056. Enabling static NAT rule for a portable public IP fails with error "Failed to enable static nat". 
router.extra.public.nics isn't being honoured and so when an ip that is acquired from the additional VLAN range
is being configured it failed.
 2014-02-12 15:53:45 +05:30
Gaurav Aradhye
9174020d9a CLOUDSTACK-6066: Improved migration code to handle scenarios 
according to hypervisor type
 2014-02-12 10:04:39 +05:30
Laszlo Hornyak
351ccf3755 Cleanup in UriUtils.getUpdateUri 
- String instantiation replaced with StringBuilder and empty string constant

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-11 20:44:57 +01:00
Laszlo Hornyak
59364ee9a4 Added test for UriUtils.getUpdateUri 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-11 20:43:49 +01:00