* api: fix type Destroy volume can be recovered
* Update api/src/main/java/com/cloud/storage/Volume.java
Co-authored-by: dahn <daan.hoogland@gmail.com>
* Use Physical size to evaluate if migration is possible
* Improve logging and consider files skipped as failure in complete migration
* skipped can't be negative
* remove useless method
* group multidisk templates for secstor migration
* use enum
* Update engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/DataMigrationUtility.java
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Pearl d'Silva <pearl.dsilva@shapeblue.com>
Fixes#5534
As pre 3.x APIs allow using internal DB IDs, even normal users can use internal IDs.
This fix removes additional information in error message when the caller doesn't have access to the resource.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* fix new UI missing 4 parameters when adding a BareMetal host
* remove test options
* add rule for hosttag with baremetal
* fixes password not provided
* Enable resetting config values to default value
Provide reset button to zone,cluster,domain,account,
primary and secondary storage so that config values
can be reset to default value
* fix ui issue
* Update test/integration/smoke/test_reset_configuration_settings.py
* Update test/integration/smoke/test_reset_configuration_settings.py
Co-authored-by: Rakesh Venkatesh <rakeshv@apache.org>
Co-authored-by: dahn <daan.hoogland@gmail.com>
Related to PR #5549 changed the notification from $notification to $showNotification. This PR aims to change it back to the way it was for easier use while keeping the delete all button.
* test: fix test_configdrive.py and move it to smoke test
(sleep 30s as vm crashes after migration in ubuntu 20.04)
* Update test/integration/smoke/test_configdrive.py
Co-authored-by: dahn <daan.hoogland@gmail.com>
* test: fix test_configdrive.py
* Update #5528: move back to component test
Co-authored-by: dahn <daan.hoogland@gmail.com>
* ui: fix add network offering for vpc
Fixes issues with form related to supported services provider and router service offering when offering to be created for VPC.
Fixes#5807
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* fix issues getting with making select element update on options change (loop infinity) (#72)
* fixes
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: Hoang Nguyen <hoangnm@unitech.vn>
* add clear all notification button
* change position set count notify
* get notification count
* set label transliteration
* add margin for notification
* change position of clear notification button
* add footer text option for login screen
* using single key for policy
* set empty for default policy text
* rename footer text key
* rename the footer text property name
* change position avoid breaking with docHelp
* change position of properties
* Randomize managed volume copy host
* Managed volume copy was always returning first host that could see storage pools
* Fix null value in logging for ScaleIOPrimaryDataStoreDriver due to if/else logic error
Signed-off-by: Marcus Sorensen <mls@apple.com>
* Use String.format for ScaleIO debug message
Signed-off-by: Marcus Sorensen <mls@apple.com>
* Update debug message for ScaleIO copy methods
Signed-off-by: Marcus Sorensen <mls@apple.com>
Co-authored-by: Marcus Sorensen <mls@apple.com>
In the UI, when selecting a service offering that has a root disk enforced, stills show the root disk size of the template (or the custom size gave by the user). This PR fixes this issue, that thas been reported in #5777.
Fixes: #5777
* ui: prevent incorrect tags displa for primary storage
Tags in info card of the UI are related to tags functionality(create/delete/lsitTags API)
UI was incorrectly showing storage tags as these tags in the UI.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* remove logging
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* ui: show tags only for supported resources
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* kvm: don't force scsi controller for aarch64 VMs
This would allow use of virtio disk controller with Ceph, etc or as
defined in the VM's root disk controller setting, rather than always
enforce SCSI.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
* remove test that doesn't apply now
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
* address review comment
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
* network: update ip in lb/pf/dnat tables when update vm nic ip
* Update: create 3 separated methods for DNAT/LB/PF update
* Update: invert if condition to reduce code indentation
* server: Fix NPE while deleting a domain
While deleting a domain, if vlan ip range cant be found
then this will throw NPE. Just return false if vlan ip
range cant be found
* return true if vlan is not found
* change output message
Co-authored-by: Rakesh Venkatesh <rakeshv@apache.org>
* server: Fix NPE while adding network to VPC
Sometimes adding network to VPC fails because of libirt error.
In that case the new network wont have any VR's associated with it
and hence it will return null.
* use collectionutils
Co-authored-by: Rakesh Venkatesh <rakeshv@apache.org>
* Enhance log message in FirstFitPlanner
When cluster reached capacity threshold the message is:
"capacity threshold defined at each cluster/ at global value for capacity Type : 0"
Admins hardly remember the Capacity Type and it can take a while to look at which is the resource for the respective ID. This enhancement addes log message pointing to the capacity name (e.g. Memory / CPU) as well as global settings parameter name and value to be looked at.
* Change formatation in String 'warnMessageForClusterReachedCapacityThreshold'
Currently, when updating a service offering there is a limitation of the number of domains the offering can be updated.
Multiple domain ids lead to the following API error:
Error: (HTTP 431, error code 9999) Unable to execute API command updateserviceoffering due to invalid value. Value greater than max allowed length 255 for param: domainIds"
* conditional broadcastUri
* add filter to keep order and apply to details as well
* use global isAdmin method
Co-authored-by: Daan Hoogland <dahn@onecht.net>
* internal ref replaced by uuid
* remove all internal DB IDs from usage records
* remove superfluent .append(")")
Co-authored-by: Daan Hoogland <dahn@onecht.net>
This PR improves the volume file search on the datastore while computing the VM snapshot chain size in VMware. The file search is now performed in the VM directory on the datastore, instead of all the directories on the datastore (which is leading to incorrect VM snapshot chain size computation when VM id has 6 digits).
