27821 Commits

Author SHA1 Message Date
wilderrodrigues
212ae884a1 Formatting class ClusterServiceServletImpl
- Splitting format commit from fix commit.

Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-06-25 09:14:23 +02:00
wilderrodrigues
e4f7fb74ef Using Profiler class, from the utils package, instead of System.currentTimeMillis()
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #524
2015-06-25 09:13:46 +02:00
wilderrodrigues
ea1f2eb049 Formatting class ClusterManagerImpl
- Splitting format commit from fix commit.

Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-06-25 09:13:46 +02:00
Rene Moser
af902fd9d9 CLOUDSTACK-8578: implement state=present for listing only non-destroyed VMs
So the behavior before this fix can be used in a proper way.

Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #513
2015-06-24 20:21:33 +02:00
Daan Hoogland
55c1d9f3fa findbugs: fields of serializable made serializable
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #522
2015-06-24 20:20:12 +02:00
Gaurav Aradhye
f18c8f8d9b CLOUDSTACK-8582: Modifying tag for test cases which should not be run on simulator
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #521
2015-06-24 16:52:24 +05:30
Rajani Karuturi
a3fe76a4c4 Merge branch 'findbugs-MF' of https://github.com/DaanHoogland/cloudstack
This close #520
2015-06-24 16:29:34 +05:30
Daan Hoogland
8a8849354c findbugs: masking fields removed 2015-06-24 12:24:12 +02:00
wilderrodrigues
6c5bc96174 Merge branch 'test/pr518' 2015-06-24 09:54:07 +02:00
wilderrodrigues
4463881be4 Merge branch 'stop_vm' of https://github.com/nitt10prashant/cloudstack into test/pr518
This closes #518

Remark: I had to merge in the old-fashion way (not using the PR alias) due to a problem with the patch
2015-06-24 09:52:26 +02:00
pritisarap12
da72bb9aeb CLOUDSTACK-8574: Skip testcases for LXC if storagePool type is not RBD
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #488
2015-06-24 09:43:55 +02:00
pritisarap12
6f643fc486 CLOUDSTACK-8574: Skip testcases including data disk creation for LXC if storagePool type is not RBD
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-06-24 09:43:55 +02:00
pritisarap12
7d70e4975e CLOUDSTACK-8576: Skip tests as snapshots and template are not supported on LXC
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #506
2015-06-24 09:40:08 +02:00
wilderrodrigues
cbf5155f7b Renaming a couple of varibale to avoid misunderstanding
- All "micro" references have been replaced with "nano"

Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #516
2015-06-24 09:36:41 +02:00
wilderrodrigues
2f145378df Testing the elapsed time between 2 consecultive calls to System.nanoTime()
- 1 test was added

Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-06-24 09:36:40 +02:00
wilderrodrigues
5557ad5588 Offer a getDurationInMillis() method in the Profiler utility class
- New implementation uses nanoseconds. Due to that, the places where the Profiler is used as a Monitor and/or
     a stopwatch will suffer with the difference in the return
   - Also added a getDuration(), which returns the time in nanoseconds in case someone wants to use it instead
   - Added an extra test to check if the getDuration() works fine with nanoseconds
   - Fixed the test that checks the time in milliseconds: I added an error margin to cover the test better

Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-06-24 09:36:40 +02:00
Daan Hoogland
e3daa10960 findbugs: final fields
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #517
2015-06-24 09:29:56 +02:00
Gaurav Aradhye
230cf2eefa CLOUDSTACK-8582: Tagging test cases which should not be run on simulator accordingly
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #519
2015-06-24 12:50:27 +05:30
nitt10prashant
4577af7206 CLOUDSTACK-8583 :fixing issue related to script test_stopped_vm 2015-06-24 12:31:23 +05:30
Rafael da Fonseca
c599f63170 Extend wait before retry to states other than 'Starting'
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #514
2015-06-24 07:34:26 +02:00
nitt10prashant
77508c9d9a CLOUDSTACK-8577: fixing script testpath_disable_enable_zone 2015-06-24 10:50:20 +05:30
nitt10prashant
49451750a9 CLOUDSTACK-8577: fixing script testpath_disable_enable_zone 2015-06-24 10:50:19 +05:30
Daan Hoogland
8a99df77b6 findbugs volumeInfo is known to not be null
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #515
2015-06-23 23:27:04 +02:00
Daan Hoogland
e8984d16ed findbugs: move assert to a place where it still makes sense
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-06-23 23:27:03 +02:00
Rene Moser
82ecc1aa06 CLOUDSTACK-8578: fix listVirtualMachines does not return deleted machines when zone is specified
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #510
2015-06-23 14:53:08 +02:00
Sanjeev Neelarapu
66d51c91ea Made misc changes
Reviewed-By: Shweta
2015-06-23 17:47:19 +05:30
Gaurav Aradhye
c841d6850e CLOUDSTACK-8579: Fix cleanup operation in few test cases
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #511
2015-06-23 17:36:44 +05:30
wilderrodrigues
f29bf1e85c Add unit tests to cover negative cases
- Cover when the profile is not started/stopped

Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #509
2015-06-23 10:03:20 +02:00
wilderrodrigues
78c802a539 Replace System.currentTimeMillis() by System.nanoTime()
- System.nanoTime() is the best way to measure elapsed time in Java.
   - It gives a resolution on the order of microseconds

The System.currentTimeMillis() is used when calculating absolut time.

Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-06-23 10:03:20 +02:00
Daan Hoogland
c0a1009740 findbugs: (un)boxing of long from string 2015-06-22 13:18:14 +02:00
Rafael da Fonseca
fe4f0b1a58 Specify all dependency versions in pom.xml
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #497
2015-06-22 13:01:19 +02:00
Rafael da Fonseca
83488e01af Reduce about 1k String objects from being instantiated
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-22 13:01:19 +02:00
Rafael da Fonseca
9d19191bc6 Root cause of failure is memory abuse in XenTest.java class ;) This should fix it
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-22 13:01:19 +02:00
Rafael da Fonseca
301a7b9a7e Specify all external dependencies in pom Upgrade to lang3 and change usage of deprecated xmlparse method
Add another missing dependency

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-22 13:01:19 +02:00
Rafael da Fonseca
1603f722c4 Cleanup some lint checker warning in base classes
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-22 13:01:18 +02:00
Rafael da Fonseca
540b163cfc Resolve unsafe cast warnings reported by lint checker Add some debug config to compiler plugin
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-22 13:01:18 +02:00
Rafael da Fonseca
53e42fb45e Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in Upgrade410to420.java
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #505
2015-06-22 10:55:29 +02:00
Rafael da Fonseca
b929db1f1a Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in ElastistorPrimaryDataStoreLifeCycle.java
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #503
2015-06-22 10:54:55 +02:00
Rafael da Fonseca
a17852aaf4 Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in ElastistorUtil.java
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #504
2015-06-22 10:54:19 +02:00
Rafael da Fonseca
0d8c64ea56 Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in OvmResourceBase.java
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #502
2015-06-22 10:50:48 +02:00
Rafael da Fonseca
dc359c505e Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in BareMetalResourceBase.java
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #501
2015-06-22 10:50:12 +02:00
Rafael da Fonseca
58eac0b49d Fix 2 more findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in Upgrade218to22.java
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #500
2015-06-22 10:49:35 +02:00
Rafael da Fonseca
f038a740a5 Fix 2 findbugs occurences of DM_BOXED_PRIMITIVE_FOR_PARSING in Upgrade218to22.java
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #499
2015-06-22 10:48:49 +02:00
Rafael da Fonseca
dc40f6117b Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in DeployVMCmd.java
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #498
2015-06-22 10:47:48 +02:00
Rafael da Fonseca
6fd49e49a3 Add apache license header to script
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #482
2015-06-21 15:13:27 +02:00
Rafael da Fonseca
4f098a1b90 Check return code on plugin runs
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-06-21 15:13:27 +02:00
Rafael da Fonseca
b9f5d38772 Improve plugin dependency download Add download for midonet and juniper stuff, this increases runtime for a few minutes, may remove in future if travis show too much overhead
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-06-21 15:13:27 +02:00
Rafael da Fonseca
0d671b9e54 Some of the plugin dependencies were'nt being properly resolved on the dependency:resolve-plugins mojo This adds a couple more dark magic sprinkles to make sure no dependencies will be downloaded at build time
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-06-21 15:13:27 +02:00
Rafael da Fonseca
358157f57c Manually add another dependency to be downloaded before build
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-06-21 15:13:27 +02:00
Rafael da Fonseca
e4f09e9ebc Allow proper retry in pip install command
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-06-21 15:13:27 +02:00