apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

findbugs: comparison of wrapper classes should use equals

Browse Source
This commit is contained in:
Daan Hoogland 2015-04-12 21:00:21 +02:00
parent 67719b1be0
commit d3a98ab0d0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java
View File

@ -684,7 +684,7 @@ NetworkACLServiceProvider, FirewallServiceProvider, ResourceStateAdapter {
} }
cidrList = r.getSourceCidrList(); cidrList = r.getSourceCidrList();
if(cidrList != null){ if(cidrList != null){
if(cidrList.size()>1 || r.getSourcePortEnd()!=r.getSourcePortStart()){ if (cidrList.size() > 1 || !r.getSourcePortEnd().equals(r.getSourcePortStart())) {
throw new ResourceUnavailableException("One CIDR and one port only please.", throw new ResourceUnavailableException("One CIDR and one port only please.",
Network.class, network.getId()); Network.class, network.getId());
} else { } else {
@ -718,7 +718,7 @@ NetworkACLServiceProvider, FirewallServiceProvider, ResourceStateAdapter {
} }
cidrList = r.getSourceCidrList(); cidrList = r.getSourceCidrList();
if(cidrList != null){ if(cidrList != null){
if(cidrList.size()>1 || r.getSourcePortEnd()!=r.getSourcePortStart()){ if (cidrList.size() > 1 || !r.getSourcePortEnd().equals(r.getSourcePortStart())) {
throw new ResourceUnavailableException("One CIDR and one port only please.", throw new ResourceUnavailableException("One CIDR and one port only please.",
Network.class, network.getId()); Network.class, network.getId());
} else { } else {