From d3a98ab0d00c787cb0fe2b53d532de65c873f4fb Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Sun, 12 Apr 2015 21:00:21 +0200 Subject: [PATCH] findbugs: comparison of wrapper classes should use equals --- .../src/com/cloud/network/element/BigSwitchBcfElement.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java b/plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java index 37391a6eb9c..1dbf62df0e0 100644 --- a/plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java +++ b/plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java @@ -684,7 +684,7 @@ NetworkACLServiceProvider, FirewallServiceProvider, ResourceStateAdapter { } cidrList = r.getSourceCidrList(); if(cidrList != null){ - if(cidrList.size()>1 || r.getSourcePortEnd()!=r.getSourcePortStart()){ + if (cidrList.size() > 1 || !r.getSourcePortEnd().equals(r.getSourcePortStart())) { throw new ResourceUnavailableException("One CIDR and one port only please.", Network.class, network.getId()); } else { @@ -718,7 +718,7 @@ NetworkACLServiceProvider, FirewallServiceProvider, ResourceStateAdapter { } cidrList = r.getSourceCidrList(); if(cidrList != null){ - if(cidrList.size()>1 || r.getSourcePortEnd()!=r.getSourcePortStart()){ + if (cidrList.size() > 1 || !r.getSourcePortEnd().equals(r.getSourcePortStart())) { throw new ResourceUnavailableException("One CIDR and one port only please.", Network.class, network.getId()); } else {