mirror of
https://github.com/apache/cloudstack.git
synced 2025-10-26 08:42:29 +01:00
- Move database access code to new class DatabaseAccessObject.
This was done to ease the effort of testing, since
DbUpgradeUtils has a static API and it is harder to mock
static things with Mockito.
- Log exceptions even if ignored
- Add unit tests for both DbUpgradeUtils and DatabaseAccessObject
- DbUpgradeUtils.dropTableColumnsIfExist(...) no longer throws
CloudRuntimeException to make it consistent with the other methods in
the class
Signed-off-by: Daan Hoogland <daan@onecht.net>
163 lines
6.1 KiB
Java
163 lines
6.1 KiB
Java
// Licensed to the Apache Software Foundation (ASF) under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing,
|
|
// software distributed under the License is distributed on an
|
|
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
// KIND, either express or implied. See the License for the
|
|
// specific language governing permissions and limitations
|
|
// under the License.
|
|
package com.cloud.upgrade.dao;
|
|
|
|
import static org.mockito.Matchers.anyString;
|
|
import static org.mockito.Matchers.eq;
|
|
import static org.mockito.Mockito.times;
|
|
import static org.mockito.Mockito.verify;
|
|
import static org.powermock.api.mockito.PowerMockito.when;
|
|
|
|
import java.sql.Connection;
|
|
import java.util.ArrayList;
|
|
import java.util.Arrays;
|
|
import java.util.List;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.Mock;
|
|
import org.powermock.modules.junit4.PowerMockRunner;
|
|
import org.powermock.reflect.Whitebox;
|
|
|
|
@RunWith(PowerMockRunner.class)
|
|
public class DbUpgradeUtilsTest {
|
|
|
|
@Mock
|
|
private Connection connectionMock;
|
|
|
|
@Mock
|
|
private DatabaseAccessObject daoMock;
|
|
|
|
@Before
|
|
public void setupClass() {
|
|
Whitebox.setInternalState(DbUpgradeUtils.class, "dao", daoMock);
|
|
}
|
|
|
|
@Test
|
|
public void testDropKeyIfExistWhenNoKeysAreSupplied() throws Exception {
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
List<String> keys = new ArrayList<String>();
|
|
boolean isForeignKey = false;
|
|
|
|
DbUpgradeUtils.dropKeysIfExist(conn, tableName, keys, isForeignKey);
|
|
|
|
verify(daoMock, times(0)).dropKey(eq(conn), eq(tableName), anyString(), eq(isForeignKey));
|
|
}
|
|
|
|
@Test
|
|
public void testDropKeyIfExistWhenOneKeysIsSupplied() throws Exception {
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
String key = "key";
|
|
List<String> keys = Arrays.asList(new String[] {key});
|
|
boolean isForeignKey = false;
|
|
|
|
DbUpgradeUtils.dropKeysIfExist(conn, tableName, keys, isForeignKey);
|
|
|
|
verify(daoMock, times(1)).dropKey(conn, tableName, key, isForeignKey);
|
|
}
|
|
|
|
@Test
|
|
public void testDropKeyIfExistWhenThreeKeysAreSupplied() throws Exception {
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
String key1 = "key1";
|
|
String key2 = "key2";
|
|
List<String> keys = Arrays.asList(new String[] {key1, key2});
|
|
boolean isForeignKey = false;
|
|
|
|
DbUpgradeUtils.dropKeysIfExist(conn, tableName, keys, isForeignKey);
|
|
|
|
verify(daoMock, times(1)).dropKey(conn, tableName, key1, isForeignKey);
|
|
verify(daoMock, times(1)).dropKey(conn, tableName, key2, isForeignKey);
|
|
}
|
|
|
|
@Test
|
|
public void testDropPrimaryKey() throws Exception {
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
|
|
DbUpgradeUtils.dropPrimaryKeyIfExists(conn, tableName);
|
|
|
|
verify(daoMock, times(1)).dropPrimaryKey(conn, tableName);
|
|
}
|
|
|
|
@Test
|
|
public void testDropTableColumnsIfExistWhenNoKeysAreSupplied() throws Exception {
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
List<String> columns = new ArrayList<String>();
|
|
|
|
DbUpgradeUtils.dropTableColumnsIfExist(conn, tableName, columns);
|
|
|
|
verify(daoMock, times(0)).columnExists(eq(conn), eq(tableName), anyString());
|
|
verify(daoMock, times(0)).dropColumn(eq(conn), eq(tableName), anyString());
|
|
}
|
|
|
|
@Test
|
|
public void testDropTableColumnsIfExistWhenOneKeysIsSuppliedAndColumnExists() throws Exception {
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
String column = "column";
|
|
when(daoMock.columnExists(conn, tableName, column)).thenReturn(true);
|
|
List<String> columns = Arrays.asList(new String[] {column});
|
|
|
|
DbUpgradeUtils.dropTableColumnsIfExist(conn, tableName, columns);
|
|
|
|
verify(daoMock, times(1)).columnExists(conn, tableName, column);
|
|
verify(daoMock, times(1)).dropColumn(conn, tableName, column);
|
|
}
|
|
|
|
@Test
|
|
public void testDropTableColumnsIfExistWhenOneKeysIsSuppliedAndColumnDoesNotExists() throws Exception {
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
String column = "column";
|
|
when(daoMock.columnExists(conn, tableName, column)).thenReturn(false);
|
|
List<String> columns = Arrays.asList(new String[] {column});
|
|
|
|
DbUpgradeUtils.dropTableColumnsIfExist(conn, tableName, columns);
|
|
|
|
verify(daoMock, times(1)).columnExists(conn, tableName, column);
|
|
verify(daoMock, times(0)).dropColumn(conn, tableName, column);
|
|
}
|
|
|
|
@Test
|
|
public void testDropTableColumnsIfExistWhenThreeKeysAreSuppliedAnOneDoesnotExist() throws Exception {
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
String column1 = "column1";
|
|
String column2 = "column2";
|
|
String column3 = "column3";
|
|
when(daoMock.columnExists(conn, tableName, column1)).thenReturn(true);
|
|
when(daoMock.columnExists(conn, tableName, column2)).thenReturn(false);
|
|
when(daoMock.columnExists(conn, tableName, column3)).thenReturn(true);
|
|
List<String> keys = Arrays.asList(new String[] {column1, column2, column3});
|
|
|
|
DbUpgradeUtils.dropTableColumnsIfExist(conn, tableName, keys);
|
|
|
|
verify(daoMock, times(1)).columnExists(conn, tableName, column1);
|
|
verify(daoMock, times(1)).dropColumn(conn, tableName, column1);
|
|
verify(daoMock, times(1)).columnExists(conn, tableName, column2);
|
|
verify(daoMock, times(0)).dropColumn(conn, tableName, column2);
|
|
verify(daoMock, times(1)).columnExists(conn, tableName, column3);
|
|
verify(daoMock, times(1)).dropColumn(conn, tableName, column3);
|
|
}
|
|
}
|