mirror of
https://github.com/apache/cloudstack.git
synced 2025-10-26 08:42:29 +01:00
- Move database access code to new class DatabaseAccessObject.
This was done to ease the effort of testing, since
DbUpgradeUtils has a static API and it is harder to mock
static things with Mockito.
- Log exceptions even if ignored
- Add unit tests for both DbUpgradeUtils and DatabaseAccessObject
- DbUpgradeUtils.dropTableColumnsIfExist(...) no longer throws
CloudRuntimeException to make it consistent with the other methods in
the class
Signed-off-by: Daan Hoogland <daan@onecht.net>
464 lines
18 KiB
Java
464 lines
18 KiB
Java
// Licensed to the Apache Software Foundation (ASF) under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing,
|
|
// software distributed under the License is distributed on an
|
|
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
// KIND, either express or implied. See the License for the
|
|
// specific language governing permissions and limitations
|
|
// under the License.
|
|
package com.cloud.upgrade.dao;
|
|
|
|
import static org.mockito.Matchers.any;
|
|
import static org.mockito.Matchers.anyString;
|
|
import static org.mockito.Matchers.contains;
|
|
import static org.mockito.Matchers.eq;
|
|
import static org.mockito.Mockito.doThrow;
|
|
import static org.mockito.Mockito.times;
|
|
import static org.mockito.Mockito.verify;
|
|
import static org.mockito.Mockito.when;
|
|
|
|
import java.sql.Connection;
|
|
import java.sql.PreparedStatement;
|
|
import java.sql.SQLException;
|
|
|
|
import org.apache.log4j.Logger;
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.Mock;
|
|
import org.mockito.internal.util.reflection.Whitebox;
|
|
import org.mockito.runners.MockitoJUnitRunner;
|
|
|
|
@RunWith(MockitoJUnitRunner.class)
|
|
public class DatabaseAccessObjectTest {
|
|
|
|
@Mock
|
|
private PreparedStatement preparedStatementMock;
|
|
|
|
@Mock
|
|
private Connection connectionMock;
|
|
|
|
@Mock
|
|
private Logger loggerMock;
|
|
|
|
private final DatabaseAccessObject dao = new DatabaseAccessObject();
|
|
|
|
@Before
|
|
public void setup() {
|
|
Whitebox.setInternalState(dao, "s_logger", loggerMock);
|
|
}
|
|
|
|
@Test
|
|
public void testDropKey() throws Exception {
|
|
when(connectionMock.prepareStatement(contains("DROP KEY"))).thenReturn(preparedStatementMock);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
String key = "key";
|
|
boolean isForeignKey = false;
|
|
|
|
dao.dropKey(conn, tableName, key, isForeignKey);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(1)).executeUpdate();
|
|
verify(preparedStatementMock, times(1)).close();
|
|
verify(loggerMock, times(1)).debug(anyString());
|
|
verify(loggerMock, times(0)).warn(anyString(), any(Throwable.class));
|
|
}
|
|
|
|
@Test(expected = NullPointerException.class)
|
|
public void testDropKeyWhenConnectionIsNull() throws Exception {
|
|
Connection conn = null;
|
|
String tableName = "tableName";
|
|
String key = "key";
|
|
boolean isForeignKey = false;
|
|
|
|
dao.dropKey(conn, tableName, key, isForeignKey);
|
|
}
|
|
|
|
@Test
|
|
public void testDropKeyWhenTableNameIsNull() throws Exception {
|
|
SQLException sqlException = new SQLException();
|
|
when(connectionMock.prepareStatement(contains("null DROP KEY"))).thenReturn(preparedStatementMock);
|
|
when(preparedStatementMock.executeUpdate()).thenThrow(sqlException);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = null;
|
|
String key = "key";
|
|
boolean isForeignKey = false;
|
|
|
|
dao.dropKey(conn, tableName, key, isForeignKey);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(1)).executeUpdate();
|
|
verify(preparedStatementMock, times(1)).close();
|
|
verify(loggerMock, times(0)).debug(anyString());
|
|
verify(loggerMock, times(1)).warn(anyString(), eq(sqlException));
|
|
}
|
|
|
|
@Test
|
|
public void testDropKeyWhenKeyIsNull() throws Exception {
|
|
SQLException sqlException = new SQLException();
|
|
when(connectionMock.prepareStatement(contains("DROP KEY null"))).thenReturn(preparedStatementMock);
|
|
when(preparedStatementMock.executeUpdate()).thenThrow(sqlException);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
String key = null;
|
|
boolean isForeignKey = false;
|
|
|
|
dao.dropKey(conn, tableName, key, isForeignKey);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(1)).executeUpdate();
|
|
verify(preparedStatementMock, times(1)).close();
|
|
verify(loggerMock, times(0)).debug(anyString());
|
|
verify(loggerMock, times(1)).warn(anyString(), eq(sqlException));
|
|
}
|
|
|
|
@Test
|
|
public void testDropKeyWhenKeysAreForeignKeys() throws Exception {
|
|
when(connectionMock.prepareStatement(contains("DROP FOREIGN KEY"))).thenReturn(preparedStatementMock);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
String key = "key";
|
|
boolean isForeignKey = true;
|
|
|
|
dao.dropKey(conn, tableName, key, isForeignKey);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(1)).executeUpdate();
|
|
verify(preparedStatementMock, times(1)).close();
|
|
verify(loggerMock, times(1)).debug(anyString());
|
|
verify(loggerMock, times(0)).warn(anyString(), any(Throwable.class));
|
|
}
|
|
|
|
@Test
|
|
public void testDropKeyWhenPrepareStatementResultsInException() throws Exception {
|
|
SQLException sqlException = new SQLException();
|
|
when(connectionMock.prepareStatement(any(String.class))).thenThrow(sqlException);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
String key = "key";
|
|
boolean isForeignKey = false;
|
|
|
|
dao.dropKey(conn, tableName, key, isForeignKey);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(0)).executeUpdate();
|
|
verify(preparedStatementMock, times(0)).close();
|
|
verify(loggerMock, times(0)).debug(anyString());
|
|
verify(loggerMock, times(1)).warn(anyString(), eq(sqlException));
|
|
}
|
|
|
|
@Test
|
|
public void testDropKeyWhenExecuteUpdateResultsInException() throws Exception {
|
|
SQLException sqlException = new SQLException();
|
|
when(connectionMock.prepareStatement(contains("DROP KEY"))).thenReturn(preparedStatementMock);
|
|
when(preparedStatementMock.executeUpdate()).thenThrow(sqlException);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
String key = "key";
|
|
boolean isForeignKey = false;
|
|
|
|
dao.dropKey(conn, tableName, key, isForeignKey);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(1)).executeUpdate();
|
|
verify(preparedStatementMock, times(1)).close();
|
|
verify(loggerMock, times(0)).debug(anyString());
|
|
verify(loggerMock, times(1)).warn(anyString(), eq(sqlException));
|
|
}
|
|
|
|
@SuppressWarnings("static-access")
|
|
@Test
|
|
public void testClosePreparedStatementWhenPreparedStatementIsNull() throws Exception {
|
|
PreparedStatement preparedStatement = null;
|
|
String errorMessage = "some message";
|
|
|
|
dao.closePreparedStatement(preparedStatement, errorMessage);
|
|
|
|
verify(loggerMock, times(0)).warn(anyString(), any(Throwable.class));
|
|
}
|
|
|
|
@SuppressWarnings("static-access")
|
|
@Test
|
|
public void testClosePreparedStatementWhenPreparedStatementIsNotNullAndThereIsNoException() throws Exception {
|
|
PreparedStatement preparedStatement = preparedStatementMock;
|
|
String errorMessage = "some message";
|
|
|
|
dao.closePreparedStatement(preparedStatement, errorMessage);
|
|
|
|
verify(preparedStatement, times(1)).close();
|
|
verify(loggerMock, times(0)).warn(anyString(), any(Throwable.class));
|
|
}
|
|
|
|
@SuppressWarnings("static-access")
|
|
@Test
|
|
public void testClosePreparedStatementWhenPreparedStatementIsNotNullAndThereIsException() throws Exception {
|
|
SQLException sqlException = new SQLException();
|
|
doThrow(sqlException).when(preparedStatementMock).close();
|
|
|
|
PreparedStatement preparedStatement = preparedStatementMock;
|
|
String errorMessage = "some message";
|
|
|
|
dao.closePreparedStatement(preparedStatement, errorMessage);
|
|
|
|
verify(preparedStatement, times(1)).close();
|
|
verify(loggerMock, times(1)).warn(errorMessage, sqlException);
|
|
}
|
|
|
|
@Test
|
|
public void testDropPrimaryKey() throws Exception {
|
|
when(connectionMock.prepareStatement(contains("DROP PRIMARY KEY"))).thenReturn(preparedStatementMock);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
|
|
dao.dropPrimaryKey(conn, tableName);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(1)).executeUpdate();
|
|
verify(preparedStatementMock, times(1)).close();
|
|
verify(loggerMock, times(1)).debug(anyString());
|
|
verify(loggerMock, times(0)).warn(anyString(), any(Throwable.class));
|
|
}
|
|
|
|
@Test(expected = NullPointerException.class)
|
|
public void testDropPrimaryKeyWhenConnectionIsNull() throws Exception {
|
|
Connection conn = null;
|
|
String tableName = "tableName";
|
|
|
|
dao.dropPrimaryKey(conn, tableName);
|
|
}
|
|
|
|
@Test
|
|
public void testDropPrimaryKeyWhenTableNameIsNull() throws Exception {
|
|
SQLException sqlException = new SQLException();
|
|
when(connectionMock.prepareStatement(contains("null DROP PRIMARY KEY"))).thenReturn(preparedStatementMock);
|
|
when(preparedStatementMock.executeUpdate()).thenThrow(sqlException);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = null;
|
|
|
|
dao.dropPrimaryKey(conn, tableName);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(1)).executeUpdate();
|
|
verify(preparedStatementMock, times(1)).close();
|
|
verify(loggerMock, times(0)).debug(anyString());
|
|
verify(loggerMock, times(1)).warn(anyString(), eq(sqlException));
|
|
}
|
|
|
|
@Test
|
|
public void testDropPrimaryKeyWhenPrepareStatementResultsInException() throws Exception {
|
|
SQLException sqlException = new SQLException();
|
|
when(connectionMock.prepareStatement(contains("DROP PRIMARY KEY"))).thenThrow(sqlException);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = null;
|
|
|
|
dao.dropPrimaryKey(conn, tableName);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(0)).executeUpdate();
|
|
verify(preparedStatementMock, times(0)).close();
|
|
verify(loggerMock, times(0)).debug(anyString());
|
|
verify(loggerMock, times(1)).warn(anyString(), eq(sqlException));
|
|
}
|
|
|
|
@Test
|
|
public void testDropPrimaryKeyWhenExecuteUpdateResultsInException() throws Exception {
|
|
SQLException sqlException = new SQLException();
|
|
when(connectionMock.prepareStatement(contains("DROP PRIMARY KEY"))).thenReturn(preparedStatementMock);
|
|
when(preparedStatementMock.executeUpdate()).thenThrow(sqlException);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = null;
|
|
|
|
dao.dropPrimaryKey(conn, tableName);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(1)).executeUpdate();
|
|
verify(preparedStatementMock, times(1)).close();
|
|
verify(loggerMock, times(0)).debug(anyString());
|
|
verify(loggerMock, times(1)).warn(anyString(), eq(sqlException));
|
|
}
|
|
|
|
@Test
|
|
public void testColumnExists() throws Exception {
|
|
when(connectionMock.prepareStatement(contains("SELECT"))).thenReturn(preparedStatementMock);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
String columnName = "columnName";
|
|
|
|
dao.columnExists(conn, tableName, columnName);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(1)).executeQuery();
|
|
verify(preparedStatementMock, times(1)).close();
|
|
verify(loggerMock, times(0)).warn(anyString(), any(Throwable.class));
|
|
}
|
|
|
|
@Test(expected = NullPointerException.class)
|
|
public void testColumnExistsWhenConnectionIsNull() throws Exception {
|
|
Connection conn = null;
|
|
String tableName = "tableName";
|
|
String columnName = "columnName";
|
|
|
|
dao.columnExists(conn, tableName, columnName);
|
|
}
|
|
|
|
@Test
|
|
public void testColumnExistsWhenTableNameIsNull() throws Exception {
|
|
SQLException sqlException = new SQLException();
|
|
when(connectionMock.prepareStatement(contains("FROM null"))).thenReturn(preparedStatementMock);
|
|
when(preparedStatementMock.executeQuery()).thenThrow(sqlException);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = null;
|
|
String columnName = "columnName";
|
|
|
|
dao.columnExists(conn, tableName, columnName);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(1)).executeQuery();
|
|
verify(preparedStatementMock, times(1)).close();
|
|
verify(loggerMock, times(1)).warn(anyString(), eq(sqlException));
|
|
}
|
|
|
|
@Test
|
|
public void testColumnExistsWhenColumnNameIsNull() throws Exception {
|
|
SQLException sqlException = new SQLException();
|
|
when(connectionMock.prepareStatement(contains("SELECT null"))).thenReturn(preparedStatementMock);
|
|
when(preparedStatementMock.executeQuery()).thenThrow(sqlException);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
String columnName = null;
|
|
|
|
dao.columnExists(conn, tableName, columnName);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(1)).executeQuery();
|
|
verify(preparedStatementMock, times(1)).close();
|
|
verify(loggerMock, times(1)).warn(anyString(), eq(sqlException));
|
|
}
|
|
|
|
@Test
|
|
public void testDropColumn() throws Exception {
|
|
when(connectionMock.prepareStatement(anyString())).thenReturn(preparedStatementMock);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
String columnName = "columnName";
|
|
|
|
dao.dropColumn(conn, tableName, columnName);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(0)).executeQuery();
|
|
verify(preparedStatementMock, times(1)).executeUpdate();
|
|
verify(preparedStatementMock, times(1)).close();
|
|
verify(loggerMock, times(1)).debug(anyString());
|
|
verify(loggerMock, times(0)).warn(anyString(), any(Throwable.class));
|
|
}
|
|
|
|
@Test(expected = NullPointerException.class)
|
|
public void testDropColumnWhenConnectionIsNull() throws Exception {
|
|
|
|
Connection conn = null;
|
|
String tableName = "tableName";
|
|
String columnName = "columnName";
|
|
|
|
dao.dropColumn(conn, tableName, columnName);
|
|
}
|
|
|
|
@Test
|
|
public void testDropColumnWhenTableNameIsNull() throws Exception {
|
|
SQLException sqlException = new SQLException();
|
|
when(connectionMock.prepareStatement(contains("ALTER TABLE null"))).thenReturn(preparedStatementMock);
|
|
when(preparedStatementMock.executeUpdate()).thenThrow(sqlException);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = null;
|
|
String columnName = "columnName";
|
|
|
|
dao.dropColumn(conn, tableName, columnName);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(1)).executeUpdate();
|
|
verify(preparedStatementMock, times(1)).close();
|
|
verify(loggerMock, times(0)).debug(anyString());
|
|
verify(loggerMock, times(1)).warn(anyString(), eq(sqlException));
|
|
}
|
|
|
|
@Test
|
|
public void testDropColumnWhenColumnNameIsNull() throws Exception {
|
|
SQLException sqlException = new SQLException();
|
|
when(connectionMock.prepareStatement(contains("DROP COLUMN null"))).thenReturn(preparedStatementMock);
|
|
when(preparedStatementMock.executeUpdate()).thenThrow(sqlException);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
String columnName = null;
|
|
|
|
dao.dropColumn(conn, tableName, columnName);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(1)).executeUpdate();
|
|
verify(preparedStatementMock, times(1)).close();
|
|
verify(loggerMock, times(0)).debug(anyString());
|
|
verify(loggerMock, times(1)).warn(anyString(), eq(sqlException));
|
|
}
|
|
|
|
@Test
|
|
public void testDropColumnWhenPrepareStatementResultsInException() throws Exception {
|
|
SQLException sqlException = new SQLException();
|
|
when(connectionMock.prepareStatement(anyString())).thenThrow(sqlException);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
String columnName = "columnName";
|
|
|
|
dao.dropColumn(conn, tableName, columnName);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(0)).executeUpdate();
|
|
verify(preparedStatementMock, times(0)).close();
|
|
verify(loggerMock, times(0)).debug(anyString());
|
|
verify(loggerMock, times(1)).warn(anyString(), eq(sqlException));
|
|
}
|
|
|
|
@Test
|
|
public void testDropColumnWhenexecuteUpdateResultsInException() throws Exception {
|
|
SQLException sqlException = new SQLException();
|
|
when(connectionMock.prepareStatement(anyString())).thenReturn(preparedStatementMock);
|
|
when(preparedStatementMock.executeUpdate()).thenThrow(sqlException);
|
|
|
|
Connection conn = connectionMock;
|
|
String tableName = "tableName";
|
|
String columnName = "columnName";
|
|
|
|
dao.dropColumn(conn, tableName, columnName);
|
|
|
|
verify(connectionMock, times(1)).prepareStatement(anyString());
|
|
verify(preparedStatementMock, times(1)).executeUpdate();
|
|
verify(preparedStatementMock, times(1)).close();
|
|
verify(loggerMock, times(0)).debug(anyString());
|
|
verify(loggerMock, times(1)).warn(anyString(), eq(sqlException));
|
|
}
|
|
|
|
}
|