mirror of
https://github.com/apache/cloudstack.git
synced 2025-10-26 08:42:29 +01:00
c44db2557d
Because currently the lock in the script is retried every 1 second, and it's a quite a long time that it's possible for some other active script can be executed and retain the lock again. So it's possible that the first one request the lock is always being preemptted by others, then finally got timeout. To fix this issue, the retry interval is reduced to 0.1 seconds, which would provide more retry times. And each process want to get the lock would create a file named lockname-PID.lock, and only the first one(judged by timestamp) would get the lock. The remaining ones would retry every 0.1 seconds to see if it can get the lock. Also timeout time is extended to 30 seconds. And add testcase for it. status 11772: resolved fixed
74 lines
1.5 KiB
Bash
74 lines
1.5 KiB
Bash
#!/bin/bash
|
|
|
|
# IMPORTANT: Ordering of lock:
|
|
# biglock --> rrouter
|
|
|
|
# getLockFile() parameters
|
|
# $1 lock filename
|
|
# $2 timeout seconds
|
|
getLockFile() {
|
|
__locked=0
|
|
__LOCKFILE="/tmp/$1-$$.lock"
|
|
if [ $2 ]
|
|
then
|
|
__TIMEOUT=$2
|
|
else
|
|
__TIMEOUT=30
|
|
fi
|
|
|
|
if [ -e $__LOCKFILE ]
|
|
then
|
|
logger -t cloud "Process $0 pid $$ want to get ECLUSIVE LOCK $1 RECURSIVELY!"
|
|
psline=`ps u $$`
|
|
logger -t cloud "Failed job detail: $psline"
|
|
echo 0
|
|
return
|
|
fi
|
|
|
|
touch $__LOCKFILE
|
|
|
|
for i in `seq 1 $(($__TIMEOUT * 10))`
|
|
do
|
|
currlock=`ls -tr /tmp/$1-*.lock | head -n1`
|
|
if [ $currlock -ef $__LOCKFILE ]
|
|
then
|
|
__locked=1
|
|
break
|
|
fi
|
|
sleep 0.1
|
|
if [ $((i % 10)) -eq 0 ]
|
|
then
|
|
logger -t cloud "Process $0 pid $$ waiting for the lock $1 for another 1 second"
|
|
fi
|
|
done
|
|
if [ $__locked -ne 1 ]
|
|
then
|
|
logger -t cloud "fail to acquire the lock $1 for process $0 pid $$ after $__TIMEOUT seconds time out!"
|
|
psline=`ps u $$`
|
|
logger -t cloud "Failed job detail: $psline"
|
|
fi
|
|
echo $__locked
|
|
}
|
|
|
|
# releaseLockFile() parameters
|
|
# $1 lock filename
|
|
# $2 locked(1) or not(0)
|
|
releaseLockFile() {
|
|
__LOCKFILE="/tmp/$1-$$.lock"
|
|
__locked=$2
|
|
if [ "$__locked" == "1" ]
|
|
then
|
|
rm $__LOCKFILE
|
|
fi
|
|
}
|
|
|
|
# releaseLockFile() parameters
|
|
# $1 exit value
|
|
# $2 lock filename
|
|
# $3 locked(1) or not(0)
|
|
unlock_exit() {
|
|
releaseLockFile $2 $3
|
|
exit $1
|
|
}
|
|
|