mirror of
https://github.com/apache/cloudstack.git
synced 2025-11-03 04:12:31 +01:00
791f9dfe5f
CLOUDSTACK-9067 - As I developer I want to remove all the unused router-shell scripts from ACSThis PR removes the unused shell scripts that were present in the ACS project. Those script were replaced by the. Some of the scripts are used by the HyperV Resource, which were hardcoded. I took the opportunity to use the Java constants over there as well, so the next one touching the code will know they exist and won't hardcode anything. The following task were applied: * Remove the shell files and the Java constants that were mapping them; * Apply the use of the Java constants to the HyperV Resource class; * Wrap the String.format() method in the StringUtils so we can test the changes in the HyperV Resource class. The last point was added because I do not have a HyperV test environment. Hence, I wanted to make sure the tiny code I changed is covered at least by unit tests. * pr/1084: CLOUDSTACK-9067 - Replaces hardcoded paths with the VRScripts constants. CLOUDSTACK-9067 - Fomatting the code of HypervDirectConnectResource class CLOUDSTACK-9067 - Remove old script file from the project Signed-off-by: Remi Bergsma <github@remi.nl>