Wido den Hollander 6233a77d15 CLOUDSTACK-10294: PEP-8 fixes and enhancements to security_group.py (#2432) ...

- We should return a boolean and not a String 'true' or 'false'. Although this output is never checked by the calling function(s).
- Do not use == False or == None as that is not according to the Python specs.
- Calling just print 'hello' is deprecated and won't work in newer Python versions. We should use the print() function.
- Remove unused and commented function.
- Use logging.warning() instead of logging.warn()
- Use subprocess.check_output() for execution. This is the Python way of executing commands.

Signed-off-by: Wido den Hollander <wido@widodh.nl>

2018-02-15 14:28:27 +01:00

..

installer

CLOUDSTACK-10196: Remove ejb-api 3.0 dependency (#2348)

2017-12-18 23:59:06 +05:30

network

CLOUDSTACK-9993: Securing Agents Communications (#2239)

2017-08-28 12:15:11 +02:00

storage

CLOUDSTACK-10046 checksum validation for any java supported Digests-type (#2246)

2017-10-11 11:49:06 +02:00

util

CLOUDSTACK-10236: Enable dynamic roles for missing props file (#2426)

2018-01-24 13:11:08 +01:00

vm

CLOUDSTACK-10294: PEP-8 fixes and enhancements to security_group.py (#2432)

2018-02-15 14:28:27 +01:00