mirror of
https://github.com/apache/cloudstack.git
synced 2025-10-26 08:42:29 +01:00
2b075ed39e
* VM snapshots of running KVM instance using storage providers plugins for disk snapshots Added new virtual machine snapshot strategy which is using storage providers plugins to take/revert/delete snapshots. You can take VM snapshot without VM memory on KVM instance, using storage providers implementations for disk snapshots. Also revert and delete is added as functionality. Added Thaw/Freeze command for KVM instance. The snapshots will be consistent, because we freeze the VM during the snapshotting. Backup to secondary storage is executed after thaw of the VM and if it is enabled in global settings. * Removed duplicated functionality Set few methods in DefaultVMSnapshotStrategy to protected to reuse them without duplicating the code. Remove code that is actualy not needed * Added requirements in global setting kvm.vmstoragesnapshot.enabled Added more information in kvm.vmstoragesnapshot.enabled global setting, that it needs installation of: - qemu version 1.6+ - qemu-guest-agent installed on guest virtual machine when the option is enabled * Added Apache license header * Removed commented code * If "kvm.vmstoragesnapshot.enabled" is null should be considered as false * removed unused imports, replaced default template Removed unused imports which causing failures and replaced template to CentOS8 * "kvm.vmstoragesnapshot.enabled" set to dynamic * Getting status of freeze/thaw commands not the return code Will chacke the status if freeze/thaw of Guest VM succeded, rather than looking for return code. Code refactoring * removed "CreatingKVM" VMsnapshot state and events related to it * renamed AllocatedKVM to AllocatedVM the states should not be associated to a hypervisor type * loggin the result of "drive-backup" command * Check which VM snapshot strategy could handle the vm snapshots gets the best match of VM snapshot strategy which could handle the vm snapshots on KVM. Other storage plugins could integrate with this functionality to support group snapshots * Added poolId in canHandle for KVM hypervisors Added poolId into canHandle method used to check if all volumes are on the same PowerFlex's storage pool * skip smoke tests if the hypervisor's OS type is CentOS This PR works with functionality included in qemu-kvm-ev which does not come by default on CentOS. The smoke tests will be skipped if the hypervisor OS is CentOS * Added missed import in smoke test * Suggested change to use ` org.apache.commons.lang.StringUtils.isNotBlank` * Fix getting device on Ubuntu On Ubuntu the device isn't provided and we have to get it from node-name parameter. For drive-backup command (for Ubuntu) is needed and job-id which is the value of node-name (this extra param works on Ubuntu and CentOS as well). * Removed new snapshot states and functionality for NFS * throw CloudRuntimeException provide a properer error message when delete VM snapshot fails * exclude GROUP snapshots when listing snapshots * Skip tests if there is pool with NFS/Local * address comments