mirror of
https://github.com/apache/cloudstack.git
synced 2025-10-26 08:42:29 +01:00
1e88ad45a7
CLOUDSTACK-9498: VR CsFile search utility methods fail when search stThere is no real use of python 're' module in CsFile.py utility methods searchString, deleteLine. Regular string search is sufficient. These methods are used only for VPN user add/delete. Since VPN user password can have python 're' module meta characters, it interfere with search functionality. Replacing re.search() with regular string search instead. Change is confined to VPN add/delete users. Have run the test/integration/component/test_vpn_users.py VPN remote access user limit tests ... === TestName: test_01_VPN_user_limit | Status : SUCCESS === ok Test create VPN when L2TP port in use ... === TestName: test_02_use_vpn_port | Status : SUCCESS === ok Test create NAT rule when VPN when L2TP enabled ... === TestName: test_03_enable_vpn_use_port | Status : SUCCESS === ok Test add new users to existing VPN ... === TestName: test_04_add_new_users | Status : SUCCESS === ok Test add duplicate user to existing VPN ... === TestName: test_05_add_duplicate_user | Status : SUCCESS === ok Test as global admin, add a new VPN user to an existing VPN entry ... === TestName: test_06_add_VPN_user_global_admin | Status : SUCCESS === ok Test as domain admin, add a new VPN user to an existing VPN entry ... === TestName: test_07_add_VPN_user_domain_admin | Status : SUCCESS === ok * pr/1680: CLOUDSTACK-9498: VR CsFile search utility methods fail when search string has 're' meta chars, and causing VPN user add/deelte to fail Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>