mirror of
https://github.com/apache/cloudstack.git
synced 2025-10-26 08:42:29 +01:00
09802e0f3c
CLOUDSTACK-9698 [VMware] Make hardcorded wait timeout for NIC adapter hotplug as configurableJira === CLOUDSTACK-9698 [VMware] Make hardcoded wait timeout for NIC adapter hotplug as configurable Description ========= Currently ACS waits for 15 seconds (hard coded) for hot-plugged NIC in VR running on VMware to get detected by guest OS. The time taken to detect hot plugged NIC in guest OS depends on type of VMware NIC adapter like (E1000, VMXNET3, E1000e etc.) and guest OS itself. In uncommon scenarios the NIC detection may take longer time than 15 seconds, in such cases NIC hotplug would be treated as failure which results in VPC tier configuration failure. Alternatively making the wait timeout for NIC adapter hotplug as configurable will be helpful for admins in such scenarios. This is specific to VR running over VMware hypervisor. Also in future if VMware introduces new NIC adapter types which may take time to get detected by guest OS, it is good to have flexibility of configuring the wait timeout as fallback mechanism in such scenarios. Fix === Introduce new configuration parameter (via ConfigKey) "vmware.nic.hotplug.wait.timeout" which is "Wait timeout (milli seconds) for hot plugged NIC of VM to be detected by guest OS." as fallback instead of hard coded timeout, to ensure flexibility for admins given the listed scenarios above. Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapuneedi@accelerite.com> * pr/1861: CLOUDSTACK-9698 Make the wait timeout for NIC adapter hotplug as configurable Signed-off-by: Rajani Karuturi <rajani.karuturi@accelerite.com>