apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity
1,742 Commits 304 Branches 324 Tags
Commit Graph

652 Commits

Author SHA1 Message Date
kishan
ad3c18a46c bug 6789: release router lock after commiting transaction 
status 6789: resolved fixed
 2010-10-29 16:22:19 +05:30
Kris McQueen
ebac4539d0 it's possible createSnapshotDB will return null, handle that case. However, if createSnapshotDB returns null because there was no work to do (empty snapshot) we should probably throw an exception that reports that fact instead of returning null and throwing an internal error 2010-10-28 17:52:37 -07:00
Kris McQueen
642b8a56f4 If the create command returns null for whatever reason, throw an exception so it aborts scheduling the async job to act on the created object 2010-10-28 17:52:37 -07:00
Kris McQueen
640a3dc239 bug 6818: if the userAccount is null, the user is either removed or does not exist. Since we can't log them out in those cases, just skip saving the logout event (and hence avoid the NPE). 
status 6818: resolved fixed
 2010-10-28 17:52:37 -07:00
Kris McQueen
2f9e91a9ae bug 6738: honor groupid when listing vms (restrict the list to just that group) 
status 6738: resolved fixed
 2010-10-28 16:27:07 -07:00
Kris McQueen
50a72d7f71 bug 6740: update the group for a VM if a group name is given 
status 6740: resolved fixed
 2010-10-28 16:27:07 -07:00
Kris McQueen
6435991086 bug 6782: somehow in my testing I missed this exception when creating the event for USER_DELETE. The change is to get the userAccount by 'idIncludingRemoved' just like getting the account. The proper userAccount object is returned and the event is successfully created. 
status 6782: resolved fixed
 2010-10-28 14:32:13 -07:00
Kris McQueen
7531525252 Add commented code out for the old style (2.1.x) JSON async job responses. The XML responses are still a TODO. In order to get this to fully revert back to 2.1.x style responses, some commands will need to be modified to set the responseName to be something like getResultObjectName(), and there's an example of this in StopVMCmd. 2010-10-28 14:32:13 -07:00
Kris McQueen
9eb851db60 bug 6809, 6712: standardize the domain router response to use guestmacaddress instead of macaddress 
status 6809, 6712: resolved fixed
 2010-10-28 14:32:13 -07:00
will
c5fef26f11 ListTemplates will no longer return any SystemVM templates. I am using a startsWith() string match for now since we used to make this comparision by ID with a single hypervisor. 2010-10-28 13:28:33 -07:00
nit
c9069303ce Code clean up for Extract functionality and making it more robust. 2010-10-28 18:45:12 +05:30
will
f0a4449ec3 ListTemplates now return the hypervisor type. 2010-10-27 19:50:36 -07:00
Kris McQueen
50c175d6c1 bug 6799: forgot to add the exception response in my commit for this bug... 2010-10-27 18:23:23 -07:00
Kris McQueen
484f334d7a bug 6799: if there's an exception executing the Async command, create an error response with the appropriate information so that queryAsyncJobResult returns the relevant information 
status 6799: resolved fixed
 2010-10-27 18:23:23 -07:00
Kris McQueen
901f52eb99 bug 6782: incremental checkin for deleting an account. Since there was a change to findById to not find removed objects, these NPEs pop up from time to time where we expected to find the object previously and now it's not found. Since the account is getting deleted, do a findByIdIncludingRemoved to make sure the actual account object is retrieved. 2010-10-27 18:23:23 -07:00
Kris McQueen
9056653e17 Change the API Implementation annotation to use the manager's class rather than an enum. This allows methods for new managers to be added trivially rather than having to modify the dispatcher to load a new manager class. 2010-10-27 12:23:31 -07:00
edison
a29b897b7f bug 1974: set memory size from service offering before starting router 
status 1974: resolved fixed
 2010-10-27 12:00:11 -07:00
Kris McQueen
ae9b6d4fe1 bug 6776: for some reason, we checked for zoneId = -1 in registerTemplate and applied it to all zones, but this wasn't done for registerIso. Oh well, make the change for registerIso and things seem happy again 
status 6776: resolved fixed
 2010-10-26 17:55:00 -07:00
Kris McQueen
c9d9a18ace bug 6746: use loadbalancer name rather than the command's name for updating the load balancer; use the load balancer's account id rather than the load balancer id when searching for the load balancer owner 
status 6746: resolved fixed
 2010-10-26 17:40:29 -07:00
Alex Huang
4f9f249218 make console proxy work again with the new network configuration 2010-10-26 17:37:29 -07:00
Kris McQueen
e63d17dd41 bug 6739: stopSystemVm needs to return the appropriate VM instance type. The manager methods were returing VMInstanceVO, which is not sufficient for getting, for example, active viewer sessions from the console proxy object. Make sure the right VO object is returned, and all the data should be available for the API to generate a full response. 
status 6739: resolved fixed
 2010-10-26 17:33:53 -07:00
Kris McQueen
a788d2cb2e bug 6736: rebootSystemVm should return the vm properties, not success true/false. 
status 6736: resolved fixed
 2010-10-26 17:19:55 -07:00
Kris McQueen
95da86ef1a bug 6733: re-throw ServerApiExceptions when dispatching API commands rather than logging them and throwing a generic INTERNAL_ERROR exception 
status 6733: resolved fixed
 2010-10-26 16:54:42 -07:00
Kris McQueen
28bcbc3bdd bug 6732: there is no longer a manual policy, so add in special handling for deleting manual snapshots. Also, in the process of deleting the snapshot, the snapshot might need to be retrieved from the database, so be sure to find including removed. 
status 6732: resolved fixed
 2010-10-26 16:47:21 -07:00
Kris McQueen
8fafc892d3 bug 6730: if a volume was never attached to a VM, then the poolId will be null and this will be flagged as not on shared storage. Since the code was deleting detached volumes only on shared storage, the never-attached volume was in an undeletable state. Instead, allow deletion of any detached volume, regardless of storage pool until some technical reason limits this from happening. 
Also, the UI was not allowing volumes to be deleted due to a bug in looking at the vmname property of the volume.  The 'if' conditional always returned true that the volume was attached to a VM to due a boolean logic error.

status 6730: resolved fixed
 2010-10-26 14:56:44 -07:00
abhishek
a698c0327d adding more logging around successful cert upload 2010-10-26 14:27:26 -07:00
abhishek
c6588c0e25 adding some error return handling to api dispatcher, and cleaning up some of the code paths to return the right error messages 2010-10-26 14:27:26 -07:00
root
42f1ff92a9 resolved merge conflicts after git pull --rebase 2010-10-26 14:27:26 -07:00
abhishek
f64abad8f5 completed the listener logic. Based on the startup command, we will try and update a cust cert to a new running cpvm, and fail if such a cert doesn't exist in the cert table in our db. 2010-10-26 14:27:26 -07:00
abhishek
cb4a80b8ac starting off with the listener logic.This will ensure that every new console proxy vm that starts, will potentially look for any custom certs uploaded to our db. If they exist, we will send a command to the agent, so that the cert is uploaded, and the ssl context is re-initialized. 2010-10-26 14:27:26 -07:00
abhishek
822ee2d899 more changes for the console proxy custom certificate part; some code cleanup as well as event generation with console proxy reboot logic 2010-10-26 14:27:26 -07:00
alena
afd79a9b1b Code cleanup 2010-10-26 13:59:11 -07:00
anthony
1b014ec340 master oss management server can start now 2010-10-26 13:47:43 -07:00
Alex Huang
2bc938c3f8 checkins for problems. 2010-10-26 09:35:24 -07:00
Alex Huang
29a5b796d4 deploy vm completed...now for testing 2010-10-26 09:35:24 -07:00
Alex Huang
f58063911e deploy vm completed 2010-10-26 09:35:24 -07:00
nit
7f15b8ff57 Adding the accidental deleted code 2010-10-26 19:05:13 +05:30
nit
497c60d63d Extending extract functionlity for volumes to allow download. The 
extraction can have two modes FTP_UPLOAD and HTTP_DOWNLOAD. In the former one
the user would provide the ftp url where the entity needs to be uploaded and in
the later the user would be provided a HTTP URL where from he/she can download
the entity. This url would be exposed for a specific time limit and would not
function after the time limit
 2010-10-26 18:49:43 +05:30
Kris McQueen
b3c7821b44 bug 6752: fix updating resource limits for a domain by looking at the given accountName/domainId parameters rather than looking at the caller's account. If updating limits for an account, e.g. account 'foo' in domain 4, then execute updateResourceLimit&account=foo&domainid=4&..., but if updating the limit for a domain, don't specify the account parameter. When processing the command, if accountName is null, the limit for the domain will be properly updated. 
status 6752: resolved fixed
 2010-10-25 17:32:28 -07:00
Kris McQueen
ef131bbc18 bug 6724: set useVirtualNetwork in the createServiceResponse 
status 6724: resolved fixed
 2010-10-25 17:08:47 -07:00
Kris McQueen
f9c1f12778 bug 6725: use serviceOfferingName rather than the API command name when updating the service offering; set memory in the response for UpdateServiceOffering 
status 6725: resolved fixed
 2010-10-25 17:08:47 -07:00
Kris McQueen
27cafb2957 bug 6727: ostypename was being set from guest_os.name which seems to be null most of the time. Instead, use guest_os.display_name. 
status 6727: resolved fixed
 2010-10-25 17:08:47 -07:00
Kris McQueen
fcb0ff83ac bug 6712: for router responses, change guestmacaddress -> macaddress to preserve behavior from 2.1.x and before. 
status 6712: resolved fixed
 2010-10-25 16:37:42 -07:00
Kris McQueen
869f3587c3 bug 6714: add displaytext to SuccessResponse so commands that return success true/false can also return a brief description of what took place. 
status 6714: resolved fixed
 2010-10-25 16:37:42 -07:00
Kris McQueen
3660d6a3d1 bug 6717: updateDiskOffering is supposed to return success true/false rather than the updated disk offering 
status 6717: resolved fixed
 2010-10-25 16:37:42 -07:00
Kris McQueen
c8e9531842 bug 6720: add 'created' to the ListHosts response 
status 6720: resolved fixed
 2010-10-25 16:37:42 -07:00
Kris McQueen
83e4922b94 bug 6703, 6704: use the correct method signatures for invoking updateTemplate/updateIso and updateTemplatePermissions/updateIsoPermissions APIs. It's possible that the reflection should just use 'isAssignableFrom' when getting methods since the manager methods were using a base class as the parameter rather than UpdateTemplateCmd/UpdateIsoCmd and UpdateTemplatePermissions/UpdateIsoPermissions, but for now the explicit methods are added for simplicity. 
status 6703, 6704: resolved fixed
 2010-10-25 15:01:50 -07:00
Kris McQueen
d229877cd8 bug 6710: rebootRouter was supposed to return the rebooted router, not success/failure 
status 6710: resolved fixed
 2010-10-25 15:01:50 -07:00
Kris McQueen
18f6d67121 bug 6705, 6708: use the UserVmResponse for changeServiceForVirtualMachine API (UpgradeVMCmd) since the response is a vm. There was no need for a specific UpgradeVmResponse which had scalars instead of objects and the serializer skips null, but will serialize scalars with their default values, in this case 0 for id and host id. 
status 6750, 6708: resolved fixed
 2010-10-25 15:01:49 -07:00
abhishek
aebf02b707 removing some debug params 2010-10-25 11:52:08 -07:00