apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-11-02 20:02:29 +01:00
Code Issues Packages Projects Releases Wiki Activity
23,005 Commits 307 Branches 324 Tags
Commit Graph

1789 Commits

Author SHA1 Message Date
Sheng Yang
6bde675f87 Remove SetupGuestNetworkAnswer 
It's unnecessary and not different from Answer itself.
 2014-02-14 18:10:05 -08:00
Sheng Yang
161e7d93ca CLOUDSTACK-5779: Fix missing clean up period for VR 2014-02-14 18:10:00 -08:00
Hugo Trippaers
97bad4f9b3 Fix checkstyle and license issues 2014-02-14 18:37:47 +01:00
wrodrigues
3199de69fe Fixes on Contrail and Mon InMemory plugins; adding comments about the changes. 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:47 +01:00
Miguel Ferreira
8649fa005a Fix findbugs findings in cloud-plugin-network-elb 
Findings:
    - comparing Longs by reference
    - possible null pointer dereference

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:46 +01:00
Hugo Trippaers
ef2ced7564 Fix findbugs findings in cloud-plugin-network-ovs 
OvsTunnelManagerImpl.java:456, RC_REF_COMPARISON, Priority: High

Serveral low priority fixes
 2014-02-14 18:37:46 +01:00
Hugo Trippaers
9b841af529 Findbugs : A map can't retrieve an object by index, so get(0) would 
return null. Changed to retrieve the first entry in the map.

Removed the ExecutionException try catch, this would prevent the
unittest from giving accurate information on exceptions. Avoid catching
checked exceptions in a unittest, use expected keyword on @Test instead.
 2014-02-14 18:37:45 +01:00
Hugo Trippaers
d4d49578dc Findbugs : Fix a number of potential NPEs and minor findings 2014-02-14 18:37:45 +01:00
Alex Hitchins
e0a4b7c891 Findbugs - Long equality fix. 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:45 +01:00
wrodrigues
0ff943337c fixing FindBugs scariest for replaceFirst() method call that does not assign the return value 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:44 +01:00
Sander Botman
16aa73c2c8 Fixing some of the scary bugs possible null pointer: created testSetNicDevIdIfCorrectVifIsNotNull 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:44 +01:00
Likitha Shetty
db91e54bf3 CLOUDSTACK-6112. Adding VPC router to a guest network fails with StringIndexOutOfBoundsException. 2014-02-14 17:01:27 +05:30
Marcus Sorensen
df77c4310a CLOUDSTACK-6103: Pass VM iso information along with 
PrepareForMigrationCommand, so that destination hypervisor can
mount pool. This further exposed an issue for KVM where iso
was not getting cleaned up upon successful migration, fixed as well.
 2014-02-14 00:34:48 -07:00
Marcus Sorensen
7064972997 Fix someone's broken push due to bad checkstyle (VMwareGuru.java unused imports) 2014-02-12 16:26:33 -07:00
Likitha Shetty
9f597ef130 CLOUDSTACK-6056. Enabling static NAT rule for a portable public IP fails with error "Failed to enable static nat". 
router.extra.public.nics isn't being honoured and so when an ip that is acquired from the additional VLAN range
is being configured it failed.
 2014-02-12 15:53:45 +05:30
Anshul Gangwar
b86d45b003 CLOUDSTACK-6054: Changes for making vmsync work for hyper-v. Made changes to PingCommand and 
StartupCommand to return the state of all vms on the host.
 2014-02-11 12:19:41 +05:30
Darren Shepherd
c1cfaa2d1c Contrail Event Interceptor fix 
When project/domains are created,  our plugin code won't get invoked. Our
contrail plugin uses Event infrastructure provided by cloudstack to
receive these events and handle them accordingly. It is must to create
domains/projects before creating a virtual network/vm object in contrail
implementation. Hence our plugin must need a way to get notified about
project/domain events.
 2014-02-10 22:43:38 -07:00
Laszlo Hornyak
bdf50f6d24 Remove assertion 
The assertion is built on the assumption that cpuinfo_max_freq is readable by user, which may not be universaly true.
 2014-02-10 19:56:54 +01:00
Laszlo Hornyak
ab15653d68 Revert "Temporarily ignore getCpuSpeed test" 
This reverts commit e4a91d3610fc8d7ce7718817fbc88318c5fe1e88.
 2014-02-10 19:40:37 +01:00
Laszlo Hornyak
e4a91d3610 Temporarily ignore getCpuSpeed test 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 23:13:55 +01:00
Laszlo Hornyak
55b6b6d50b Boolean expression simplification 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 19:19:20 +01:00
Laszlo Hornyak
d6a6e8dfa5 Minor Boolean expression simplification 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 19:05:28 +01:00
Laszlo Hornyak
74a3cb4d5e String concatenation cleanup 
Replaced string concatenation in loop with StringBuilder

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 19:01:45 +01:00
Laszlo Hornyak
8e3ae40ba2 removed self-assignment 
It must have been a copy-paste from the other constructor.

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 18:46:36 +01:00
Laszlo Hornyak
d22b65f45f replaced Integer reference comparsion with .equals 
By default only the Integers between -128..127 are cached (unless overridden by java.lang.Integer.IntegerCache.high system property)
If the inbound or outbound values are higher, the reference comparison won't work.

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 18:39:03 +01:00
Laszlo Hornyak
3e3ded75f4 safely close resource with java 1.7 resource block 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 18:27:54 +01:00
Laszlo Hornyak
5e4fec9eca removed unused variables 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 16:55:27 +01:00
Laszlo Hornyak
e52a276104 cleanup in LibvirtComputingResource 
- minor resource leak cleaned up
- cpu-speed reading method extracted
- test added
- logging added in case of exception

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 16:50:10 +01:00
Min Chen
3b58a45e04 Merge branch 'master' into rbac. 2014-02-07 13:43:36 -08:00
Hugo Trippaers
64c61c7202 Fix two NPE exceptions in the Contrail Plugin when contrail is not providing any services on the network. 2014-02-06 16:51:20 +01:00
Wido den Hollander
1baebebda6 test: Expand LibvirtDomainXMLParserTest with Interface test 2014-02-06 14:40:40 +01:00
Wido den Hollander
41c7e22eee test: Add test for LibvirtDomainXMLParser 
A couple of changes where made to other classes as well to add
some features to allow more extensive testing.
 2014-02-06 14:23:25 +01:00
Rajesh Battala
7f780f26f9 Fixed agent code to handle untagged public vlan while parsing the vlan id 2014-02-05 23:44:14 +05:30
Syed Ahmed
356daf3eed Review 16080 Move Netscaler plugin from non-oss to oss and upgrade the nitro API to 10.1 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-05 14:03:49 +01:00
Devdeep Singh
a24263fe81 CLOUDSTACK-6030: Encrypt the primary and secondary smb storage password when it is stored in the db. 2014-02-05 15:44:09 +05:30
Hiroaki KAWAI
0d222b14a1 stratosphere-ssp plugin: Fix HttpClient4 connection leak 
Replaced HttpClient#execute(HttpUriRequest) with
HttpClient#execute(HttpUriRequest,ResponseHandler<T>).
The former requires extra EntityUtils#consume(HttpEntity).
 2014-02-05 16:23:32 +09:00
Alex Huang
7f34282dfa Removed references to secondarystoragevmmanager from code that doesn't use it. 2014-02-05 01:39:15 +00:00
Min Chen
929099518d Fix trailing whitespace. 2014-02-04 15:42:39 -08:00
Min Chen
39efee285f CLOUDSTACK-6027:CreateVolume from snapshot is failing with S3 on Vmware. 2014-02-04 15:08:28 -08:00
sbalineni
cc8bde2421 Do not initialize contrail plugin component functionality like db sync, network offerring creation when contrail is not installed 2014-02-04 12:35:29 -08:00
Prachi Damle
f84375442e Merge branch 'master' into rbac 
Conflicts:
	api/src/org/apache/cloudstack/api/command/user/autoscale/ListAutoScaleVmProfilesCmd.java
	api/src/org/apache/cloudstack/api/command/user/volume/ResizeVolumeCmd.java
	plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
	server/src/com/cloud/api/ApiServer.java
	server/src/com/cloud/api/query/QueryManagerImpl.java
	server/src/com/cloud/template/TemplateAdapterBase.java
	setup/db/db/schema-430to440.sql
	tools/apidoc/gen_toc.py
 2014-02-04 12:07:32 -08:00
Min Chen
9b21da65d1 CLOUDSTACK-6025:CreateTemplate from snapshot in NFS is failing , after 
migarting to S3 datastore.
 2014-02-04 11:01:51 -08:00
Daan Hoogland
0839fbce67 CLOUDSTACK-6023 vcpus should not be higher then xen specifies 2014-02-04 18:41:53 +01:00
Wido den Hollander
3989d6c481 kvm: Resize volumes using libvirt 
This saves us a lot of code and libvirt is probably a better
place to do this.

libvirt-java now has the support we want, so we can now resize volumes
with libvirt.

(C)LVM volumes can't be resized using libvirt, so we have to
invoke a resize script for that.
 2014-02-04 14:26:51 +01:00
Min Chen
30695d7f93 CLOUDSTACK-6019:CreateVolume from snapshot in NFS is throwing Warning 
"sync snapshot from cache to region wide store failed for image store
test".
 2014-02-03 16:41:04 -08:00
Wido den Hollander
5ae12f31b7 rbd: Set client timeout to 30 seconds. 
By default the client_mount_timeout setting in librados is 300 seconds,
but that causes the connect to the Ceph cluster to block for 5 minutes
if the Ceph cluster is not available.

This patch is not ideal, but it mitigates the problem for now.

At a later point all this librados/librbd code should go back to libvirt
again, but the current versions of libvirt in the distributions are
to old for all the features we require.

For now this should prevent the CloudStack agent blocking for 5 minutes
when the Ceph cluster isn't available.

This is also tracked at the Ceph tracker: http://tracker.ceph.com/issues/6507
 2014-02-03 16:07:00 +01:00
Hiroaki KAWAI
836a9caa72 add charset arg to InputStreamReader constructor 
thanks to findbugs.
 2014-01-31 12:57:13 +09:00
sbalineni
ed3e1b95b0 VPC Support for contrail networking 
Signed-off-by: Sheng Yang <sheng.yang@citrix.com>
 2014-01-30 18:13:48 -08:00
Likitha Shetty
06f79a881c CLOUDSTACK-5994. Hitting IndexOutOfBoundsException in GetVmStatsCommand after upgrade. 
To obtain network read/write statistics, multiply sample duration with the
average of the particular performance metric obtained over the sample period.
 2014-01-30 18:31:38 +05:30
Hiroaki KAWAI
cb048f4108 Some rework stratosphere ssp plugin 
* add missing command entry in commands.properties
* migrate httpclient 3.x to 4.x
* fix the broken SspClient
* add webapp session checking in mock ssp server
 2014-01-30 21:31:44 +09:00