Daan Hoogland
03b076cd1b
coverity 1116668: conditionally close ds provided connection
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
This closes #599
2015-07-17 13:22:43 +02:00
Daan Hoogland
a1ff7e24f3
coverity 1311707: only sql exception on select would have been caught. passing all runtime exceptions through
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #584
2015-07-14 13:41:09 +02:00
Daan Hoogland
b0136c56e7
coverity 1116564: complicated update of sequences fixed
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
This closes #564
2015-07-09 21:30:24 +02:00
wilderrodrigues
5557ad5588
Offer a getDurationInMillis() method in the Profiler utility class
...
- New implementation uses nanoseconds. Due to that, the places where the Profiler is used as a Monitor and/or
a stopwatch will suffer with the difference in the return
- Also added a getDuration(), which returns the time in nanoseconds in case someone wants to use it instead
- Added an extra test to check if the getDuration() works fine with nanoseconds
- Fixed the test that checks the time in milliseconds: I added an error margin to cover the test better
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-06-24 09:36:40 +02:00
Rohit Yadav
069aa4e5f3
CLOUDSTACK-8433: remove awsapi db usage and add upgrade cleanup path
...
- Removes awsapi db properties usage across codebase
- Removes references from spring xmls, test cases and TransactionLegacy
- Adds sql command to drop database cloudbridge in schema-451to460-cleanup.sql
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-06 15:22:04 +02:00
Laszlo Hornyak
3577423da9
removed executable flags from java classes
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-11-23 19:49:01 +01:00
Min Chen
ffaabdc13f
CLOUDSTACK-7832: Move some job db update and item purge to
...
completeAsyncJob transaction to avoid MySQL deadlock.
2014-11-03 10:41:36 -08:00
Santhosh Edukulla
31a42d2b7a
Fixed few coverity patches
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-10-09 11:45:26 +05:30
Anthony Xu
f5eae55abb
timeInSeconds * 1000
...
timeInSeconds is int type, if timeInSeconds is very big, it makes "timeInseconds * 1000" very small even 0
2014-09-24 10:57:36 -07:00
Anthony Xu
c74dada854
add logs for lock acquire and release
2014-09-24 10:28:04 -07:00
Hugo Trippaers
2503aaafef
Revert "removed unused class"
...
This reverts commit 093fa6f0a53bd031a09e4042c3aa25860bc947e5.
2014-09-24 08:41:55 +02:00
Anthony Xu
d8ad3e32bc
throw timeout exception when lock acquire times out
2014-09-23 18:01:32 -07:00
Anthony Xu
093fa6f0a5
removed unused class
...
ramework/db/src/com/cloud/utils/db/TransactionContextInterceptor.java
2014-09-23 16:48:14 -07:00
Koushik Das
61fe959bb4
Removed invalid assertions from code. Now the MS can be run with assertions enabled (using -ea flag)
2014-07-10 12:18:29 +05:30
Santhosh Edukulla
a600d8408e
Fixed Resource Leaks, null dereferences, few other issues reported by coverity
2014-07-04 16:17:58 +05:30
Santhosh Edukulla
b2283d7a28
Fixed few resource leaks and added secstoragefirewallcfg command support to simulator
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-06-24 23:19:47 +02:00
Santhosh Edukulla
1c80185170
Fixed Resource Leaks, null dereferences, invalid value comparisons, invalid result set loop
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-06-21 12:38:46 +02:00
Hugo Trippaers
0c28f36ff1
Fix a number of resource leaks reported by Coverity
2014-06-13 14:42:35 +02:00
Min Chen
ba848087f8
Disable IAM feature from 4.4 release.
2014-05-22 18:27:08 -07:00
Laszlo Hornyak
54c83c168f
removed redundant Integer instantiation in GenericDaoBase
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-28 18:40:25 +01:00
Min Chen
48e08fe676
Merge branch 'master' into rbac.
2014-03-06 14:02:20 -08:00
Hugo Trippaers
a0f932437c
Move mysql ha strategy to a plugin. Activate this plugin using the mysqlha profile or the noredist flag
2014-02-27 09:51:02 +01:00
Hugo Trippaers
19b15a1bdc
Fix parameter index in getCount function.
2014-02-20 15:13:29 +01:00
Hugo Trippaers
443acac927
Fix functional issue introduced by some findbug changes.
2014-02-14 18:37:47 +01:00
Antonio Fornie
cbea6d26e8
Fix and test GroupBy SQL query creation
...
Signed-off-by: Ian Southam <isoutham@schubergphilis.com>
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
Ian Southam
5a6ad11fa2
findbugs findings
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
Alena Prokharchyk
e0de79b170
Resource metadata: by default, all metadata is set with display=true (meaning that the detail is avaialble for display to the regular user). If admin wants to set a specific detail to be false, he has to specify it explicitly in addResourceDetail command
2014-02-10 12:05:59 -08:00
Prachi Damle
f84375442e
Merge branch 'master' into rbac
...
Conflicts:
api/src/org/apache/cloudstack/api/command/user/autoscale/ListAutoScaleVmProfilesCmd.java
api/src/org/apache/cloudstack/api/command/user/volume/ResizeVolumeCmd.java
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
server/src/com/cloud/api/ApiServer.java
server/src/com/cloud/api/query/QueryManagerImpl.java
server/src/com/cloud/template/TemplateAdapterBase.java
setup/db/db/schema-430to440.sql
tools/apidoc/gen_toc.py
2014-02-04 12:07:32 -08:00
Laszlo Hornyak
e4da3775c9
removed redundant Long, Short, Double, Float and Boolean instantiations
...
- Added unit tests
- Added javadoc
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-01-25 20:09:45 +01:00
Min Chen
929fbabaa2
Merge branch 'master' into rbac.
2014-01-17 14:37:08 -08:00
Min Chen
bae498c89e
Handle search of those entities without db view created using new ACL
...
model.
2014-01-13 21:55:56 -08:00
Antonio Fornie
55a6df4501
Resources leaks, refactoring and testing
...
Removing resource leaks from UsageSanityChecker and
refactoring it (encapsulation, removal of copy and paste, constants...)
Modularize static method for closing Statments in TransactionLegacy
and reusing this new method from other classes (Upgrade2214to30)
Create Unit and Integration Tests for UsageSanityChecker
Add DBUnit cases and integration profile for nitegration tests as
a base for future DB tests
2013-12-18 10:55:04 +01:00
Alex Huang
be5e5cc641
All Checkstyle problems corrected
2013-12-12 12:26:07 -08:00
Alex Huang
d620df2bdd
Reformatted all of the code.
2013-11-21 06:15:26 -08:00
Alex Huang
eaa250fd3c
Formatted again after all the tab expansions and eol removals
2013-11-21 04:47:01 -08:00
Alex Huang
224f479974
Removed trailing spaces
2013-11-21 04:08:01 -08:00
Alex Huang
e4b22d0fca
Replace all tabs, particularly the ones in the comments
2013-11-21 03:39:58 -08:00
Alex Huang
8d62744681
Reformat all source code. Added checkstyle to check the source code
2013-11-20 07:26:53 -08:00
Laszlo Hornyak
065e5afa08
Tests for DBUtil
...
This patch adds test for the lock management:
- getGlobalLock
- releaseGlobalLock
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2013-11-16 15:44:31 +01:00
Damodar Reddy
67fc2f53e2
CLOUDSTACK-4916: Fixing the issue with DB HA when there are more than 2 db nodes (Issue was mysql DriverManager was returning salve db nodes on random basis which was causing issue)
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-11-14 11:10:48 +05:30
Damodar Reddy
dcd3c44279
CLOUDSTACK-4916: To Enable Master High Availability using mysql connector params and mysql's 2 way replication
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-11-08 16:18:14 +05:30
Min Chen
dc3d279272
CLOUDSTACK-4833:[Automation][BVT] Template and ISO test cases failing
...
from BVT suite, during LIST api call.
2013-11-07 15:19:19 -08:00
Alena Prokharchyk
78b1ac4126
CLOUDSTACK-3868: fixed "count" param in listUsageRecords API to return the actual number of records matching the search criteria. Used to return the wrong value - the number of records per page
...
Conflicts:
server/src/com/cloud/usage/UsageServiceImpl.java
utils/src/com/cloud/utils/db/GenericDaoBase.java
2013-10-31 15:25:57 -07:00
Darren Shepherd
afaf6370dd
Fix change that broke db.properties.override
2013-10-31 09:21:34 -07:00
Darren Shepherd
1460196496
Centralize loading of db.properties to one place
...
There is now a method DbProperites.getDbProperties() that will load the
db.properties in one place and do the proper decryption of values if needed
2013-10-30 17:03:13 -07:00
Laszlo Hornyak
dbaa818d1e
InputStream use fix
...
Closes the FileInputStream opened at configuration in
- ClusterManagerImpl
- ClusterServiceServletAdapter
- TransactionLegacy
- AsyncJobManagerImpl
- DBEncryptionUtil
- EncryptionSecretKeyChecker
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2013-10-26 17:47:34 +02:00
Darren Shepherd
891b85d516
Add missing licenses
2013-10-23 15:20:08 -07:00
Darren Shepherd
76c22eae5b
Update to use new Transaction API
2013-10-23 11:23:18 -07:00
Darren Shepherd
e3280bdba2
Merge remote-tracking branch 'origin/spring-modularization'
...
Conflicts:
client/tomcatconf/applicationContext.xml.in
client/tomcatconf/nonossComponentContext.xml.in
client/tomcatconf/simulatorComponentContext.xml.in
framework/db/src/com/cloud/utils/db/Transaction.java
plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockAgentManagerImpl.java
server/src/com/cloud/api/ApiServer.java
server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
2013-10-23 11:14:42 -07:00
Darren Shepherd
edeaf98117
Cleaner and more type safe Transaction API for checked exceptions
2013-10-23 10:02:43 -07:00