apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-11-02 11:52:28 +01:00
Code Issues Packages Projects Releases Wiki Activity
31,495 Commits 307 Branches 324 Tags
Commit Graph

706 Commits

Author SHA1 Message Date
Daan Hoogland
85e002b230 CLOUDSTACK-8656: filling empty catch block with info messages 
using regexp "catch\s*\(\s*(Exception|Throwable)\s*\w*\)\s*\{\s*\}"
 2015-07-30 15:51:52 +02:00
Likitha Shetty
f5ed824ea2 CLOUDSTACK-8598. CS reports volume migration as successful but the volume is not migrated in vCenter.. For the following disk operations - migration, snapshot creation, resize, detach and template creation, CS should do an exact disk match between volume path and vCenter disk name. If the exact matching fails to find a disk, CS should fall back to the old method of partial matching on a trimmed disk. 
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #543
 2015-07-16 10:44:58 +02:00
Likitha Shetty
9463356ca6 CLOUDSTACK-8600. Upon detaching a disk, delete VM folder if empty. 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #545
 2015-07-01 14:53:23 +02:00
Likitha Shetty
299c07c3e1 CLOUDSTACK-8597. Failed to migrate volume from zone-wide to cluster-wide storage. While live migrating a volume, CS chooses the endpoint to perform the migration by selecting any host that has the storage containing the volume mounted on it. Instead, if the volume is attached to a running VM, the endpoint chosen by CS should be the host that contains the VM. 
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #541
 2015-07-01 12:33:26 +02:00
Likitha Shetty
13a98dd196 CLOUDSTACK-8601. VMFS storage added as local storage can be re-added as shared storage. 
Fail addition of a VMFS shared storage pool in case it has already been added as local storage in CS.
 2015-07-01 10:47:36 +05:30
Daan Hoogland
9eff27a080 findbugs: static member should be final 
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #495
 2015-06-20 00:57:59 +02:00
Daan Hoogland
871ba9c521 findbugs: ignored return value should have been returned down stack 
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #494
 2015-06-20 00:57:01 +02:00
Daan Hoogland
0952580096 findbugs: try-with-resource to circumvent not handling an exception on 
close
 2015-06-17 12:41:04 +02:00
Daan Hoogland
6da6c5f762 findbugs: log unhandled exception as warning 2015-06-17 12:35:39 +02:00
Daan Hoogland
41c1fddaee findbugs: better message and fallback to defaultCharset 2015-06-16 11:57:15 +02:00
Rafael da Fonseca
0851e4e54b Catch encoding exception 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #464
 2015-06-16 11:24:51 +02:00
Rafael da Fonseca
9f2ebdf443 Fix findbugs encoding issue in VmwareStorageProcessor.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #460
 2015-06-16 08:56:33 +02:00
Rafael da Fonseca
9bb920af65 Fix findbugs warning in VmwareStorageManagerImpl.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #461
 2015-06-16 08:53:56 +02:00
Rafael da Fonseca
3d48af41a8 Fix findbugs encoding issue in VmwareResource.java Key file should be UTF-8 encoded in VR 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #462
 2015-06-16 08:51:54 +02:00
Rafael da Fonseca
85ad1b7e0f Fix 3 findbugs encoding warnings in VmwareStorageProcessor.java Ova templates and metadata should be written to file in UTF-8 Fix warning in UUID generation 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #411
 2015-06-15 12:09:13 +03:00
Rafael da Fonseca
967da97f51 Fix 2 findbugs warnings in VmwareStorageManagerImpl.java Template files and metadata should be written to file in UTF-8 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #410
 2015-06-15 12:06:19 +03:00
Rafael da Fonseca
11fec86ba3 Fix 1 findbugs warning in VmwareResource.java 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #409
 2015-06-15 12:06:11 +03:00
Rafael da Fonseca
474065e98b Fix findbugs encoding warning in VmwareServerDiscoverer.java Input string should only contain safe characters, since it's derived from a Long object. This just gets rid of the findbugs warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #408
 2015-06-15 12:06:01 +03:00
Sateesh Chodapuneedi
5e41a830a5 This closes #373 
CLOUDSTACK-3317 - DVS does not support management\storage network

Added support for Management and Storage Network traffic over VMware DVS in CloudStack deployments. Also added support for storage VLAN over dvPortGroup.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>

CLOUDSTACK-3317 - DVS does not support management\storage network

Use non-zero dvport count while updating dvportgroups of system traffic.
Updated configuration compare logic to avoid update dvportgroup operation unless required.
This would help improve speed in vm/network deployment as the update calls would reduce. Also improved logging.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>

Adding unit tests in class HypervisorHostHelperTest

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>

Added license header to new file being added to repo/branch.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
 2015-06-10 02:07:40 +05:30
Daan Hoogland
b272d7717e Revert "Fix 2 findbugs high priority warnings" 
This reverts commit 1ca74dac269faa890c830ccde67c5007ef2e3c45.
 2015-06-08 10:01:19 +02:00
Rafael da Fonseca
e8c7069f73 Fix findbugs high priority warning VmwareStorageManagerImpl.java:1023, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE, Priority: High Redundant nullcheck of datastoreVolumePath, which is known to be non-null in com.cloud.hypervisor.vmware.manager.VmwareStorageManagerImpl.getVolumePathInDatastore(DatastoreMO, String) 
Assertion is not used in runtime, correct way is throw and handle exception without killing app

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #362
 2015-06-08 09:40:50 +02:00
Rafael da Fonseca
38c269d71e Fix performance issue reported by findbugs (unnescessary boxing/unboxing) VmwareResource.java:693, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High VmwareResource.java:4769, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.hypervisor.vmware.resource.VmwareResource.getNetworkStats(String) 
Now op is faster and takes up less memory

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #365
 2015-06-08 09:32:52 +02:00
Rafael da Fonseca
1ca74dac26 Fix 2 findbugs high priority warnings 
VmwareResource.java:315, MS_SHOULD_BE_FINAL, Priority: High
com.cloud.hypervisor.vmware.resource.VmwareResource.s_serviceContext isn't final but should be

VmwareResource.java:331, MS_SHOULD_BE_FINAL, Priority: High
com.cloud.hypervisor.vmware.resource.VmwareResource.s_powerStatesTable isn't final but should be

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #363
 2015-06-08 09:24:07 +02:00
Likitha Shetty
04365601da CLOUDSTACK-8412. VM migration with storage fails. 
Update MigrateWithStorageCommand to avoid JSON deserialization error.
 2015-04-28 10:22:00 +05:30
Likitha Shetty
f45e6b94ed CLOUDSTACK-8405: Restore VM results in deletion of data disk. 
Dont evict template when a delete command has been sent to VMware resource for deletion of volume.
 2015-04-27 16:37:46 +05:30
Rohit Yadav
06e353e5c7 vmware: support vmfs as local storage pool type 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 752d784d92b4ce461ec6a19a6b54220bb967d4d0)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-04-16 17:36:52 +05:30
Rohit Yadav
7949d2922d vmware: plugin improvements 
- use sticky chmod 1777 on the mountpoint
- remove dead code

(cherry picked from commit eea716b7916c916442b19d14e0f6e5c57bebb91e)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-04-13 15:49:01 +05:30
Rohit Yadav
37820e15f2 CLOUDSTACK-7593: allow nic type to be fetched from vm's details 
(cherry picked from commit 43db75c319b425f3b39770d556df59333921bf92)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Conflicts:
	engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
 2015-04-13 15:47:03 +05:30
Daan Hoogland
6a821730ce Boolean -> boolean 2015-03-25 22:20:40 +01:00
Daan Hoogland
048212b117 findbugs: Boolen function should not return null 2015-03-25 21:46:47 +01:00
Rajani Karuturi
843f6b1691 CLOUDSTACK-5236 : ability to identify where the user is from (ex. LDAP) 
Added a source column to the user table.

Source now has only two values UNKNOWN,LDAP with UNKNOWN being the
default and is an enum is com.cloud.User.

When the source is UNKNOWN, the old method of authenticating against all
the available authenticators is used. If a source is available, only
that particular authenticator will be used.

added overloaded methods in AccountService to createUserAccount and
createUser with source specified.

(cherry picked from commit 5da733072e838c830720909ef5ba27ef6ce6d0b0)
 2015-03-16 14:53:53 +05:30
Sanjay Tripathi
3d411dc616 Fixed simulator and vmware NPE issue. 2015-03-13 14:59:34 +05:30
Likitha Shetty
bdd28a45ed CLOUDSTACK-8319. For both 'MigrateVolume' and 'MigrateVMWithVolumes, ensure VM's vconfiguration files are migrated along with VM's root volume. 2015-03-12 11:57:02 +05:30
Likitha Shetty
adc836cc5e CLOUDSTACK-8318. Storage vMotion support for VMFS. 
MigrateVMWithVolumes-
1. If ESXi host version is below 5.1, ensure destination datastore(s) is mounted on the source host, then migrate the storage and then finally migrate the VM.
If destination storage(s) is not mounted on the source host,
- In case of NFS storage mount the storage(s).
- In case of VMFS storage fail the request for migration.
2. If EXi host version is 5.1 or above, simultaneously migrate the VM and its storage to the destination host and storage(s) respectively for both NFS and VMFS storage.
 2015-03-12 11:57:01 +05:30
punith-cloudbyte
ff7ef985f1 NFS support for VMware-managed storage 
Signed-off-by: Mike Tutkowski <mike.tutkowski@solidfire.com>
 2015-03-05 17:39:10 -07:00
Likitha Shetty
25a4f0dc53 CLOUDSTACK-8136. [VMware] Create VM snapshot fails if a previous attempt to take the snapshot failed. 
While looking for an ongoing VM snapshot task, check the task status to identify if the task is still running.
 2014-12-30 14:19:48 +05:30
Likitha Shetty
13bdc1cef4 CLOUDSTACK-8134. Worker VMs don't have MS id set in vCenter annotation 'cloud.vm.workertag'. 
Correctly register node info for a newly created VMware context.
 2014-12-30 11:52:56 +05:30
Likitha Shetty
15b348632d CLOUDSTACK-8129. Cold migration of VM across VMware DCs leaves the VM behind in the source host. 
If VM has been cold migrated across different VMware DCs, then unregister the VM from source host.
 2014-12-26 11:07:30 +05:30
Likitha Shetty
5227ae2275 CLOUDSTACK-8128. VM with Datadisk fails to start when storage is put into maintenance. 
While migrating a volume from primary to seocndary use a worker VM to perform the operations if the VM associated with the volume is stopped.
 2014-12-24 16:57:37 +05:30
Likitha Shetty
974b0180dd CLOUDSTACK-8126. Cold Migration of VM is not working as expected. In case a VM is cold migrated across clusters then VM fails to start. 
1. If a VM by the same name exists on a different cluster in the VMware DC, unregister the existing VM and continue with the VM start.
2. If VM start succeeds, delete VM files associated with the unregistered VM.
3. If VM start fails, re-register the unregistered VM.
 2014-12-24 15:07:08 +05:30
Likitha Shetty
1c0bf32170 CLOUDSTACK-8123. VM re-install fails. 
While moving root disk into VM folder during restore, look for folder based on vCenter name.
 2014-12-24 14:01:20 +05:30
Likitha Shetty
ac491c9607 CLOUDSTACK-8121. Data disk properties are not updated upon Creation/Deletion of VM snapshots. 
Update the path and size of data volumes after snapshot creation/deletion by correctly trimming only the snapshot postfix of a disk.
 2014-12-24 13:04:12 +05:30
Likitha Shetty
4d7ede535d CLOUDSTACK-8119. Propagate error message to UI for attach/detach volume failure operations. 
For AttachVolume/DetachVolume API command, improve user error message in case of RuntimeException by throwing the exception instead of 'Unexpected Exception'.
 2014-12-24 11:29:03 +05:30
Likitha Shetty
ddcae8a930 CLOUDSTACK-8118. Root volume migration fails with 'No such disk device' in case of vCenter 5.5 setup. 
If an exact match is being done while locating disk chain by name, don't trim snapshot postfix appended to the disk name.
 2014-12-24 10:19:22 +05:30
Likitha Shetty
cb211f18d1 CLOUDSTACK-8113. VM migration fails with "Message: No such disk device: " error. 
Consolidate VM disks once VM/volumes are migrated.
 2014-12-23 14:28:17 +05:30
Likitha Shetty
33179cce56 CLOUDSTACK-8112. CS allows creation of VM's with the same Display name when vm.instancename.flag is set to true. 
Before registering a VM check if a different CS VM with same name exists in vCenter.
 2014-12-23 13:48:01 +05:30
Likitha Shetty
647532376f CLOUDSTACK-8111. NFS secondary storage repetitively mounted on CS server with ESXi hypervisors. 
Fix cleanup of NFS mounts on management server during server starup by correcting how mount points are listed for a management server.
 2014-12-23 13:23:43 +05:30
Likitha Shetty
51ee90074d CLOUDSTACK-8110. VM name in vCenter should be VM's DisplayName if global config 'vm.instancename.flag' is set. 2014-12-23 11:42:26 +05:30
Likitha Shetty
507d9d337d CLOUDSTACK-8109. Extract Template is failing. 
Fix the OVA path that is returned once an OVA is packaged using a META file.
 2014-12-23 10:44:10 +05:30
Saksham Srivastava
1df0453d27 CLOUDSTACK-8088: VM scale up is failing in vmware with Unable to execute ScaleVmCommand due to java.lang.NullPointerException 2014-12-18 14:27:55 +05:30