34718 Commits

Author SHA1 Message Date
Rohit Yadav
c84198d76d Merge remote-tracking branch 'origin/4.16'
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2021-12-30 16:52:30 +05:30
Wei Zhou
4ba2ad5397
test: fix component test test_configdrive.py (#5528)
* test: fix test_configdrive.py and move it to smoke test

(sleep 30s as vm crashes after migration in ubuntu 20.04)

* Update test/integration/smoke/test_configdrive.py

Co-authored-by: dahn <daan.hoogland@gmail.com>

* test: fix test_configdrive.py

* Update #5528: move back to component test

Co-authored-by: dahn <daan.hoogland@gmail.com>
2021-12-30 16:31:31 +05:30
Hoang Nguyen
10bda8549b
ui: auto-prefill edit tariff label (#5714) 2021-12-30 16:27:56 +05:30
Abhishek Kumar
d7a9873053
ui: fix add network offering for vpc (#5809)
* ui: fix add network offering for vpc

Fixes issues with form related to supported services provider and router service offering when offering to be created for VPC.

Fixes #5807

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix issues getting with making select element update on options change (loop infinity) (#72)

* fixes

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Co-authored-by: Hoang Nguyen <hoangnm@unitech.vn>
2021-12-30 16:26:54 +05:30
Hoang Nguyen
eb04a46541
ui: Add clear all notification button (#5549)
* add clear all notification button

* change position set count notify

* get notification count

* set label transliteration

* add margin for notification

* change position of clear notification button
2021-12-30 16:24:17 +05:30
Daman Arora
49b2dfc6e4
ui: simplify code using optional chaining in ZoneWizardLaunchZone view (#5619)
* simplify code using optinal chaining in ZoneWizardLaunchZone view

* simplify code using optonal chaining
2021-12-30 16:23:42 +05:30
SadiJr
d0721c5d66
ui: Change permission to access console proxy button (#5625)
This PR fixes #5623.

Also, some more information that is not present in the issue in question:

Although the proxy console access button does not appear in the UI, users with access permission to the VM in question have access to the console as well. Simply generate the console access link using another user, copy that link, and, on the user without access to the console button, type that link.

Co-authored-by: SadiJr <sadi@scclouds.com.br>
2021-12-30 16:23:02 +05:30
Daman Arora
7791b3c10c
ui: simplify code using optional chaining in the zone view (#5626) 2021-12-30 16:22:28 +05:30
Hoang Nguyen
5eccbc9521
ui: Add footer text option for login screen (#5628)
* add footer text option for login screen

* using single key for policy

* set empty for default policy text

* rename footer text key

* rename the footer text property name

* change position avoid breaking with docHelp

* change position of properties
2021-12-30 16:21:40 +05:30
SadiJr
d8d5665903
api: Allow users to list VMs by Backup Offering Id (#5679)
Co-authored-by: SadiJr <sadi@scclouds.com.br>
2021-12-30 16:20:33 +05:30
Wei Zhou
8952cd5955
kvm: add hosts using cloudstack ssh private key (ccc21 hackathon) (#5684)
This PR provides the option to add kvm hosts with empty or wrong password.
To support this, the cloudstack ssh public key needs to be added in the ~/.ssh/authorized_keys on host.

Feature work:

1. get cloudstack public key from management server (/var/lib/cloudstack/management/.ssh/id_rsa.pub)

![image](https://user-images.githubusercontent.com/57355700/141449653-85f644b5-c32e-44ca-9c6b-77570262c046.png)


2. add the key to ~/.ssh/authorized_keys on kvm hosts

![image](https://user-images.githubusercontent.com/57355700/141449722-e906eea5-74fd-4f81-a4d3-41563beeb79c.png)

3. add kvm host with empty password

<img src="https://user-images.githubusercontent.com/57355700/141449865-6ffee1f0-b0d7-4ea4-b11a-32df42e2fe91.png" height="50%" width="50%">

Tested as:
1. add host, with correct password,  works as expected.
2. put host to maitenance, stop cloudstack-agent, cancel maintenance, remove the host. all work.
3. add host, with empty password (ssh public key is added to  ~/.ssh/authorized_keys),   works as expected.
4. put host to maitenance, stop cloudstack-agent, cancel maintenance. all work as expected.
2021-12-30 16:20:04 +05:30
Jayanth Reddy
b63498d847
server: Fix a typo (#5761)
Fix a typo where the word "Security" is misspelled as "Secrity".
2021-12-30 16:17:15 +05:30
Wei Zhou
9798fa08b5
kvm: support qemu-system-x86>=5.2 (#5755) 2021-12-30 16:16:08 +05:30
Nicolas Vazquez
c0ddda361a
[VMware] Fix service offerings listing on appliances deployment options (#5752)
* Fix list service offerings for VMware deployment options

* UI fix to allow selecting offerings
2021-12-30 16:13:41 +05:30
Marcus Sorensen
dcdcd09058
Randomize managed volume copy host (#5789)
* Randomize managed volume copy host

* Managed volume copy was always returning first host that could see storage pools

* Fix null value in logging for ScaleIOPrimaryDataStoreDriver due to if/else logic error

Signed-off-by: Marcus Sorensen <mls@apple.com>

* Use String.format for ScaleIO debug message

Signed-off-by: Marcus Sorensen <mls@apple.com>

* Update debug message for ScaleIO copy methods

Signed-off-by: Marcus Sorensen <mls@apple.com>

Co-authored-by: Marcus Sorensen <mls@apple.com>
2021-12-30 16:11:00 +05:30
Daman Arora
7cb4604e98
simplify code using object shorthand in multiple files (#5766) 2021-12-30 15:29:25 +05:30
Daman Arora
e3b0c0862f
simplify code using optional chaining in multiple config files (#5764)
* simplify code using optonal chaining in multiple config files

* add optional chaining to record too
2021-12-30 15:28:50 +05:30
Gabriel Beims Bräscher
62089767f6
Fix UI issue 5777 Root disk size is not shown as 'Disk Size' on VM deployment. (#5796)
In the UI, when selecting a service offering that has a root disk enforced, stills show the root disk size of the template (or the custom size gave by the user). This PR fixes this issue, that thas been reported in #5777.
Fixes: #5777
2021-12-30 15:21:11 +05:30
Abhishek Kumar
d13057ace5
ui: show tags only for supported resources (#5798)
* ui: prevent incorrect tags displa for primary storage

Tags in info card of the UI are related to tags functionality(create/delete/lsitTags API)
UI was incorrectly showing storage tags as these tags in the UI.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* remove logging

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* ui: show tags only for supported resources

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2021-12-30 15:20:37 +05:30
Rohit Yadav
6728b696cd
kvm: don't always force scsi controller for aarch64 VMs (#5802)
* kvm: don't force scsi controller for aarch64 VMs

This would allow use of virtio disk controller with Ceph, etc or as
defined in the VM's root disk controller setting, rather than always
enforce SCSI.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* remove test that doesn't apply now

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* address review comment

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2021-12-30 15:19:32 +05:30
Pearl Dsilva
9a5a0738b0
ui: Fix configure Sticky policy form (#5814) 2021-12-30 10:31:24 +01:00
Hoang Nguyen
ae62e1dd5e
fixes cannot add new port forwarding rules after auto select VM next time (#5690) 2021-12-30 09:53:51 +01:00
Suresh Kumar Anaparti
0c0254d8f5
Merge branch '4.16' into main 2021-12-28 01:40:23 +05:30
Wei Zhou
7823868746
network: update ip in lb/pf/dnat tables when update vm nic ip (#5757)
* network: update ip in lb/pf/dnat tables when update vm nic ip

* Update: create 3 separated methods for DNAT/LB/PF update

* Update: invert if condition to reduce code indentation
2021-12-28 01:35:29 +05:30
Gabriel Beims Bräscher
19325d0286
Change UI VM deployment to show SSH keys only if user has keys (#5804) 2021-12-28 01:23:36 +05:30
Rakesh
8ba5b92a83
server: Fix NPE while deleting a domain (#5753)
* server: Fix NPE while deleting a domain

While deleting a domain, if vlan ip range cant be found
then this will throw NPE. Just return false if vlan ip
range cant be found

* return true if vlan is not found

* change output message

Co-authored-by: Rakesh Venkatesh <rakeshv@apache.org>
2021-12-28 01:21:43 +05:30
Rakesh
9607ae9639
server: Fix NPE while adding network to VPC (#5723)
* server: Fix NPE while adding network to VPC

Sometimes adding network to VPC fails because of libirt error.
In that case the new network wont have any VR's associated with it
and hence it will return null.

* use collectionutils

Co-authored-by: Rakesh Venkatesh <rakeshv@apache.org>
2021-12-25 19:57:18 +05:30
Hoang Nguyen
12d95a2027
Remove unused gravatar fetch (#5806) 2021-12-24 17:07:14 +05:30
sureshanaparti
9b0a1418ec
Provision to sort ISOs from UI, and Updated Templates/ISOs API response to return in the order of sortkey (#5800) 2021-12-24 12:44:50 +05:30
Rohit Yadav
4b7dcfa27b
README: again that time of the year! 🎄 (#5792)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2021-12-24 10:55:40 +05:30
Suresh Kumar Anaparti
b32f3697e6
Merge branch '4.16' into main 2021-12-23 11:18:17 +05:30
dahn
f03ed8c721
cleanup of unused code and cleanup of cleanup procedure (#5562)
* cleanup of unused code and cleanup of cleanup procedure

* remove unnecessary egress rule

* remove rule and add rule removal

Co-authored-by: Daan Hoogland <dahn@onecht.net>
2021-12-23 10:10:38 +05:30
Daan Hoogland
2a331b3742 Merge release branch 4.16 to main
* 4.16:
  Allow force reboot VM from user account, to start VM on the same host (#5791)
  api: Fix search cluster by name (#5782)
  Enhance log message in FirstFitPlanner (#5762)
2021-12-22 18:03:04 +01:00
sureshanaparti
39e41f6b6e
Allow force reboot VM from user account, to start VM on the same host (#5791) 2021-12-22 17:43:02 +01:00
SadiJr
01f1aaee60
Improve VMWare logs (#5353)
* Improve VMWare logs

* Address reviews

* Address reviews and add more logs

* Improve VMWare logs

* Address reviews

* Address reviews and add more logs

* Address reviews

* Address reviews

* Try fix tests

* Refactor some logs to try fix tests

* Verifying if GSON is the cause of test exceptions

* Fix checkstyle

Co-authored-by: SadiJr <17a0db2854@firemailbox.club>
Co-authored-by: SadiJr <sadi@scclouds.com.br>
2021-12-22 13:56:00 +01:00
Pearl Dsilva
936ebbb90f
api: Fix search cluster by name (#5782) 2021-12-22 10:41:06 +05:30
Gabriel Beims Bräscher
995ce06cb7
Enhance log message in FirstFitPlanner (#5762)
* Enhance log message in FirstFitPlanner

When cluster reached capacity threshold the message is:
"capacity threshold defined at each cluster/ at global value for capacity Type : 0"

Admins hardly remember the Capacity Type and it can take a while to look at which is the resource for the respective ID. This enhancement addes log message pointing to the capacity name (e.g. Memory / CPU) as well as global settings parameter name and value to be looked at.

* Change formatation in String 'warnMessageForClusterReachedCapacityThreshold'
2021-12-22 10:10:40 +05:30
Suresh Kumar Anaparti
99313f8eae
Merge branch '4.16' into main 2021-12-20 14:01:41 +05:30
Hoang Nguyen
29c7518613
UI: Fixes error when delete domain (#5710)
* fixes error when delete domain with polljob response not have jobstatus

* fix listdomain not refresh after deleted
2021-12-20 12:35:32 +05:30
Daniel Augusto Veronezi Salvador
79d924f3ee
Insert correct template size when live migrating VM with volumes (#5758)
Co-authored-by: GutoVeronezi <daniel@scclouds.com.br>
2021-12-16 20:21:38 +05:30
Wei Zhou
cc856277de
UI: fix create Isolated/L2 network form (#5779) 2021-12-16 11:24:11 +05:30
Suresh Kumar Anaparti
3bb987d424 Merge branch '4.16' into main 2021-12-15 17:06:22 +05:30
Gabriel Beims Bräscher
8ace2722e7
Set length for parameters that expect a list of domain ids. (#5763)
Currently, when updating a service offering there is a limitation of the number of domains the offering can be updated.

Multiple domain ids lead to the following API error:
Error: (HTTP 431, error code 9999) Unable to execute API command updateserviceoffering due to invalid value. Value greater than max allowed length 255 for param: domainIds"
2021-12-15 13:38:15 +05:30
Gabriel Beims Bräscher
cb75e8f1af
Update listVirtualMachines API documentation with 'projectid=-1' to list all VMs in projects. (#4276)
* Enhance API list commands documentation for "listAll" and "projectid" parameters
2021-12-14 21:36:51 +05:30
Wei Zhou
937996c1a1 Merge remote-tracking branch 'apache/4.16' 2021-12-14 09:05:49 +01:00
Wei Zhou
d49f67ceb9
travis: install python3-setuptools (#5767) 2021-12-13 16:22:21 +01:00
Wei Zhou
51d4e5475f Merge remote-tracking branch 'apache/4.16' 2021-12-10 17:50:25 +01:00
SadiJr
9363f6490b
Fix full backup VM restore (#5680)
Co-authored-by: SadiJr <sadi@scclouds.com.br>
2021-12-10 07:16:42 +01:00
dahn
8bc69e919c
conditional broadcastUri (#5745)
* conditional broadcastUri

* add filter to keep order and apply to details as well

* use global isAdmin method

Co-authored-by: Daan Hoogland <dahn@onecht.net>
2021-12-08 10:27:58 +05:30
dahn
a47e53fcee
internal ref replaced by uuid (#5738)
* internal ref replaced by uuid

* remove all internal DB IDs from usage records

* remove superfluent .append(")")

Co-authored-by: Daan Hoogland <dahn@onecht.net>
2021-12-07 10:09:38 +05:30