31218 Commits

Author SHA1 Message Date
Frank Maximus
1414d20852 CLOUDSTACK-9749: Disable password service on ilb systemvm (#1912)
Fix cloud-password-srvr correctly.
Made sure it runs on VPC VR, but not on Internal LB
2017-08-03 22:38:25 +02:00
SowjanyaPatha
9fe5630c71 CLOUDSTACK-9944: In Cluster Management Server, Sometimes hosts stays in disconnected state (#2138)
In clustered management server setup on simultaneous restart of management server, sometimes hosts stays in disconnected state.
2017-08-03 22:34:23 +02:00
dahn
597df24b53 CLOUDSTACK-10007: Isolation methods (#2193)
Change isolation methods from an enum to a registry based construct to enhance pluggability
2017-08-03 12:20:37 +02:00
Rohit Yadav
98dc4eb96a CLOUDSTACK-9782: New Background Polling Task Manager (#2218)
CloudStack has several background polling tasks that are spread across
the codebase, the aim of this work is to provide a single manager to
handle submission, execution and handling of background tasks. With
the framework implemented, existing oobm background task has been
refactored to use this manager.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-03 11:53:45 +02:00
SudharmaJain
5397106a76 CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver (#883)
After integrating XS with CCP the following folder gets created: /var/log/cloud/ however the logs in that are not rotated resulting in root file system fill up. It was a known issue and link http://support.citrix.com/article/CTX138064 describes the issue and solution. Used the article and added corresponding changes to Cloudstack.
2017-08-03 00:51:16 +02:00
Gabriel Beims Bräscher
e0b6dcbe4a CLOUDSTACK-9925: Quota memory tariff value is for 1MB of RAM used per month (not hour) (#2119)
The quota memory tariff description in the CloudStack UI is wrong when defines that the value is for "using 1MB or RAM for 1 hour". The quota currency values reflect the value of a resource used per month, not an hour.

Quota divides the tariff value by the number of hours a month has (30 days - 720 hours); then it calculates the credits used by a client based on the amount of resources used per hour. The memory tariff description in the interface is wrong and can guide users to configure values for an hour.
2017-08-03 00:47:33 +02:00
Rashmi D
e43a4b9a09 CLOUDSTACK-9697: Added better error message user if tries to shrink (#2145)
the VM ROOT volume size

Skip the API call altogether if the UI detects this and throw a more user friendly message
2017-08-03 00:45:45 +02:00
mrunalinikankariya
b936feb108 CLOUDSTACK-9950:listUsageRecords doesnt return required fields (#2137)
There is no cpuspeed, cpunumber or memory details in the listUsageRecords output as documented
In DB (cloud_usage table) we have cpu_speed, cpu_cores and ram fileds, but these are not populated for all the VM's. These fields are only populated for the VM's which are deployed with custom service offerings.
2017-08-03 00:39:57 +02:00
Olivier Lemasle
43ae8e3503 CLOUDSTACK-9840: Fix datetime format of snapshots events (#2008)
Include the timezone in datetime format of snapshot events, to be consistent
with every other events.
"eventDateTime" was added by @chipchilders in commit 14ee684ce3 and was
updated the same day to add the timezone (commit bf967eb622f) except for
Snapshots.
2017-08-03 00:31:49 +02:00
Rohit Yadav
1d95cbbfed Merge branch '4.10' 2017-08-03 00:31:12 +02:00
Rohit Yadav
b60e173c5c Merge branch '4.9' into 4.10 2017-08-03 00:29:24 +02:00
Ronald van Zantvoort
974e01ed08 CLOUDSTACK-10011: Fix Agent logrotation (#2094)
* CS Agent: Correct logrotation for agent log
* CS Agent: Logrotate security_group as well
* CS Agent: fix logrotation file perms so logrotate doesnt skip it
2017-08-03 00:29:02 +02:00
SowjanyaPatha
7fea069e8a CLOUDSTACK-9954 Unable to create service offering with networkrate=0 (#2142)
Unable to create service offering with networkrate=0(Unlimited network throttling) with an error "Failed to create service offering xxxxxxx: specify the network rate value more than 0".
2017-08-03 00:19:38 +02:00
Nitin Kumar Maharana
1b898d610c CLOUDSTACK-8961: Changes related to the UI of VPN Users management. (#2130)
The current VPN users are added in the VPN tab inside the public IP after the VPN is enabled. For each network(for which VPN is supported and enabled), the VPN users are shared. As the Cloudstack doc says “ The account owner can create and manage users for their VPN. CloudStack does not use its account database for this purpose but uses a separate table. The VPN user database is shared across all the VPNs created by the account owner. All VPN users get access to all VPNs created by the account owner.”

The current implementation of going inside each network and adding VPN users give the first feel as if the users are network based. To fix this, Shifted the VPN users to networks tab view.
2017-08-03 00:14:53 +02:00
Rohit Yadav
5ccbe04c0a Merge branch '4.10'
This uses `ours` fwd-merging strategy.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:45:33 +02:00
Rohit Yadav
d53f500977 Merge branch '4.9' into 4.10
This merge uses `ours` strategy for forward merging.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:44:25 +02:00
subhash yedugundla
b70879cbac CLOUDSTACK-9560 Root volume of deleted VM left unremoved
(cherry picked from commit 5568ee93ad08f998822dc0428e511dc8e8609014)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Nitesh Sarda
26bcb9afd8 CLOUDSTACK-9935 : Search in VPN Customer Gateway not working
(cherry picked from commit fdadc7b7607e9f3b78d0577a09986fab346c1788)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Subhash yedugundla
aaae977c53 CLOUDSTACK-9555 when a template is deleted and then copied over again , it is still marked as Removed in template_zone_ref table
(cherry picked from commit c3bc69c724440786f890116b516b03fc38c672cb)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Sudharma Jain
96671543dc CLOUDSTACK-9567 Difference in the api call outputs for CAPACITY_TYPE_CPU = 1
(cherry picked from commit 732be53044d0a682bd124a291febc6e11cfde77b)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Subhash Yedugundla
77fb2c92ce CLOUDSTACK-9592 Empty responses from site to site connection status are not handled propertly
(cherry picked from commit ddf8fd514af3ee6fd2a7524a2bc7ea84fc22ea2d)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Priyank Parihar
30bb5587d2 CLOUDSTACK-9610: Disabled Host Keeps Being up status after unmanging cluster.
(cherry picked from commit 4b165f1b8f0781299ba955c8425a32e15869a1d1)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Sateesh Chodapuneedi
6977cb3841 CLOUDSTACK-9684 Invalid zone id error while listing vmware zone
Issue
=====
While listing datacenters associated with a zone, only zone Id validation is required.
There is no need to have additional checks like zone is a legacy zone or not.

Fix
===
Removed unnecessary checks over zone ID and just checking if zone with specified ID exists or not.

Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapuneedi@accelerite.com>
(cherry picked from commit 0ef1c17541808641983e7c109db31e5cecc0ef44)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Sudhansu
f8f71a5af6 CLOUDSTACK-9694: Unable to limit the Public IPs in VPC
Added missing clause to check for vpc_id

(cherry picked from commit cdf2b0727a653f71c2ea10be1b46d2002f88a2e3)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Anshul Gangwar
75c81d918a CLOUDSTACK-9705: Unauthenticated API allows Admin password reset
Now, Updating the password via UpdateUser API is not allowed via integration port

(cherry picked from commit d206336e1a89d45162c95228ce3486b31d476504)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Sudhansu
8240bc4aa2 CLOUDSTACK-9701: When host is disabled/removed,
capacity_type for local storage in op_host_capacity
is still enabled

(cherry picked from commit e06e3b7cd41787efc4e0f3cbf2d5a3040b4f15c9)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Sudhansu
4bacb64994 CLOUDSTACK-9842: Unable to map root volume usage to VM
removed code which nullifies  vm_instance_id
Also modified QueryManagerImpl to ignore volume which does not have uuid. This is to avoid duplicate volume listing.

(cherry picked from commit 3cced927c4b1d7e1d8f19bccef46ed8d82e31f41)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Sudhansu
1535afe158 CLOUDSTACK-9843 : Performance improvement of deployVirtualMachine, createFirewallRule, createPortForwardingRule
removed 1 sec sleep in SSHHelper.

(cherry picked from commit 28bb8ba1e4568fc891831772e2051c474e81d528)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
SudharmaJain
af6c28b3ce CLOUDSTACK-8910: The reserved_capacity field increases suddenly after a vmware host failure
In case of vmware host failure, all the VMs including stopped VMs migrate
to the new host. For the Stopped Vms powerhost gets updated. This was
triggering HandlePowerStateReport which finally calls updatePowerState
updating update_time for the VM. This cause the capacity being reserved
for stopped VMs.

(cherry picked from commit 9d268c8cd589f70d41aa737206e7cf4b31007702)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
subhash yedugundla
1b26a486d1 BUG-ID:CLOUDSTACK-8921
Summary: CLOUDSTACK-8921
     snapshot_store_ref table should store actual size of back snapshot in secondary storage
Calling SR scan to make sure size is updated correctly

(cherry picked from commit 4e4b67cd96f6b360f5810099fb6b902b5491e001)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Nitesh Sarda
9334e091c0 CLOUDSTACK-9937 : dedicateCluster API response does not return correct detail in response
(cherry picked from commit 7364616aa4ac28f413b34306c1d497093dae0600)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Nitesh Sarda
e574953427 CLOUDSTACK-9814 : Unable to edit a Sub domain, which has the same name in different domains
(cherry picked from commit 254771c01cb2f3fa4bfc668d36bf11ae133cf61c)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Bharat Kumar
d03f499b05 CLOUDSTACK-9638 Problems caused when inputting double-byte numbers for custom compute offerings
(cherry picked from commit 59312dd976a6fb5e4d5d3a5b701fc1cccac9a3d2)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Nitesh Sarda
64d09c737a CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs
(cherry picked from commit 10b25adc460f89d4d98ee0c6090a4f785aa088a6)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
nitt10prashant
9effd472a1 Changing vlan to None since network offering being used has Specify Vlan set to False
(cherry picked from commit 47747e71881954dab748924ff880beccc687dd1f)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Anshul Gangwar
16b67b40fd CLOUDSTACK-9686: Fixed multiple entires for builtin template in template
store ref table so builtin template is never downloaded completely
 In handleSysTemplateDownload method creating template only if there exists no entry
handleTemplateSync will take care of other scenario

(cherry picked from commit 929595c114f1214f064419a305cc115a3e136803)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Bharat Kumar
63997b3b19 CLOUDSTACK-9666 Added basic configuration validation for the config drive global settings
(cherry picked from commit 366175b9a5dd3994b2807fcc5aaeed7a22052cae)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Nitin Kumar Maharana
42e60ebac6 CLOUDSTACK-9708: Router deployment failed due to two threads start VR simultaneously.
(cherry picked from commit 9e20525e08d8dae7bcf3d568c5a1ccdb793eeb9d)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Rajani Karuturi
9ce2dde030 CLOUDSTACK-9834: prepareTemplate API call doesn't work well
with XenServer & Local SR (Db_exn.Uniqueness_constraint_violation)

removed the host uuid from SR label so that any host which has access to
the SR(all the hosts in the same pool) can reuse the same SR

(cherry picked from commit 1aa6a72bc7deda32c8cd07e468841e3fc15bf6f8)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Anshul Gangwar
9ddbd9eda7 CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume
Update the volume id in volume_store_ref table to newly created volume for migration

(cherry picked from commit 42b89278e9386b8bc90e36fb600d7730e676ae72)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Likitha Shetty
f9e51653ae CLOUDSTACK-8829 : Consecutive cold migration fails
(cherry picked from commit 88b0459c41c51e832547667ea537fb9ce9d9f4c1)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Bharat Kumar
b696a00ea2 CLOUDSTACK-9725 Failed to update VPC Network during N/w offering Upgrade which doesnt have ACL service Enabled.
check if acl service provider is configured when network is associated with a acl.

(cherry picked from commit bbff9f15754c06dc8a7a74fdd34ab7968b052c3f)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Sudhansu
5ce122cc08 CLOUDSTACK-9630: Cannot use listNics API as advertised
added missing  details for listNics API response.

(cherry picked from commit e7326b10ef1f51b470df6b683e1e06d753fb02f7)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Jayapal
4c37e11175 CLOUDSTACK-8931: Fail to deploy VM instance when use.system.public.ips=false
(cherry picked from commit e1384c3b639541cad08bf11e46cfa5a8af171ee7)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
root
41d1d40940 CLOUDSTACK-9748:VPN Users search functionality broken
(cherry picked from commit 61823c24f658eb0fe3f1246e61d4a6b9f308cb00)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Jayapal
a7cfdf66fd CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 error response
(cherry picked from commit 70422e79072ff933a33a5f95df3a2c9f4bb0d203)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Rene Moser
05f94b8ef7 Bug fix for CLOUDSTACK-9762 Management Server UI (VM statistics page) CPU Utilized value is incorrect.
(cherry picked from commit b676a8a7c3fd554d87afdac6328d9ac5d0265308)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Sanket Thite
ba60718585 VM snapshot is disabled if the VM Instance is off
(cherry picked from commit bd80c8e1797ef4dc819a22f2629bccd94beb8741)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Nitin Kumar Maharana
645283abc4 CLOUDSTACK-9623: Deploying virtual machine fails due to "Couldn't find vlanId" in Basic Zone
(cherry picked from commit 280f3be4e6c77ed50d9f3d09a40ee1a6d470f313)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00
Anshul Gangwar
e6855db78a CLOUDSTACK-9685: delete snapshot on primary associated with a volume when that volume is deleted
as that snapshot will never be going to use again and also it will fill up primary storage

(cherry picked from commit 336df84f1787de962a67d0a34551f9027303040e)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-08-01 20:40:25 +02:00