64 Commits

Author SHA1 Message Date
Prachi Damle
d84a8601e5 CLOUDSTACK-1362: EC2 dns-name filter support for EC2 describeInstances API is broken
Mapped CS UserVm 'name' propertyto the dns-name value to filter out the results.
2013-02-21 14:01:52 -08:00
Prachi Damle
8296d41b5b CLOUDSTACK-1330: ec2-run-instances - When -n option is used to deploy multiple Vms API returns error even though few of the Vms have been deployed successfully.
Changes:
- Instead of throwing out error, return the response containing the info about the instances that were launched.
2013-02-19 15:12:06 -08:00
Likitha Shetty
f0086df0c7 CLOUDSTACK-1134: [EC2 Query API] DescribeSnapshots, 'n' ListVolumes get fired on CS for displaying 'n' Snapshots taken from the same Volume
For snapshots taken from the same volume re-use the response obtained by calling listVolumes
2013-02-13 17:54:23 -08:00
Prachi Damle
c3be0f995d CLOUDSTACK-1135: [EC2 Query API] AuthorizeSecurityGroupIngress and RevokeSecurityGroupIngress fails when icmp code and type is provided
For AuthorizeSecurityGroupIngress RevokeSecurityGroupIngress query calls parse and set the icmp code and type
2013-02-12 14:45:29 -08:00
Likitha Shetty
57969843d6 CLOUDSTACK-1133: [EC2 Query API] In StopInstances add support for parameter 'force'
Propagate this parameter to CS to force stop an instance
2013-02-12 14:04:07 -08:00
Likitha Shetty
3337106693 CLOUDSTACK-1131
[EC2 Query API] RunInstances allows negative values for paramters 'MinCount' and 'MaxCount'
Add parameter validation to ensure MinCount is greater than 0 and MaxCount is great than or equal to MinCount
2013-02-12 14:01:10 -08:00
Likitha Shetty
b0b2fd4833 CLOUDSTACK-1125: [EC2 Query API] Permission denied exception when a parameter value contains space
Convert space characters in the parameters to %20 while forming a query string after url-encode because java.net.URLEncoder performs application/x-www-form-urlencoded-type encoding and not percent-encoding. According to RFC 3986 as required by Amazon, we need to percent-encode.
2013-02-12 13:56:36 -08:00
Prachi Damle
c26b02a0a7 CLOUDSTACK-1129: [EC2 Query API] DescribeVolumes, add support for filter attachment.status
1. If volume is attached to a VM set attachment state based on the state of the VM it is attached to.
Running, Starting, Stopped -> Attached
Starting -> Attaching
Destroyed, Error -> Detached
2. If volume is not attached to a VM set attachment state as 'detached'
2013-02-12 13:40:58 -08:00
Prachi Damle
cd039206d3 CLOUDSTACK-1128: [EC2 Query API] DescribeAvailabilityZones, support for message filter
Add message in the response element of EC2DesrcibeAvailibilityZones. Add support for filter 'message'.
The value of 'message' should be set to the allocation_state of the zone
Code cleanup
2013-02-12 13:35:31 -08:00
Likitha Shetty
52b81f8bff CLOUDSTACK-1127: [EC2 Query API] DescribeSecurityGroups, support for additional filters
Add support for filters ip-permission.group-name and ip-permission.user-id
2013-02-11 15:26:49 -08:00
Likitha Shetty
06fd21bd44 CLOUDSTACK-1126: [EC2 Query API] RunInstances ignores the UserData input parameter
When EC2RunInstances is called with UserData parameter, the parameter is not propogated to CS
2013-02-11 14:20:40 -08:00
Likitha Shetty
41f6585754 CLOUDSTACK-1136: [EC2 Query API] AssociateAdress, DisassociateAddress and ReleaseAddress fail with NPE
When invalid parameter is provided as input for any of these API's we get an NPE
2013-02-11 12:05:03 -08:00
Likitha Shetty
1e8648c92d CLOUDSTACK-1124 [EC2 Query API] Improve the logging. Having empty response objects is harmless to functionality
This is observed in the awsapi.log for all Describe* EC2 commands when the response object returned by CS has no elements. But with EC2DescribeImages command it is always observed. This is because every time DescribeImage is fired, we call CS listTemplates command multiple times, each time setting a different value for the templateFilter parameter (e.g. featured, executable, community etc.). And for some of these CS calls made we obtain am empty response and hence the message in the logs.
2013-02-11 11:50:13 -08:00
Likitha Shetty
5d09b9fd3a CLOUDSTACK-1112 [EC2 Query API] DescribeSnapshots fails, when an invalid 'snapshotId' parameter is provided 2013-02-11 11:37:57 -08:00
Likitha Shetty
f839ad7b53 CLOUDSTACK-1121: [EC2 Query API] RunInstances, instance is always deployed in the default security group
During EC2RunInstances, even if the security group the instance is to be deployed in specified the instance gets deployed in the default security group
2013-02-11 11:19:55 -08:00
Likitha Shetty
05280976e5 CLOUDSTACK-1120 [EC2 Query API] Parameter 'keynames' is not honoured by DescribeKeyPairs
When EC2DesribeKeyPairs is called with filter 'keynames' it ignored the key-name provided and lists all the key-pairs
2013-02-11 11:09:36 -08:00
Likitha Shetty
2364ada4df CLOUDSTACK-1119 [EC2 Query API] Add filter support for DecsribeAddresses
EC2DescribeAddresses doesn't have filter support.
Support will be available for filters -> instance-id and public-ip
2013-02-07 18:32:48 -08:00
Likitha Shetty
b5e28038cb [EC2 Query API] DescribeAvailabilityZones doesn't have any filter support.
CLOUDSTACK-1118

Support will be available for filters - zone-name and message
2013-02-07 18:00:35 -08:00
Likitha Shetty
12ad296b6c CLOUDSTACK-1117 [EC2 Query API] DescribeImageAttribute fails
EC2DescribeImageAttribute fails with 'Unsupported - only description supported' error. And this is observed for both the supported attributes 'Description' and 'LaunchPermission'
2013-02-07 17:54:02 -08:00
Prachi Damle
4e4edc9e42 CLOUDSTACK-1116 [EC2 Query API] Support for ModifyImageAttribute and ResetImageAttribute
https://reviews.apache.org/r/9213

Add support for EC2 ApiI's ModifyImageAttribute and ResetImageAttribute.
Attributes supported are Description and LaunchPermission.
2013-02-07 17:22:16 -08:00
Kelven Yang
7bd8bec68a Sync javelin with master up to 894cb8f7d9fc8b5561754a9fa541fef8f235148a 2013-01-31 17:20:19 -08:00
Likitha Shetty
64b00d0b34 [EC2 Query API] Remove the registration step since query API does not require the certificate
https://reviews.apache.org/r/8742/

While checking if the user keys exists and also while retrieving the secret-key for signature generation (Query API only), make a change to directly check in the 'cloud' DB instead of the 'cloudbridge' DB.
With this change user will not require to register the keys before making EC2 Query API calls against CS. The registration process to make EC2 SOAP API calls will remain the same.
2013-01-31 12:00:39 -08:00
Likitha Shetty
f18828d7d8 [EC2 Query API] AttachVolume fails with 'Permission Denied: Invalid Signature' error.
https://reviews.apache.org/r/8480/

In AWSAPI while forming the signature to validate an API, url-encode every parameter name with UTF-8 encoding scheme.
2013-01-31 12:00:37 -08:00
Likitha Shetty
61f24d8a16 [EC2 Query API] RunInstance and DescribeInstances throw NumberFormatException error when called using AWS Java SDK
https://reviews.apache.org/r/8483/

AWS Java SDK doesn't expect a string value in the AmiLaunchIndex response element for RunInstances and DescribeInstances response.
2013-01-31 12:00:35 -08:00
Likitha Shetty
d738c81a46 [EC2 Query API] DescribeAddresses fails with Null Pointer Exception.
https://reviews.apache.org/r/8492/

As a part of EC2 Query API support, resolve the NPE obtained when DescribeAddresses is called
In EC2Engine modify DescribeAddresses implementation to be consistent with the other Describe* API implementation
2013-01-31 12:00:32 -08:00
Likitha Shetty
de517d95b0 [EC2 Query API] AuthorizeSecurityGroupIngress and RevokeSecurityGroupIngress return false even when the request is successful.
https://reviews.apache.org/r/8513

If the response is not null and if all the ruleid's(permissions) are present return true.
2013-01-31 12:00:30 -08:00
Likitha Shetty
b514735c7b [EC2 Query API] AuthorizeSecurityGroupIngress fails with 'Server.InternalError 431 Invalid protocol' error.
https://reviews.apache.org/r/8468

Before making the AuthorizeSecurityGroupIngress CloudStack API call, parse the string arguments 'FromPort' and 'ToPort' as an integer.
2013-01-31 12:00:28 -08:00
Likitha Shetty
bea669d091 [EC2 Query API] RevokeSecurityGroupIngress fails with 'EC2ResponseError'.
https://reviews.apache.org/r/8466/

[EC2 Query API] Provide DescribeKeyPairs Query API support in CS AWSAPI.
https://reviews.apache.org/r/8465/
2013-01-31 12:00:25 -08:00
Prachi Damle
3c75d53f2f more change to fix awsapi deployment with maven and jetty and Spring 2013-01-30 18:16:45 -08:00
Kelven Yang
526bb01b04 Fix awsapi issues in Spring wiring 2013-01-30 16:43:40 -08:00
Prachi Damle
4dc63f50a7 Spring hack for Ec2RestServlet 2013-01-30 15:56:56 -08:00
Kelven Yang
176523254e Improve component lifecycle management with system run-level concept 2013-01-30 15:21:02 -08:00
Kelven Yang
da2e6461a6 Remove temporary hacking and use Official way to wire-up servlet with injection under Spring 2013-01-30 15:21:01 -08:00
Kelven Yang
b5deb52fba Put a tempoary fix to awsapi to workaround an issue with jetty/Spring integration limitation 2013-01-28 17:45:16 -08:00
Prachi Damle
2bfdce02f1 Spring changes in awsapi 2013-01-28 16:01:50 -08:00
Alex Huang
f40e7b7511 removed componentlocator and inject 2013-01-10 11:05:20 -08:00
Alex Huang
30f2565d98 Merge branch 'api_refactoring' into javelin 2013-01-08 12:36:04 -08:00
Hiroaki Kawai
a28f4cac3c HttpClient needs releaseConnection method call
reviewboard: https://reviews.apache.org/r/8186/

Signed-off-by: Hugo Trippaers <trippie@gmail.com>
2012-11-29 20:23:30 +01:00
Hiroaki Kawai
c8832cd4b6 Commit https://reviews.apache.org/r/8075/
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2012-11-19 12:02:26 +01:00
Kelven Yang
cea8f3bf37 Switch inject annotation to javax and let ComponentLocator to recognize both the new and original inject annotation 2012-11-07 15:03:22 -08:00
Kelven Yang
aab02e2743 Add Spring annotation to major components 2012-11-07 14:53:39 -08:00
Chip Childers
7090c10311 CLOUDSTACK-327: Correcting license header
Signed-off-by: Chip Childers <chip.childers@gmail.com>
2012-10-12 11:59:33 -04:00
Hugo Trippaers
3343362328 Better to print an error message than to die with a npe. 2012-10-02 07:35:10 -07:00
Hugo Trippaers
28bfaea0d1 Fix some dependencies for awsapi. Axis2 and rampart versions should be
equal otherwise there will be conflicts with dependencies.

Small change to EC2MainServlet, pass along the rootcause for easier
debugging
2012-10-01 21:36:27 -07:00
Chip Childers
8746e902e4 CLOUDSTACK-56 : fixing license headers 2012-09-07 17:03:53 -04:00
Jamshid Afshar
5d208a5c95 Add initial support for Caringo CAStor object store as backing store for S3 API
Signed-off-by: Chiradeep Vittal <chiradeep@apache.org>
2012-09-05 23:35:09 -07:00
Rajesh Battala
39aa7d86af Moved Awsapi (EC2/S3) from Hibernate framework to CloudStack Generic Dao Framework
Created/Modified new VO's and Dao Impl classes to use Generic Dao Framework
2012-08-31 11:44:58 -07:00
Likitha Shetty
8c3450b503 CS-14770. ec2-run-instances and ec2-describe-instances don't return keypair information. Component: AWSAPI. 2012-08-28 13:52:42 -07:00
Likitha Shetty
fef8f6d4af CS-15703: EC2 tag support, improve error handling. Component: AWSAPI.
Handle exceptions thrown when invalid syntax is used to create or delete tags.
2012-08-27 15:56:13 -07:00
Mice Xia
1894fb56cf Remove @author tag from non third-party source files in awsapi folder 2012-08-13 14:59:31 +08:00