Jessica Wang
c93b0967ef
CLOUDSTACK-6140: UI - template - detailView - move fields that are used more often to the top.
2014-02-19 15:31:02 -08:00
Brian Federle
b01720d936
listView: Fix 'addRow' event being triggered under wrong scope
2014-02-19 14:36:23 -08:00
Prachi Damle
42a7d41c55
Adding annotations to router commands
2014-02-19 12:22:35 -08:00
Prachi Damle
bbaa742863
Adding annotations to admin commands
2014-02-19 12:22:33 -08:00
Prachi Damle
f0a9b3b510
@ACL from some commands
2014-02-19 12:22:30 -08:00
Min Chen
13e25d2aae
Fixed a bug in constructing search parameters with accountName passed.
2014-02-19 11:35:00 -08:00
Hugo Trippaers
5e717cbb89
Fixed on master for jenkins buildslave
2014-02-19 16:21:43 +01:00
Hugo Trippaers
fefddc0624
Dynamically detect the current branch and remove the build date from the systemvm name. This makes it easier to push them to the download location automagically.
2014-02-19 09:36:03 +01:00
Antonio Fornie
808c6df6d7
Fix and add some Rest unit and IT tests. Fix by adding a missing type of RoutingConfig.
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-19 09:30:57 +01:00
Girish Shilamkar
b70af44ecf
CLOUDSTACK-4840: Add missed testcase in previous commit
2014-02-19 11:17:22 +05:30
Nitin Mehta
c969aa2595
CLOUDSTACK-6134:
...
If volume already exists for the vm - register the vm in the inventory and start it.
2014-02-18 18:24:33 -08:00
Min Chen
26e92af62d
Rename IAM api and response package name so that they are following
...
convention used by ApiXmlDocWriter.
2014-02-18 16:08:06 -08:00
Hugo Trippaers
24309f6001
Prevent a ClassCastException when the answer is not a SetupAnswer (which happends when something goes wrong while connecting)
2014-02-18 12:37:36 +01:00
Hugo Trippaers
f1139848e5
Slight optimization, don't run checkstyle on container or non-java projects.
2014-02-18 12:24:11 +01:00
Hugo Trippaers
594b51c629
Fixup the license headers in the utils project. All files now use the same license header and this is enforced by the maven-license-check plugin.
2014-02-18 12:08:36 +01:00
Ashutosh K
860b020950
CLOUDSTACK-4840: Adding first set of test cases for Multiple IPs per NIC feature
2014-02-18 15:51:57 +05:30
Hugo Trippaers
a369647bca
Fix license headers
2014-02-18 10:16:31 +01:00
Antonio Fornie
510972abde
Nvp and rest refactoring and more tests
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-18 09:51:54 +01:00
John Kinsella
dda47dbd67
package.sh: cleaning up formatting
...
No logic changes made. Tested no syntax errors added.
2014-02-17 10:51:34 -08:00
John Kinsella
9dd57c22b0
CLOUDSTACK-6129: removing hard-coded script names
...
Replacing whatami with $0 which is how UNIX shell scripts should get the
script's name.
BUG-ID: CLOUDSTACK-6129
Bugfix-for:
Reviewed-by:
Reported-by:
Signed-off-by: John Kinsella <jlk@stratosec.co> 1392660036 -0800
2014-02-17 10:00:36 -08:00
John Kinsella
9f72443bb1
CLOUDSTACK-6123: Ensuring no color in grep output
2014-02-15 21:26:40 -08:00
Sheng Yang
2b1b4352bc
Revert "CLOUDSTACK-5779: Fix missing clean up period for VR"
...
This reverts commit 161e7d93ca9d03e9aa7e7be9e12d1ad337de9b14.
Duplicate code, bad memory...
2014-02-14 19:40:00 -08:00
Sheng Yang
cc8eebeca5
CLOUDSTACK-5779: Fix VR commands which didn't use accessIp to VR
2014-02-14 19:20:00 -08:00
Sheng Yang
deb55acd14
CLOUDSTACK-6047: Made VR scripts name to constant string
2014-02-14 18:10:11 -08:00
Sheng Yang
6bde675f87
Remove SetupGuestNetworkAnswer
...
It's unnecessary and not different from Answer itself.
2014-02-14 18:10:05 -08:00
Sheng Yang
161e7d93ca
CLOUDSTACK-5779: Fix missing clean up period for VR
2014-02-14 18:10:00 -08:00
Min Chen
ebfe947f41
Fixed some bugs encountered in testing iam-plugin apis.
2014-02-14 15:04:29 -08:00
Jessica Wang
e1e16a2301
CLOUDSTACK-6120: UI > listView widget > sorting order > fire only one sorting API call(updateXXXXXXX&sortKey=n&id=UUID) for items who have the same UUID.
...
e.g. An Template/ISO of multiple zones have the same UUID.
2014-02-14 12:55:53 -08:00
Min Chen
586ee74000
Clean up SecurityChecker.AccessType and modify code to use them
...
consistently.
2014-02-14 11:23:05 -08:00
Hugo Trippaers
443acac927
Fix functional issue introduced by some findbug changes.
2014-02-14 18:37:47 +01:00
Hugo Trippaers
97bad4f9b3
Fix checkstyle and license issues
2014-02-14 18:37:47 +01:00
Daan Hoogland
15fa2ef8df
findbugs: check for system template id == -> equals()
2014-02-14 18:37:47 +01:00
Daan Hoogland
0d7a96526c
error message containing array content instead of array
2014-02-14 18:37:47 +01:00
wrodrigues
3199de69fe
Fixes on Contrail and Mon InMemory plugins; adding comments about the changes.
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:47 +01:00
Antonio Fornie
cbea6d26e8
Fix and test GroupBy SQL query creation
...
Signed-off-by: Ian Southam <isoutham@schubergphilis.com>
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
Miguel Ferreira
8649fa005a
Fix findbugs findings in cloud-plugin-network-elb
...
Findings:
- comparing Longs by reference
- possible null pointer dereference
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
Ian Southam
5a6ad11fa2
findbugs findings
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
Ian Southam
33c2c87287
Findbugs finding
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
miguelaferreira
1237bf3222
Fix findbugs findings in cloudstack-service-console-proxy-rdpclient
...
Findings:
- 32 int shifted by an amount not in range -31..31:
The shifts by 32 bits don't actually have any effect on the value
(as shown by the tests)
- possible null pointer dereference
- repeated conditional test
- field only ever set to null
All other uses of the field were to check if it was null,
which it was, so it was removed
Other actions:
- Upgrade jUnit to version 4
- Add PowerMock dependency
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
Hugo Trippaers
ef2ced7564
Fix findbugs findings in cloud-plugin-network-ovs
...
OvsTunnelManagerImpl.java:456, RC_REF_COMPARISON, Priority: High
Serveral low priority fixes
2014-02-14 18:37:46 +01:00
Hugo Trippaers
cc6938e3a8
Findbugs : Fix several "of concern" findings.
2014-02-14 18:37:46 +01:00
Hugo Trippaers
091694ceb2
Findbugs : NP_NULL_PARAM_DEREF_NONVIRTUAL fixed
2014-02-14 18:37:45 +01:00
Hugo Trippaers
26b32141a8
Findbugs : Fixes for several findings
...
Made a comment on the use of ConcurrentHashMap for _agent
Conflicts:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
2014-02-14 18:37:45 +01:00
Hugo Trippaers
9b841af529
Findbugs : A map can't retrieve an object by index, so get(0) would
...
return null. Changed to retrieve the first entry in the map.
Removed the ExecutionException try catch, this would prevent the
unittest from giving accurate information on exceptions. Avoid catching
checked exceptions in a unittest, use expected keyword on @Test instead.
2014-02-14 18:37:45 +01:00
Hugo Trippaers
d4d49578dc
Findbugs : Fix a number of potential NPEs and minor findings
2014-02-14 18:37:45 +01:00
Alex Hitchins
e0a4b7c891
Findbugs - Long equality fix.
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:45 +01:00
Alex Hitchins
39cfc4968c
AJH Findbugs [8] - Added .toString() to enum.
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:45 +01:00
Alex Hitchins
b8c228e151
AJH Findbugs [9] - Added object to map rather than string
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:45 +01:00
wrodrigues
f414018a60
adding fix and unit tests for cloud-engine-api scariest
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:44 +01:00
wrodrigues
0ff943337c
fixing FindBugs scariest for replaceFirst() method call that does not assign the return value
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:44 +01:00