apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-11-02 20:02:29 +01:00
Code Issues Packages Projects Releases Wiki Activity
27,604 Commits 307 Branches 324 Tags
Commit Graph

537 Commits

Author SHA1 Message Date
Daan Hoogland
b272d7717e Revert "Fix 2 findbugs high priority warnings" 
This reverts commit 1ca74dac269faa890c830ccde67c5007ef2e3c45.
 2015-06-08 10:01:19 +02:00
Rafael da Fonseca
e8c7069f73 Fix findbugs high priority warning VmwareStorageManagerImpl.java:1023, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE, Priority: High Redundant nullcheck of datastoreVolumePath, which is known to be non-null in com.cloud.hypervisor.vmware.manager.VmwareStorageManagerImpl.getVolumePathInDatastore(DatastoreMO, String) 
Assertion is not used in runtime, correct way is throw and handle exception without killing app

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #362
 2015-06-08 09:40:50 +02:00
Rafael da Fonseca
38c269d71e Fix performance issue reported by findbugs (unnescessary boxing/unboxing) VmwareResource.java:693, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High VmwareResource.java:4769, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.hypervisor.vmware.resource.VmwareResource.getNetworkStats(String) 
Now op is faster and takes up less memory

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #365
 2015-06-08 09:32:52 +02:00
Rafael da Fonseca
1ca74dac26 Fix 2 findbugs high priority warnings 
VmwareResource.java:315, MS_SHOULD_BE_FINAL, Priority: High
com.cloud.hypervisor.vmware.resource.VmwareResource.s_serviceContext isn't final but should be

VmwareResource.java:331, MS_SHOULD_BE_FINAL, Priority: High
com.cloud.hypervisor.vmware.resource.VmwareResource.s_powerStatesTable isn't final but should be

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #363
 2015-06-08 09:24:07 +02:00
Likitha Shetty
04365601da CLOUDSTACK-8412. VM migration with storage fails. 
Update MigrateWithStorageCommand to avoid JSON deserialization error.
 2015-04-28 10:22:00 +05:30
Likitha Shetty
f45e6b94ed CLOUDSTACK-8405: Restore VM results in deletion of data disk. 
Dont evict template when a delete command has been sent to VMware resource for deletion of volume.
 2015-04-27 16:37:46 +05:30
Rohit Yadav
06e353e5c7 vmware: support vmfs as local storage pool type 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 752d784d92b4ce461ec6a19a6b54220bb967d4d0)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-04-16 17:36:52 +05:30
Rohit Yadav
7949d2922d vmware: plugin improvements 
- use sticky chmod 1777 on the mountpoint
- remove dead code

(cherry picked from commit eea716b7916c916442b19d14e0f6e5c57bebb91e)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-04-13 15:49:01 +05:30
Rohit Yadav
37820e15f2 CLOUDSTACK-7593: allow nic type to be fetched from vm's details 
(cherry picked from commit 43db75c319b425f3b39770d556df59333921bf92)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Conflicts:
	engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
 2015-04-13 15:47:03 +05:30
Daan Hoogland
6a821730ce Boolean -> boolean 2015-03-25 22:20:40 +01:00
Daan Hoogland
048212b117 findbugs: Boolen function should not return null 2015-03-25 21:46:47 +01:00
Rajani Karuturi
843f6b1691 CLOUDSTACK-5236 : ability to identify where the user is from (ex. LDAP) 
Added a source column to the user table.

Source now has only two values UNKNOWN,LDAP with UNKNOWN being the
default and is an enum is com.cloud.User.

When the source is UNKNOWN, the old method of authenticating against all
the available authenticators is used. If a source is available, only
that particular authenticator will be used.

added overloaded methods in AccountService to createUserAccount and
createUser with source specified.

(cherry picked from commit 5da733072e838c830720909ef5ba27ef6ce6d0b0)
 2015-03-16 14:53:53 +05:30
Sanjay Tripathi
3d411dc616 Fixed simulator and vmware NPE issue. 2015-03-13 14:59:34 +05:30
Likitha Shetty
bdd28a45ed CLOUDSTACK-8319. For both 'MigrateVolume' and 'MigrateVMWithVolumes, ensure VM's vconfiguration files are migrated along with VM's root volume. 2015-03-12 11:57:02 +05:30
Likitha Shetty
adc836cc5e CLOUDSTACK-8318. Storage vMotion support for VMFS. 
MigrateVMWithVolumes-
1. If ESXi host version is below 5.1, ensure destination datastore(s) is mounted on the source host, then migrate the storage and then finally migrate the VM.
If destination storage(s) is not mounted on the source host,
- In case of NFS storage mount the storage(s).
- In case of VMFS storage fail the request for migration.
2. If EXi host version is 5.1 or above, simultaneously migrate the VM and its storage to the destination host and storage(s) respectively for both NFS and VMFS storage.
 2015-03-12 11:57:01 +05:30
punith-cloudbyte
ff7ef985f1 NFS support for VMware-managed storage 
Signed-off-by: Mike Tutkowski <mike.tutkowski@solidfire.com>
 2015-03-05 17:39:10 -07:00
Likitha Shetty
25a4f0dc53 CLOUDSTACK-8136. [VMware] Create VM snapshot fails if a previous attempt to take the snapshot failed. 
While looking for an ongoing VM snapshot task, check the task status to identify if the task is still running.
 2014-12-30 14:19:48 +05:30
Likitha Shetty
13bdc1cef4 CLOUDSTACK-8134. Worker VMs don't have MS id set in vCenter annotation 'cloud.vm.workertag'. 
Correctly register node info for a newly created VMware context.
 2014-12-30 11:52:56 +05:30
Likitha Shetty
15b348632d CLOUDSTACK-8129. Cold migration of VM across VMware DCs leaves the VM behind in the source host. 
If VM has been cold migrated across different VMware DCs, then unregister the VM from source host.
 2014-12-26 11:07:30 +05:30
Likitha Shetty
5227ae2275 CLOUDSTACK-8128. VM with Datadisk fails to start when storage is put into maintenance. 
While migrating a volume from primary to seocndary use a worker VM to perform the operations if the VM associated with the volume is stopped.
 2014-12-24 16:57:37 +05:30
Likitha Shetty
974b0180dd CLOUDSTACK-8126. Cold Migration of VM is not working as expected. In case a VM is cold migrated across clusters then VM fails to start. 
1. If a VM by the same name exists on a different cluster in the VMware DC, unregister the existing VM and continue with the VM start.
2. If VM start succeeds, delete VM files associated with the unregistered VM.
3. If VM start fails, re-register the unregistered VM.
 2014-12-24 15:07:08 +05:30
Likitha Shetty
1c0bf32170 CLOUDSTACK-8123. VM re-install fails. 
While moving root disk into VM folder during restore, look for folder based on vCenter name.
 2014-12-24 14:01:20 +05:30
Likitha Shetty
ac491c9607 CLOUDSTACK-8121. Data disk properties are not updated upon Creation/Deletion of VM snapshots. 
Update the path and size of data volumes after snapshot creation/deletion by correctly trimming only the snapshot postfix of a disk.
 2014-12-24 13:04:12 +05:30
Likitha Shetty
4d7ede535d CLOUDSTACK-8119. Propagate error message to UI for attach/detach volume failure operations. 
For AttachVolume/DetachVolume API command, improve user error message in case of RuntimeException by throwing the exception instead of 'Unexpected Exception'.
 2014-12-24 11:29:03 +05:30
Likitha Shetty
ddcae8a930 CLOUDSTACK-8118. Root volume migration fails with 'No such disk device' in case of vCenter 5.5 setup. 
If an exact match is being done while locating disk chain by name, don't trim snapshot postfix appended to the disk name.
 2014-12-24 10:19:22 +05:30
Likitha Shetty
cb211f18d1 CLOUDSTACK-8113. VM migration fails with "Message: No such disk device: " error. 
Consolidate VM disks once VM/volumes are migrated.
 2014-12-23 14:28:17 +05:30
Likitha Shetty
33179cce56 CLOUDSTACK-8112. CS allows creation of VM's with the same Display name when vm.instancename.flag is set to true. 
Before registering a VM check if a different CS VM with same name exists in vCenter.
 2014-12-23 13:48:01 +05:30
Likitha Shetty
647532376f CLOUDSTACK-8111. NFS secondary storage repetitively mounted on CS server with ESXi hypervisors. 
Fix cleanup of NFS mounts on management server during server starup by correcting how mount points are listed for a management server.
 2014-12-23 13:23:43 +05:30
Likitha Shetty
51ee90074d CLOUDSTACK-8110. VM name in vCenter should be VM's DisplayName if global config 'vm.instancename.flag' is set. 2014-12-23 11:42:26 +05:30
Likitha Shetty
507d9d337d CLOUDSTACK-8109. Extract Template is failing. 
Fix the OVA path that is returned once an OVA is packaged using a META file.
 2014-12-23 10:44:10 +05:30
Saksham Srivastava
1df0453d27 CLOUDSTACK-8088: VM scale up is failing in vmware with Unable to execute ScaleVmCommand due to java.lang.NullPointerException 2014-12-18 14:27:55 +05:30
Sateesh Chodapuneedi
aa84b05491 CLOUDSTACK-5933 Problem with VMware snapshot when datastore has a space in its name 
Handling spaces in datastore name while extracting vmdk base name

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
 2014-12-09 05:34:41 +05:30
Sateesh Chodapuneedi
bca015306e CLOUDSTACK-7803 Storage live migration of instance may not happen if instance has ISO attached. 
BUG-ID:CLOUDSTACK-7803
Summary:Ensure secondary storage is mounted on target host.
Reviewed-By:Rajesh

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
 2014-12-09 03:27:31 +05:30
Mike Tutkowski
3ac8f8d601 Fixing an issue related to figuring out the name of a datastore that is backed by managed storage 2014-12-08 14:26:31 -07:00
Harikrishna Patnala
9585aa0b51 CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings 
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
(cherry picked from commit eae733817b3670b0151410c027325f78013392ad)
 2014-11-25 15:55:54 +05:30
Laszlo Hornyak
3577423da9 removed executable flags from java classes 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-11-23 19:49:01 +01:00
Saksham Srivastava
4ff3130bec CLOUDSTACK-7950: AttachIsoCmd shoud give correct messge when trying to attach vmwaretools installer iso on non supported guestvm deployed by ISO 2014-11-20 13:04:14 +05:30
Santhosh Edukulla
ef6ec7b276 Fixed few coverity issues like invalid boxing unboxing issues, resource leaks, null dereferences 2014-11-13 17:26:24 +05:30
Likitha Shetty
b8fdda0a34 BUG-ID: CLOUDSTACK-7102. Volume migration fails with 'VM i-2-3-VM does not exist in VMware datacenter' expection. 
Look for a VM in vCenter based on both the vCenter name and CS internal name (required in case 'vm.instancename.flag' is enabled).
During Attach Volume and Volume Migration, for lookup and other operations use VM's name as obtained from vCenter instead of using the name set in the agent command.
 2014-11-13 12:58:56 +05:30
Bharat Kumar
ea99ff1c86 CLOUDSTACK-7763 Reservations for VMware VMs remain after dynamic scaling 2014-11-10 14:30:42 +05:30
Santhosh Edukulla
1aef5cba66 Fixed Coverity Issues 2014-11-03 16:45:30 +05:30
amoghvk
efc9632c1b CLOUDSTACK:6915 search including removed 2014-10-31 15:47:18 -07:00
Hugo Trippaers
4ebaf0a583 Bump master version to 4.6.0-SNAPSHOT after branching 4.5.0-SNAPSHOT 2014-10-29 14:54:23 +01:00
Mike Tutkowski
0cea0346ae Support for back-end snapshots on primary storage 2014-10-21 16:01:14 -06:00
Santhosh Edukulla
0a9742f914 Fixed few coverity issues 
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
 2014-10-14 17:16:50 +05:30
Frank Zhang
49c01e2ae4 Don't do chmod -R when mounting secondary storage for vmware 
It causes extreme long vm start time when managment server has slow connection to secondary storage
 2014-10-13 12:06:37 -07:00
Edison Su
d233f39c82 disable parallel for xenserver. Also for vmware, if full.clone is enabled and migratecommand will have the behavor of start/stop command 2014-10-09 17:14:57 -07:00
Edison Su
6a5e4306f2 fix build 2014-10-09 16:38:23 -07:00
Edison Su
15a2ea7c7e vmware resource code needs to honor the timeout value send 2014-10-09 16:28:20 -07:00
Nitin Mehta
9e7fbae52f Revert "CLOUDSTACK-7533: Wrong download URL is generated when using multiple SSVMs in a zone. The public ip of the url would sometime point to the wrong ssvm when the url was created on another one." 
This reverts commit f3b5a6ebc70d5bfb2c77b6aa359d7eb79b4507e5.
Reverting since a better fix is available with CLOUDSTACK-6478
 2014-10-06 15:00:32 -07:00