apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity
27,647 Commits 304 Branches 324 Tags
Commit Graph

27647 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rafael da Fonseca
a7a39a608c Remove unused imports to fix checkstyle warnings 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #413
 2015-06-15 12:09:17 +03:00
Rafael da Fonseca
96d6aaa293 Fix findbugs ClassCastException in UpgradeSystemVMCmd.java getDetails() isn't called anywhere in the code, either way, implementation is wrong since details is a Map<String, String> and not a Map<String, Map<String,String>> If this piece of could would get run, it would just fail trying to cast String to HashMap<String,String> in line 83 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-06-15 12:09:16 +03:00
Rafael da Fonseca
8634fe5cf5 Remove unused imports to fix checkstyle warnings 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #412
 2015-06-15 12:09:15 +03:00
Rafael da Fonseca
31a4f0ad6b Fix findbugs ClassCastException in ScaleSystemVMCmd.java getDetails() isn't called anywhere in the code, either way, implementation is wrong since details is a Map<String, String> and not a Map<String, Map<String,String>> If this piece of could would get run, it would just fail trying to cast String to Map<String,String> 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-06-15 12:09:14 +03:00
Rafael da Fonseca
85ad1b7e0f Fix 3 findbugs encoding warnings in VmwareStorageProcessor.java Ova templates and metadata should be written to file in UTF-8 Fix warning in UUID generation 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #411
 2015-06-15 12:09:13 +03:00
Rafael da Fonseca
ccd7d41ee3 Resolve findbugs encoding warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #392
 2015-06-15 12:07:55 +03:00
Rafael da Fonseca
980d858c34 Add import statements, remove unused FileReader import 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #393
 2015-06-15 12:07:49 +03:00
Rafael da Fonseca
9ad8c70baa Fix findbugs encoding warning, all .xml files contain only utf-8/us-ascii compatible characters 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-06-15 12:07:49 +03:00
Rafael da Fonseca
967da97f51 Fix 2 findbugs warnings in VmwareStorageManagerImpl.java Template files and metadata should be written to file in UTF-8 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #410
 2015-06-15 12:06:19 +03:00
Rafael da Fonseca
11fec86ba3 Fix 1 findbugs warning in VmwareResource.java 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #409
 2015-06-15 12:06:11 +03:00
Rafael da Fonseca
474065e98b Fix findbugs encoding warning in VmwareServerDiscoverer.java Input string should only contain safe characters, since it's derived from a Long object. This just gets rid of the findbugs warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #408
 2015-06-15 12:06:01 +03:00
Rafael da Fonseca
aa56faec51 Fix findbugs warning in VmwareHelper.java Disk descriptors should be written in UTF-8 for Vmware 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #407
 2015-06-15 12:05:38 +03:00
Rafael da Fonseca
dc64c7e843 Fix findbugs encoding warning ESX responses should be encoded in UTF-8 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #406
 2015-06-15 12:05:30 +03:00
Rafael da Fonseca
f03411ca04 Fix 2 findbugs encoding warnings in VmwareContext.java StreamReaders should use encoding specified in the connection object 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #405
 2015-06-15 12:05:16 +03:00
Rafael da Fonseca
00cdd66351 Fix 3 findbugs warnings OVF and VMX descriptor files should be written in UTF-8 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #404
 2015-06-15 12:05:08 +03:00
Rafael da Fonseca
333d0e2069 Fix 3 findbugs encoding warnings Vmdk descriptor files used by ESX should be UTF-8 encoded 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-06-15 12:05:08 +03:00
Rafael da Fonseca
f5f93884d1 Fix findbugs encoding warning Vmds files created by ESX are UTF-8 encoded 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #403
 2015-06-15 12:05:01 +03:00
Rafael da Fonseca
f8b364b7c7 Was safe either way as this piece of code should only run in linux, this just gets rid of the findbugs warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #402
 2015-06-15 12:04:47 +03:00
Rafael da Fonseca
3299f23ea2 Fix findbugs encoding warning in LibvirtCreatePrivateTemplateFromVolumeCommandWrapper Libvirt templates should be written in UTF-8, default was already doing that so this just gets rid of the findbugs warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #401
 2015-06-15 12:04:24 +03:00
Rafael da Fonseca
b869a16332 Remove unused import to fix checkstyle warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #400
 2015-06-15 12:04:19 +03:00
Rafael da Fonseca
949e97dec6 Fix findbugs warning in LibvirtConsoleProxyLoadCommandWrapper Encoding is now specified in both server and clients for the console proxy getstatus command For some reason, findbugs did not detect unsafe encoding issue in ConsoleProxyResource.java, is properly specified now though... CitrixConsoleProxyLoadCommandWrapper was specifying system default encoding for operation, should be ok because default for xenserver is UTF-8 since it's linux based, but it's best to specify exact encoding set on the server end to be consistent 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-06-15 12:04:18 +03:00
Rafael da Fonseca
509c83bc74 Fix findbugs encoding warning in JuniperSrxResource All .xml files contain only utf-8/us-ascii compatible characters. If special characters are added to these files in the future, UTF-8 should be used for cross platform compatibility 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #398
 2015-06-15 12:03:56 +03:00
Rafael da Fonseca
438c90d783 Fix findbugs encoding warning in HttpNfcLeaseMO VMWare ovf files are utf-8 encoded. Relying on default encoding in some platforms such as windows would cause erroneous characters from being read on some fields like description, and could also cause the import to fail, depending on the characters. 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #397
 2015-06-15 12:00:02 +03:00
Rafael da Fonseca
cc6d28fc98 Fix another findbugs encoding warning in CitrixResourceBase In this case, using default encoding is desired, since the purpose is to read shell command output, which uses the platform's default encoding. This gets rid of the findbugs warning. 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #396
 2015-06-15 11:59:48 +03:00
Rafael da Fonseca
faa38ad416 Fix findbugs encoding warning in CitrixResourceBase Output of text files should be UTF-8, this is the default for linux, will now always use the same format for every platform 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #395
 2015-06-15 11:59:38 +03:00
Rafael da Fonseca
aeccd8afdf Fix findbugs encoding issue This is done by calling HttpMethodBase's getResponseBodyAsString() which properly lookup the specified encoding in the request's Content-Type header This also avoids instantiation of two extra strings on the println() and return statements 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #394
 2015-06-15 11:59:09 +03:00
pritisarap12
019f246b35 CLOUDSTACK-8555: Skip volume resize operation for HyperV as it's not 
supported

Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #391
 2015-06-15 12:49:12 +05:30
Daan Hoogland
14d9c82369 findbugs: String to byt[] conversion 
decodeBase64() can work on String so the unsafe conversion is not needed

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #361
 2015-06-12 14:57:37 +03:00
Kishan Kavala
39d51bc021 CLOUDSTACK-5409: Include projectid during ACL check while listing S2S Vpn gateways 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #374
 2015-06-12 14:54:44 +03:00
Rajani Karuturi
4900d15e6c Merge branch 'CLOUDSTACK-8551' of https://github.com/karuturi/cloudstack 
This closes #388
 2015-06-12 15:53:08 +05:30
pritisarap12
fd1ef5220b CLOUDSTACK-8553: Unable to launch VM from template because of permission issue 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #387
 2015-06-12 11:54:23 +05:30
pritisarap12
09abb193a1 CLOUDSTACK-8550: Fixed cleanup issue related to VM 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #385
 2015-06-12 11:47:25 +05:30
Priti Sarap
f61723dcfb CLOUDSTACK-8547: Modify hypervisor check in testpath_snapshot_hardning.py 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #378
 2015-06-12 11:25:03 +05:30
Rajani Karuturi
d504305a98 Fixed CLOUDSTACK-8551 findbugs issue in LdapImportUsersCmd.java 
DM_DEFAULT_ENCODING issue. Used UTF-8
 2015-06-11 17:07:03 +05:30
Rajani Karuturi
d46b658ec0 Fixed CLOUDSTACK-8551 Findbugs warning in LdapCreateAccountCmd.java 
byte[].toString() would give reference to the array (ex: [B@6c521576 )
but not the original string.  used new String() to get the text.
 2015-06-11 14:05:03 +05:30
Ian Southam
7ba2f2274a Allow test to run on tiny linux templates using busybox 
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #381
 2015-06-10 22:00:54 +02:00
Sanjeev Neelarapu
de6538c9e7 SKIP vm migration tests on LXC since it is not a supported hypervisor 
This closes #383
 2015-06-10 17:29:18 +05:30
Gaurav Aradhye
54a664730d CLOUDSTACK-8515: Skipping snapshot test cases on HyperV and LXC 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #376
 2015-06-10 16:11:34 +05:30
Gaurav Aradhye
e3cfe89053 CLOUDSTACK-8546: Correcting skip test code in testpath_vMotion_vmware.py 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #377
 2015-06-10 16:04:10 +05:30
pritisarap12
84bc2e6127 CLOUDSTACK-8549: Update assert statements in testpath_disable_enable_zone.py 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #382
 2015-06-10 15:59:45 +05:30
Sateesh Chodapuneedi
5e41a830a5 This closes #373 
CLOUDSTACK-3317 - DVS does not support management\storage network

Added support for Management and Storage Network traffic over VMware DVS in CloudStack deployments. Also added support for storage VLAN over dvPortGroup.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>

CLOUDSTACK-3317 - DVS does not support management\storage network

Use non-zero dvport count while updating dvportgroups of system traffic.
Updated configuration compare logic to avoid update dvportgroup operation unless required.
This would help improve speed in vm/network deployment as the update calls would reduce. Also improved logging.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>

Adding unit tests in class HypervisorHostHelperTest

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>

Added license header to new file being added to repo/branch.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
 2015-06-10 02:07:40 +05:30
Sanjeev Neelarapu
8f1e0510cd Skipping all unsupported tests on LXC 
This closes #379
 2015-06-10 13:47:28 +05:30
Gaurav Aradhye
6140db50b3 CLOUDSTACK-8542: Correcting test case in test_vpc_on_host_maintenance.py 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #360
 2015-06-08 13:37:37 +05:30
Daan Hoogland
b272d7717e Revert "Fix 2 findbugs high priority warnings" 
This reverts commit 1ca74dac269faa890c830ccde67c5007ef2e3c45.
 2015-06-08 10:01:19 +02:00
Rafael da Fonseca
c5437d216f Fix malformed closing tag on comments in cisco .xml files 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #369
 2015-06-08 09:41:13 +02:00
Rafael da Fonseca
b9b13d764d Fix another case of unnecessary boxing JuniperSrxResource.java:1280, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.JuniperSrxResource.removeDestinationNatRules(Long, Map, List) 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #367
 2015-06-08 09:41:07 +02:00
Rafael da Fonseca
039d632ad3 Fix 3 more findbugs performance alerts, creating Long and Integer unnecessarily F5BigIpResource.java:297, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:703, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:889, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.F5BigIpResource 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #366
 2015-06-08 09:40:59 +02:00
Rafael da Fonseca
e8c7069f73 Fix findbugs high priority warning VmwareStorageManagerImpl.java:1023, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE, Priority: High Redundant nullcheck of datastoreVolumePath, which is known to be non-null in com.cloud.hypervisor.vmware.manager.VmwareStorageManagerImpl.getVolumePathInDatastore(DatastoreMO, String) 
Assertion is not used in runtime, correct way is throw and handle exception without killing app

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #362
 2015-06-08 09:40:50 +02:00
Rafael da Fonseca
9bac84a3f7 Fix last ocurrence of unnecessary boxing detected by findbugs CiscoVnmcResource.java:266, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.CiscoVnmcResource.getIpRangeFromCidr(String) 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #368
 2015-06-08 09:39:02 +02:00
Rafael da Fonseca
38c269d71e Fix performance issue reported by findbugs (unnescessary boxing/unboxing) VmwareResource.java:693, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High VmwareResource.java:4769, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.hypervisor.vmware.resource.VmwareResource.getNetworkStats(String) 
Now op is faster and takes up less memory

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #365
 2015-06-08 09:32:52 +02:00