Sanjay Tripathi
92a9ee097d
AsyncJob reports 'Successful' even if RevertToVMSnapshot operation fails.
...
This closes #484
2015-06-19 15:48:21 +05:30
Abhinandan Prateek
bcfb8240e1
CLOUDSTACK-8570:Exception in calculating reserved capacity for dynamic service offering
2015-06-19 09:30:33 +05:30
Daan Hoogland
b9dd67c383
CLOUDSTACK-8545 port of the fix to not reboot routers on out of band migration persé
2015-06-18 16:42:08 +02:00
Rafael da Fonseca
931cb95022
Fix 2 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warnings in ConfigurationManagerImpl.java
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #476
2015-06-18 13:37:39 +03:00
Rafael da Fonseca
b678b47793
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in ConfigurationServerImpl.java
...
Remove checkstyle reported trailing space
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #477
2015-06-18 13:36:44 +03:00
Rafael da Fonseca
5d258fa163
Fix 2 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warnings in DatabaseConfig.java
...
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
This closes #478
2015-06-18 14:36:26 +05:30
Daan Hoogland
f3afcb089f
CLOUDSTACK-8537 test for the sake of testing the fix seems so trivial but no testing is available for it at all. when bugs arise test extension should be the start point here.
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #357
2015-06-17 20:47:57 +02:00
Daan Hoogland
968e71ad0e
CLOUDSTACK-8537 refactor registerSSHKeyPair() for legibility and testability reasons
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-17 20:47:57 +02:00
Daan Hoogland
9f02531212
CLOUDSTACK-8537 add check for unique public key and account on ssh keypair registration
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-17 20:47:57 +02:00
Rafael da Fonseca
85afa63f24
Re-run travis
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #456
2015-06-17 12:18:01 +02:00
Rafael da Fonseca
b34ad4a22c
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in IpAddressManagerImpl.java Assert isn't used in prod runtime
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-17 12:18:00 +02:00
Rafael da Fonseca
ae328a6588
Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE warnings in BaseCmd.java Dateformat objects are not threadsafe and should be defined as instance variables Both INPUT_FORMAT and NEW_INPUT_FORMAT are only used in ParamProcessWorker.java and doesn't makes it more readable to declare in own class
...
Add missing import statement
Removed extraneous file
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #457
2015-06-15 16:32:30 +02:00
Rafael da Fonseca
34a791c295
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in UserVmJoinVO.java Assert isn't used in prod runtime
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #455
2015-06-15 12:28:05 +03:00
Rafael da Fonseca
7a57ce3334
Fix findbugs NS_DANGEROUS_NON_SHORT_CIRCUIT warning in NetworkServiceImpl.java
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #440
2015-06-15 12:10:10 +03:00
Rafael da Fonseca
1bd3286263
Fix 2 findbugs warnings in ApiResponseHelper.java ints were being boxed just to call .toString()
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #438
2015-06-15 12:10:04 +03:00
Rafael da Fonseca
ea7f4bd254
Fix findbugs warning in NetworkServiceImpl.java Integer was being boxed just to call toString()
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #437
2015-06-15 12:10:02 +03:00
Rafael da Fonseca
ec280189f4
Fix findbugs warning in ProjectManagerImpl.java Unnecessary boxing/unboxing of primitive value
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #434
2015-06-15 12:09:57 +03:00
Rafael da Fonseca
4d31ed9342
Fix findbugs warning in NetworkUsageManagerImpl.java Unnecessary boxing/unboxing of long value to create Date
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #433
2015-06-15 12:09:54 +03:00
Rafael da Fonseca
d7a27c9572
Fix 2 findbugs warnings in NetworkServiceImpl.java Unnecessary boxing/unboxing of int values
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #432
2015-06-15 12:09:53 +03:00
Rafael da Fonseca
e831fce1b9
Fix findbugs warning in CloudZonesStartupProcessor.java Unnecessary boxing/unboxing of primitive value
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #431
2015-06-15 12:09:50 +03:00
Rafael da Fonseca
62e78cdea0
Fix findbugs warning in ApiDispatcher.java Unnecessary boxing/unboxing of long value
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #430
2015-06-15 12:09:48 +03:00
Daan Hoogland
14d9c82369
findbugs: String to byt[] conversion
...
decodeBase64() can work on String so the unsafe conversion is not needed
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #361
2015-06-12 14:57:37 +03:00
Kishan Kavala
39d51bc021
CLOUDSTACK-5409: Include projectid during ACL check while listing S2S Vpn gateways
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #374
2015-06-12 14:54:44 +03:00
Rafael da Fonseca
00884b3b0b
Fixes LB certificate tests failure when the full path has a special character like whitespace or many others.
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #336
2015-06-04 00:11:09 +02:00
Rafael da Fonseca
bec44bffb3
Upgrade Reflections to 0.9.9
...
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
This closes #333
2015-06-03 11:01:32 +05:30
Rafael da Fonseca
82847d4405
Change tests random number generator to /dev/urandom
...
This fixes a big performance issue with random number generation with more recent kernels and java versions in linux
2015-05-29 20:24:41 +02:00
Jayapal
6e96fc6f38
CLOUDSTACK-8324: Updated import and added ResourceWrapper annotation
2015-05-28 15:56:37 +05:30
Jayapal
69ea932897
CLOUDSTACK-8324: Config drive changes for xenserver
2015-05-28 15:51:50 +05:30
Jayapal
e407986183
CLOUDSTACK-8324: Added config drive support for xenserver
2015-05-28 15:51:50 +05:30
Jayapal
7984ae5283
CLOUDSTACK-8324: Resource base changes for vm ip fetch
2015-05-28 15:42:08 +05:30
Jayapal
733ac2b728
CLOUDSTACK-8324: Added vm ip fetch logic
2015-05-28 15:42:08 +05:30
Jayapal
70934e8c1a
CLOUDSTACK-8324: Skip ip allocation for external dhcp
2015-05-28 15:42:07 +05:30
Jayapal
599125499b
CLOUDSTACK-8324: shared network without any service
2015-05-28 15:42:07 +05:30
Daan Hoogland
bbebd2d314
CLOUDSTACK-8506 extra check on unknown vlan
...
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
This closes #306
2015-05-27 14:39:16 +02:00
wilderrodrigues
75463356fb
CLOUDSTACK-8506
...
Removing the previous logic and adding a method to check if the CIDR is 31 bit prefixed
Adding tests for the new method
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #303
2015-05-26 12:10:00 +02:00
Rohit Yadav
e5d3084526
CLOUDSTACK-8339: Allow non-root users to add KVM host
...
This allows non-root users to add KVM hosts, the user should be an admin or
added to sudoers to execute sudo cloudstack-setup-agent.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Remi Bergsma <apache@remi.nl>
This closes #288
(cherry picked from commit d2b0c1a32b2d8719eafd6d4574de9a824d46d290)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-25 14:36:29 +02:00
Milamber
87d4086a64
CLOUDSTACK-6181 Specify GB for the value of rootdisksize parameter. Add some Bytes/GB for log or exception messages. Fix Gb->GB.
2015-05-23 17:52:21 +01:00
wilderrodrigues
44057a0f0f
Merge branch 'improvement/RFC_3021_31_Bit_Prefixes' of https://github.com/schubergphilis/cloudstack into rfc_3021
...
Testing PR #292
2015-05-23 10:10:13 +02:00
wilderrodrigues
a83f74d83e
CLOUDSTACK-8506
...
- Changing the implementation of the NetUtils.ipRangesOverlap() a little bit in order to be compliant with RFC 3021
- 2 unit tests added
- ranges from 0 to 255 covered by the tests, which also test the negative cases.
2015-05-22 20:08:09 +02:00
Rohit Yadav
cd55413c6a
CLOUDSTACK-8243: KVM agent should not use hardcoded string tails
...
For KVM agent, guid is configurable in agent.properties, this fix allows the
configuration to work by removing string tail (the -LibvirtComputingResource suffix).
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #286
(cherry picked from commit 803b946c2feae193d04219d2360c6d4440f212f1)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-22 18:12:10 +01:00
Rohit Yadav
1c81b241e7
CLOUDSTACK-8505: Don't allow non-POST requests for default login API
...
We add a new contract to pass Http request to authentication plugin system. In
the default login API, we disallow non-POST requests.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 9e9b231672e934292f9940d1363039a553fc7ad9)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
api/src/org/apache/cloudstack/api/auth/APIAuthenticator.java
plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/GetServiceProviderMetaDataCmd.java
plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LogoutAPIAuthenticatorCmd.java
plugins/user-authenticators/saml2/test/org/apache/cloudstack/api/command/GetServiceProviderMetaDataCmdTest.java
plugins/user-authenticators/saml2/test/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmdTest.java
plugins/user-authenticators/saml2/test/org/apache/cloudstack/api/command/SAML2LogoutAPIAuthenticatorCmdTest.java
server/src/com/cloud/api/ApiServlet.java
server/src/com/cloud/api/auth/DefaultLoginAPIAuthenticatorCmd.java
server/src/com/cloud/api/auth/DefaultLogoutAPIAuthenticatorCmd.java
server/test/com/cloud/api/ApiServletTest.java
2015-05-22 11:44:34 +01:00
Koushik Das
1cd2e9bc44
Merge branch 'CLOUDSTACK-8301' of https://github.com/apache/cloudstack
2015-05-22 09:47:59 +05:30
Rene Moser
c43e4db4e0
ListFirewallEgressRulesCmd: add interfaces and minor cleanup
...
This commit does not implement new functionality:
* Fixes duplicate parameter in API docs.
* Fixes a bunch of typos.
* Add interfaces to make it easier for the FirewallService interface.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #249
2015-05-20 17:00:08 +01:00
Koushik Das
d423df66cc
CLOUDSTACK-8301: Enable configuring local storage use for system VMs at zone level
...
Code cleanup, added helper method to get default system offering based on "system.vm.use.local.storage".
2015-05-19 21:32:14 +05:30
Koushik Das
3f7e31ed05
CLOUDSTACK-8301: Enable configuring local storage use for system VMs at zone level
...
Made system.vm.use.local.storage a zone level configuration.
2015-05-19 21:32:14 +05:30
Devdeep Singh
a99c9d0e68
Implementation for the ability to disable a storage pool for provisioning
...
... of new volumes. Following changes are implemented 1. Disable or enable a pool with the
updateStoragePool api. A new 'enabled' parameter added for the same. 2. When a
pool is disabled the state of the pool is updated to 'Disabled' in the db. On
enabling it is updated back to 'Up'. Alert is raised when a pool is disabled or
enabled. 3. Updated other storage providers to also honour the disabled state.
4. A disabled pool is skipped by allocators for provisioing of new volumes. 5.
Since the allocators skip a disabled pool for provisioning of volumes, the
volumes are also not listed as a destination for volume migration.
FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Disabling+Storage+Pool+for+Provisioning
This closes #257
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-19 11:16:49 +01:00
Mike Tutkowski
ac2bccd2a2
Removing unused imports
2015-05-07 13:52:25 -06:00
Daan Hoogland
1c408dec37
Merge branch '4.5' after 4.5.1 vote passes
2015-05-07 16:03:26 +02:00
Rohit Yadav
4ba72a877c
Updating pom.xml version numbers for release 4.5.2-SNAPSHOT
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-07 15:33:01 +02:00
Rohit Yadav
069aa4e5f3
CLOUDSTACK-8433: remove awsapi db usage and add upgrade cleanup path
...
- Removes awsapi db properties usage across codebase
- Removes references from spring xmls, test cases and TransactionLegacy
- Adds sql command to drop database cloudbridge in schema-451to460-cleanup.sql
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-06 15:22:04 +02:00