apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity
25,401 Commits 304 Branches 324 Tags
Commit Graph

279 Commits

Author SHA1 Message Date
Koushik Das
6378d37c5e CLOUDSTACK-8425: Job framework: Same internal job can execute simultaneously 
The same internal job was simultaneously getting executed by 2 worked threads.
The fix is to ensure that job gets scheduled for execution from a single place.

(cherry picked from commit 6dfb8ab03ed05747941a89b4079ff23d25f4d8fd)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-04-29 16:50:40 +02:00
Santhosh Edukulla
86943da26e Fixed few coverity issues 
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
(cherry picked from commit 0a9742f91462867cc9d5f9321a13a73483fcf149)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-04-27 14:43:48 +02:00
Rohit Yadav
6c5cf04d62 CLOUDSTACK-8372: Encrypt key column when saving key in keystore table 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-04-08 14:35:17 +05:30
Jayapal
32fe64ce1b Avoid logging password when adding srx device 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-03-13 15:01:06 +05:30
Rohit Yadav
cfd4573335 engine: Add Upgrade path from 4.5.0 to 4.5.1 
Encrypts:
- Remote access vpn preshared key
- StoragePool's user info
- Keystore's key

This closes #112

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-03-12 12:13:28 +05:30
Rohit Yadav
c198dfdb7a Update pom and version usage to 4.5.1-SNAPSHOT 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-03-12 12:13:18 +05:30
Rohit Yadav
68b5440d44 fix NPE cases, throw exceptions early on 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-02-05 17:44:32 +05:30
Rohit Yadav
46cd98b163 jobs: fix corner cases, add NPE checks 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-02-05 16:20:47 +05:30
Santhosh Edukulla
bd190192b9 Fixed Resource Leaks 
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
(cherry picked from commit 350ac4c4b0e71156ed27307b2d625f46453500a2)

Conflicts:
	engine/schema/src/com/cloud/upgrade/dao/Upgrade441to450.java
 2015-02-05 13:47:22 +05:30
Santhosh Edukulla
737edd90dc Fixed few coverity patches 
NPE in delete firewall rules observed, cherry-picking fix from master.

(cherry picked from commit 31a42d2b7a5a9d3dbf10dc680d7e8877ed4e40c6)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-02-02 12:48:38 +05:30
Rohit Yadav
bf88be5b25 Revert "CLOUDSTACK-8011: Upgrade maven dependencies" 
This reverts commit 482815d084e549b4cf8ba893d7c5174092e33437.
 2014-12-04 19:47:23 +05:30
Rohit Yadav
482815d084 CLOUDSTACK-8011: Upgrade maven dependencies 
Changes;
- Upgrades maven-war plugin to 4.5 (faster war packaging)
- Upgrade spring framework to latest minor release
- Upgrade ehcache, jasypt, httpclient, httpcore and other core dependencies
- Upgrade to latest ipv6 library, fix unit test NetUtilsTest
- httpcore and httpclient are sharing same version variable
- commons-httpclient is different that httpclient, the fix gives it a separate var
- Apidocs failed to generate and get stuck with new reflections version, for now
  we will continue using 0.9.8

Newer dependencies can be listed using:
mvn versions:display-dependency-updates -Dnoredist -Dsimulator -P developer,systemvm

Testing;
- Tested using Maven 3.2.1
- Local noredist build with unit tests succeeds
- CloudStack mgmt server started, basic business layer tests work
- Observed 10-15% build time improvement using new maven-war plugin

Branch: bugfix/4.5-8011 (commits are squashed in favour of a linear history)

Pull request:
https://github.com/apache/cloudstack/pull/50

This closes #50

TravisCI build summary:
https://travis-ci.org/shapeblue/cloudstack/builds/42902172

- Build passes with unit tests
- Apidocs generates successfully
- Most integration tests pass, some fail due to timeout errors, second re-run
  passes some of them

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit fac7bfc5d503aa25a82a684f7ec545197d255fb2)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Conflicts:
	pom.xml
 2014-12-04 02:14:54 +05:30
Edison Su
d856a2acad CLOUDSTACK-7946: 
remove leftover state in volume and snapshot table in case of mgt server
shutdown during storage operation.
Reviewed-by: Min
 2014-11-19 16:08:27 -08:00
Min Chen
0c45c96ec7 CLOUDSTACK-7864: CPVM continues to be in Stopped state after a failure to start because of a management server restart. Added optimization to purge queue items for cancelled jobs. 2014-11-11 11:11:18 -08:00
Min Chen
f2cedda9ef CLOUDSTACK-7884: Cloudstack MS is not responding (happening randomly) after some restart. 2014-11-11 09:19:21 -08:00
Damodar
cdabb2407a CLOUDSTACK-7843: sync Job Failures always reported as success on Event Bus 2014-11-10 15:07:13 +05:30
Min Chen
3a2f6ffd49 CLOUDSTACK-7864: CPVM continues to be in Stopped state after a failure to start because of a management server restart. 2014-11-07 16:37:05 -08:00
Rajani Karuturi
c3e5964dcb Fixed CLOUDSTACK-7242: Adding a securing config using configDepo doesnt work 
In ConfigurationVo, changed the setter to do the encryption if required
like the getter. Called the setter in constructor as well.

Removed references of encryption check in different places.

Reviewed-by: Santhosh Edukulla

This closes #35
 2014-11-05 11:49:38 +05:30
Min Chen
07ba078ee6 CLOUDSTACK-7833: VM Async work jobs log "Was unable to find lock for the key vm_instance" errors as warning 2014-11-03 11:19:06 -08:00
Min Chen
6830cbc15a CLOUDSTACK-7832: Move some job db update and item purge to 
completeAsyncJob transaction to avoid MySQL deadlock.
 2014-11-03 11:18:52 -08:00
Min Chen
dbf12d58e7 CLOUDSTACK-7749: AsyncJob GC thread cannot purge queue items that have been blocking for too long if exception is thrown in expunging some unfinished or completed old jobs, this will make some future jobs stuck. 2014-10-17 10:55:38 -07:00
Hugo Trippaers
dba4a8c837 cleaning more conflicts 2014-10-13 00:19:20 -04:00
Min Chen
3ebf49ab28 CLOUDSTACK-7628:VM Worker job should be expunged one hour after 
completion instead of currently being expunged whenever cleanup task
thread is run.
(cherry picked from commit 4317a85e97643c681b98b3e58990ec2f22abedd8)
 2014-10-12 23:53:56 -04:00
Anthony Xu
d036168ecb cleaning up more conflicts 2014-10-12 23:52:53 -04:00
Anthony Xu
b4bddc61ac timeInSeconds * 1000 
timeInSeconds is int type, if timeInSeconds is very big, it makes "timeInseconds * 1000" very small even 0

(cherry picked from commit f5eae55abb4591109dd22c1ba9d25f0876ebe52f)
 2014-10-12 23:48:43 -04:00
Koushik Das
1b0618d39c CLOUDSTACK-7595: Config parameters "job.expire.minutes" and "job.cancel.threshold.minutes" incorrectly getting multiplied by a factor of 60 
Removed the unnecessary multiply factor for both the config parameters. Also removed the duplicate entries from Config.java as these are not required

(cherry picked from commit a6ee4112a54043033233334c900d9bcd1cebf157)
 2014-10-12 23:43:01 -04:00
Min Chen
b979c6f0c7 CLOUDSTACK-7589: VM not Starting and always stuck in Stopped state after 
management server restarts.

(cherry picked from commit 7cdb67dcf1ec4158ec0ab4c2fa868cc63121bbb5)
 2014-10-12 23:40:07 -04:00
Anthony Xu
e5a91e40dd in tagCommand, AsyncJobExecutionContext doesn't need to be created if it doesn't exist 2014-09-17 18:15:41 -07:00
Min Chen
a2d85c8cae CLOUDSTACK-7566:Many jobs getting stuck in pending state and cloud is 
unusable.
 2014-09-16 15:14:08 -07:00
Harikrishna Patnala
5d389b1a71 CLOUDSTACK-5992: default values of configuraiton parameters in configuration table are set NULL on fresh setup Some configuration parameters have Component names different from fresh and upgrade setup 
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
 2014-09-05 14:59:33 +05:30
Hugo Trippaers
dc3f0cbc63 Improve the handling of the findbug exclude files 2014-09-03 10:41:22 +02:00
Santhosh Edukulla
4a6560a9ee Fixed few coverity defects 2014-08-21 12:43:11 +05:30
Anthony Xu
90fe6d8087 removed trailing space 2014-08-13 11:09:38 -07:00
Santhosh Edukulla
0ca3b4a4e4 Fixed coverity reported concurrency issue 
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
 2014-08-06 10:15:39 +05:30
Alena Prokharchyk
ffeca8bbd2 CLOUDSTACK-7209: handle the case when network fails to implement NoTransitionException, and null is returned to the caller stack. All caller methods should verify if the return value is null before processing it further. 2014-08-01 09:47:28 -07:00
Min Chen
3b32732459 CLOUDSTACK-7162:queryAsyncJobResult api does not return jobinstanceid. 2014-07-22 09:47:59 -07:00
Nitin Mehta
77dadd75c4 CLOUDSTACK-6787: Publishing uuids missing in some cases, adding/correcting events in some cases. 
Also fixed a bug in the global config framework.
 2014-07-21 14:08:18 -07:00
Kishan Kavala
b8ddbe8ffa CLOUDSTACK-6239: Encrypt security related config values before inserting into DB 2014-07-21 14:49:07 +05:30
Koushik Das
aacf8ef77b Findbugs fixes in cloud-utils project and a few other places 2014-07-15 14:23:17 +05:30
Anthony Xu
388210c8f9 Add more logs for MS cluster manager 2014-07-11 17:39:40 -07:00
Santhosh Edukulla
1f3d02b38a Reverting the changes done to this file for coverity fixes 2014-07-10 23:35:27 +05:30
Koushik Das
61fe959bb4 Removed invalid assertions from code. Now the MS can be run with assertions enabled (using -ea flag) 2014-07-10 12:18:29 +05:30
Santhosh Edukulla
d51e8f44ae CLOUDSTACK-7079: Fixed the issue where rollback was called after commit. As well, added few null checks 2014-07-09 15:58:43 +05:30
Likitha Shetty
4f969057b2 CLOUDSTACK-7030. After the restart of MS in a clustered MS pool, not all hung worker VMs are recycled. 
Recycle worker VMs that originally belonged to other management servers too because in case of MS restart, the owner MS might change.
 2014-07-07 13:38:47 +05:30
Santhosh Edukulla
a600d8408e Fixed Resource Leaks, null dereferences, few other issues reported by coverity 2014-07-04 16:17:58 +05:30
Santhosh Edukulla
b2283d7a28 Fixed few resource leaks and added secstoragefirewallcfg command support to simulator 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2014-06-24 23:19:47 +02:00
Santhosh Edukulla
1c80185170 Fixed Resource Leaks, null dereferences, invalid value comparisons, invalid result set loop 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2014-06-21 12:38:46 +02:00
Hugo Trippaers
0c28f36ff1 Fix a number of resource leaks reported by Coverity 2014-06-13 14:42:35 +02:00
Min Chen
25580c7cd1 CLOUDSTACK-6859:Management Server PermGen run out of memory after some 
time due to class leak.
 2014-06-06 23:57:26 -07:00
Marcus Sorensen
20a31b43d6 CLOUDSTACK-6784: Expose data types via API so consumers of API can validate data 2014-05-27 15:23:23 -06:00