35413 Commits

Author SHA1 Message Date
Abhishek Kumar
78b68fd7e6
api,server: custom dns for guest network (#6425)
Adds option to provide custom DNS servers for isolated network, shared network and VPC tier.
New API parameters added in createNetwork API along with the corresponding response parameters.

Doc PR: apache/cloudstack-documentation#276
2022-09-10 13:05:40 +05:30
Abhishek Kumar
cf18549dbb Merge remote-tracking branch 'apache/4.17' into main 2022-09-07 14:11:09 +05:30
Abhishek Kumar
d3bfdacffd
systemvm,vr: disable radvd for non-applicable VRs (#6706)
Fixes #6700

When VR is a DHCP server system VM type then stop radvd.
2022-09-07 13:42:57 +05:30
David Jumani
f342cf300e
ui: Fix netowrkid not passed in deployvm (#6711)
Fixes the issue of the networkid not being passed when deploying a VM
This is caused when the first template selected is a deploy-as-is one and the nicToNetworkSelection not being reset when selecting a new template
2022-09-07 12:25:23 +05:30
Wei Zhou
fe16be0408
UI: fix bulk delete project with cleanup (#6708) 2022-09-07 11:13:45 +05:30
Abhishek Kumar
687a21c116 Merge remote-tracking branch 'apache/4.17' into main 2022-09-06 18:47:47 +05:30
Abhishek Kumar
b831f23f5f
kvm: add libvirt host capabilities method for cpu speed retrieval (#6696)
Fixes #6680

While finding CPU speed for KVM host following methods will be used in the same order:
1. lscpu
2. value in /sys/devices/system/cpu/cpu0/cpufreq/base_frequency
3. virsh capabilities
4. libvirt nodeinfo

This will allow correct value for AMD based hosts when first two methods doesn't give a value
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-09-06 16:45:05 +05:30
Abhishek Kumar
f18eebf2e9
server: fix check for ipv6 range overlap (#6705)
Fixes incorrect check for verifying IPv6 ranges overlap. This causes the inability to add multiple IPv6 ranges.
2022-09-06 16:43:20 +05:30
Abhishek Kumar
1d20fcfc6e
ui: fix set reservation toggle in add public ip range (#6707)
Fixes 'Set reservation' toggle not getting updated on value change.
2022-09-06 14:05:01 +05:30
Daniel Augusto Veronezi Salvador
e76df16d9f
Ignore opensaml dependencies (#6693)
Commit f27de63 introduced a new version of opensaml. That version brought jcl-over-slf4j-1.7.5.jar, jul-to-slf4j-1.7.5.jar, and log4j-over-slf4j-1.7.5.jar as dependencies, which causes Agents and Usages to not generate logs.
In order to make the logs to work again, this PR intends to exclude these dependencies while building the packages.
2022-09-05 17:38:45 +05:30
Abhishek Kumar
65c7070422 Merge remote-tracking branch 'apache/4.17' into main 2022-09-01 12:56:31 +05:30
Abhishek Kumar
c290cbcb71
server: fix scale vm with compute offering having same disk offering (#6688)
Fixes #6679

Fixes behaviour when the VM is scaled to a new compute offering which has the same disk offering associated as the earlier compute offering.
2022-09-01 12:28:39 +05:30
Bryan Lima
c58118148e
Remove unsupported params from API calls on the UI (#6686) 2022-08-31 15:34:25 +02:00
Abhishek Kumar
e720b72e15 Merge remote-tracking branch 'apache/4.17' into main 2022-08-31 17:38:30 +05:30
Abhishek Kumar
a21efe75df
vmware: fix vm snapshot with datastore cluster, drs (#6643)
Fixes #6595
Sync volume datastore, path and chaininfo info while calculating snapshot chain size after snapshot operation is complete from vCenter.
2022-08-31 16:00:14 +05:30
Bryan Lima
d4b8e2cbe8
Validate host tags on VM live scale (#6409)
* Validate host tags on VM live scale

* Remove extra spaces
2022-08-31 09:24:00 +02:00
Rohit Yadav
201f06697d Merge remote-tracking branch 'origin/4.17' 2022-08-30 12:52:59 +02:00
Hoang Nguyen
3170338d14
ui: remove incorrect API calls when initializing the deploy VM page (#6687) 2022-08-30 16:06:34 +05:30
José Flauzino
9f7e0cc2d5
VM stats history visualization (#6401)
* Add VM stats view feature

* Add dynamic label to the submit button of the VM stats filtering modal

* Improve CPU info message

* Reduce identation

* Remove missed line

* Fix timestamp when 'Use local timezone' is selected

* Fix bug when filtering for all data

* Support for toggle 'Use local timezone' button

Co-authored-by: joseflauzino <jose@scclouds.com.br>
Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
2022-08-29 13:42:03 +02:00
Abhishek Kumar
c526244359 Merge remote-tracking branch 'apache/4.17' into main 2022-08-26 14:22:14 +05:30
Abhishek Kumar
7115e35965
ui: fix update network update in sequence param (#6675)
Fixes wrong param used in the update network form
2022-08-26 14:21:13 +05:30
Abhishek Kumar
7ddebd3b2c
server: fix error when dedicating guest vlan range for physical nw without vlan range (#6655)
Fixes #6648
If any of the VLAN from the given range is not found in the database (cloud.op_dc_vnet_alloc) then an InvalidParameterValueException will be thrown.
Also, refactors and fixes account check.
2022-08-25 22:27:44 +05:30
Hoang Nguyen
c8494354ca
UI: Fixes suffix icon on project selector not work (#6671)
* fix the animation suffix icon of select

* move style code
2022-08-25 22:14:31 +05:30
Abhishek Kumar
f76b6c686d Merge remote-tracking branch 'apache/4.17' into main 2022-08-25 10:09:11 +05:30
Abhishek Kumar
cd37b135a0
vpc: prevent sourcenat ip disassociation for an active vpc (#6664)
Fixes #6663

Source NAT IP should not be disassociated from an active vpc
2022-08-24 13:23:01 +05:30
Rohit Yadav
ad0ae83974
ui: Revise Chinese language pack (#6653)
Co-authored-by: 卢苇 <lw_bk@163.com>
2022-08-22 17:08:34 +05:30
Abhishek Kumar
bd6bcffccc Merge remote-tracking branch 'apache/4.17' into main 2022-08-22 14:42:35 +05:30
Abhishek Kumar
814dbbaf86
cks: fix k8s cluster deployment with host tagged offering (#6658)
Fixes #6657

Fixes k8s cluster node VM deployment when the underlying hypervisor host has multiple host tags and the service offering used for the cluster deployment does not contain all of those host tags.
2022-08-22 14:39:36 +05:30
Pearl Dsilva
9847918360
api, vmware: allow VM setting/detail for disk controller (root/data) to override template details (#6276)
This PR allows VM details wrt root & data disk controller passed via details parameter of deployVMCmd to take precedence over template settings, i.e., the order of precedence for determining VM disk controller is : VM details passed during deployment > template settings > global setting vmware.root.disk.controller.
2022-08-22 13:27:07 +05:30
Abhishek Kumar
44e600e2fc
server: remove resource tags for disassociated public ip (#6642)
Fixes #6620
Remove resource tags when public IP is disassociated
2022-08-19 18:28:51 +05:30
Nicolas Vazquez
1fd1f0626a
Fix SQL query for uuid wrong format (#6654)
Fixes: #6652
2022-08-19 18:27:11 +05:30
Marcus Sorensen
f23a4db6d2
kvm: Add usermode interface option to Libvirt Domain XML builder (#6640)
This PR provides constructors and the associated changes to use LibvirtVMDef for creating user mode network interfaces.

While this isn't used directly in the CloudStack KVM agent today, it could be used in the future for e.g. pod networking/management networks without needing to assign a pod IP. The VIF driver used by the CloudStack Agent is also pluggable, so this allows plugin code to create user mode network interfaces as well.

Note that the user mode network already exists in the GuestNetType enum, but wasn't usable prior to this change.

Also included unit test to ensure we continue to create the expected XML.

Additionally, this uncovered a null pointer on _networkRateKBps and this PR fixes it. The decision to add bandwidth throttling assumes this field is not null and simply checks for > 0.

Signed-off-by: Marcus Sorensen <mls@apple.com>
Co-authored-by: Marcus Sorensen <mls@apple.com>
2022-08-18 13:14:50 +05:30
Rohit Yadav
83008e55cf Merge remote-tracking branch 'origin/4.17' 2022-08-17 16:25:25 +02:00
Abhishek Kumar
010b47f82e
server: fix ipv6 network deployment with separate guest nw (#6588)
Fixes #6584

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-08-17 15:49:01 +05:30
Abhishek Kumar
052a34c1fb
ui: fix resource tags visibility in infocard (#6650)
Fixes #6649

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-08-17 15:47:31 +05:30
Rohit Yadav
8e428c7b0c Merge remote-tracking branch 'origin/4.17' 2022-08-17 10:29:40 +02:00
Abhishek Kumar
547041646a
server: fix delete resource tag permission (#6634)
Fixes #6623
This PR fixes resource tag deletion behaviour. The permission check should be done only for the tags that are passed in the API call instead of checking for all the tags for the resource.
2022-08-17 11:57:44 +05:30
Abhishek Kumar
780bb2474c
ui: fix gputype in add compute offering (#6646)
Fixes gpuType value in the add compute offering form during submit
2022-08-17 11:53:22 +05:30
Abhishek Kumar
7ae6fdf053 Merge remote-tracking branch 'apache/4.17' into main 2022-08-16 17:51:09 +05:30
Hoang Nguyen
ef2997c4a8
ui: fix the warning in detail tab (#6645)
This PR for fixes the warning in detail tab
2022-08-16 16:41:19 +05:30
Abhishek Kumar
770df60bbe
vmware,cks: fix attachiso failure with vmware drs (#6625)
Fixes #4314

Failure in attaching k8s ISO is seen when VMware DRS is enabled. Log reported VM is not found. This fix tries to find VM on peer hosts when the VM is not found on the given host.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-08-16 16:17:13 +05:30
Suresh Kumar Anaparti
75da982d73
Updated resource counter to include correct size after volume creation/resize and other improvements (#6587)
* Updated resource counter to include correct size after volume creation/resize and other improvements
- Recalculate resource counters for root domain in the periodic task
- Update correct size in the primary_storage resource counter after volume creation/resize
- Some code improvements

* review and sonarcloud issues

Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>
Co-authored-by: Daan Hoogland <daan@onecht.net>
2022-08-16 10:41:42 +02:00
Abhishek Kumar
a5716d964a
ui: reset disksize param on offering change in scale vm (#6636)
Fixes #6627

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-08-16 11:44:32 +05:30
Rohit Yadav
152a274845
README: add codecov badge 2022-08-14 18:09:13 +05:30
Abhishek Kumar
d9b770eb48 Merge remote-tracking branch 'apache/4.17' into main 2022-08-12 23:44:42 +05:30
Gabriel Beims Bräscher
9410a70454
schema: increase size of column 'value' at table 'account_details' (#6080)
This PR increases the column value at table account_details from 255 chars to 4096, matching with the value allowed in the API command for updating the configuration of accounts.

When the value length is bigger than 255, the following log is presented right after the updateConfiguration API call:

2022-03-09 17:50:24,627 ERROR [c.c.a.ApiServer] (qtp30578394-234766:ctx-cad18b45 ctx-32e954dd) (logid:0948e203) unhandled exception executing api command: [Ljava.lang.String;@117c6ba7
com.cloud.utils.exception.CloudRuntimeException: DB Exception on: com.mysql.cj.jdbc.ClientPreparedStatement: INSERT INTO account_details (account_details.account_id, account_details.name, account_details.value) VALUES (123, _binary'api.allowed.source.cidr.list', _binary'<huge binary>')
	at com.cloud.utils.db.GenericDaoBase.persist(GenericDaoBase.java:1450)
	at jdk.internal.reflect.GeneratedMethodAccessor168.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	....
	....
	....
Caused by: com.mysql.cj.jdbc.exceptions.MysqlDataTruncation: Data truncation: Data too long for column 'value' at row 1
	at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:104)
	at com.mysql.cj.jdbc.ClientPreparedStatement.executeInternal(ClientPreparedStatement.java:953)
	at com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdateInternal(ClientPreparedStatement.java:1092)
	... 83 more


Co-authored-by: Bart Meyers <bart.meyers@cldin.eu>
2022-08-12 23:42:50 +05:30
Ruben Bosch
696b93f421
kvm: update host memory stats (#6622)
Fixes #6621

Each time getMemStat() is called, a static value is returned. This value
should instead be refreshed to return the actual memory used.

Co-authored-by: Ruben Bosch <ruben.bosch@cldin.eu>
2022-08-12 17:14:04 +05:30
Paula Oliveira
9717ed9af2
Improve log messages on VolumeOrchestrator class (#6408)
Co-authored-by: Paula Zomignani Oliveira <paula@scclouds.com.br>
2022-08-12 09:17:06 +02:00
Rohit Yadav
840c3f6a7a Merge remote-tracking branch 'origin/4.17' 2022-08-10 23:11:09 +02:00
Harikrishna
d3ec27dc79
Fixed Veeam listing restore points (#6555)
Fixes issue #6465 where listing backup restore points are failing with Veeam version v11.0.1.1261.

Though this version is not fully supported for backup and recovery, existing backups, restore points for the VMs can continue to work with the Veeam version v11.0.1.1261. I've created a separate ticket here to fully support the version #6554
2022-08-10 16:59:10 +05:30