1294 Commits

Author SHA1 Message Date
Santhosh Edukulla
dda2820552 Fixed Coverity reported type issues 2014-08-06 15:27:00 +05:30
Santhosh Edukulla
e4d6cd8e6a Fixed coverity reported concurrency issues
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-08-05 12:16:08 +05:30
Santhosh Edukulla
b7d3f1bd30 Fixed few coverity issues for resource synchronization 2014-08-04 16:09:26 +05:30
Alena Prokharchyk
685a58a843 CLOUDSTACK-7210: removed duplicated foreign key from async_job_join_map table 2014-08-01 10:48:36 -07:00
Alena Prokharchyk
ffeca8bbd2 CLOUDSTACK-7209: handle the case when network fails to implement NoTransitionException, and null is returned to the caller stack. All caller methods should verify if the return value is null before processing it further. 2014-08-01 09:47:28 -07:00
Saksham Srivastava
3d6c64d262 CLOUDSTACK-7206: Update vm_network_map table correctly 2014-08-01 13:58:06 +05:30
Rajesh Battala
88d4fe8a0b Fixed CLOUDSTACK-7091 VM VNC password should be securely generated 2014-08-01 13:09:27 +05:30
Nitin Mehta
e26855e284 CLOUDSTACK-6594: Improve the logging in the util functions utilized by db upgrades currently. If the exception is to be ignored, dont log the stack trace and also dont log it in warn. Making them debug just to be little verbose during upgrade scenario.
Correcting all the unit tests accordingly.
2014-07-31 16:36:33 -07:00
Santhosh Edukulla
a7e3861f5e Fixed Coverity Issues 2014-07-31 16:57:20 +05:30
Santhosh Edukulla
bd3d8286d3 Fixed a simple coverity issue 2014-07-31 16:00:42 +05:30
Santhosh Edukulla
45557cc020 Fixed Coverity Issues Reported 2014-07-31 15:44:41 +05:30
Sheng Yang
f47cfc6eb1 CLOUDSTACK-7186: Revert "CLOUDSTACK-7182: NPE while trying to deploy VMs in parallel in isolated network"
This reverts commit 47d6a64b319ab064c4b855346f2bfdb250fb9ad8, which broke VPC
completely.
2014-07-28 16:02:21 -07:00
Alena Prokharchyk
45c9f03e14 Added upgrade path from 4.4.1 to 4.5 2014-07-28 15:49:06 -07:00
Rohit Yadav
d42e20429d schema: add upgrade path from 4.4.0 to 4.5.0 via 4.4.1
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-07-29 00:21:39 +02:00
Alena Prokharchyk
9a94bc26fa DB upgrade - added a path from 4.4.0 to 4.4.5 2014-07-28 14:43:39 -07:00
Anthony Xu
330c4ba578 completed the new vmsync TODOs in the code.
removed old vmsync logic
2014-07-28 12:51:37 -07:00
Murali Reddy
67876b215e CLOUDSTACK-7191:On restartNetwork destroy the VR immediatley, instead of
cleanup the rules then destroy

fix adds a provision to specify if cleanup is needed on network on
shutdown. VR is marked as to not to require network rules clean up on
network shutdown as the VR is destroyed and recreated.

ran the simulator tests that test network life cycle
2014-07-28 17:09:42 +05:30
Santhosh Edukulla
8aeefdc130 Fixed Coverity Issues Reported 2014-07-25 16:46:20 +05:30
Santhosh Edukulla
7bbe7fc697 Fixed Coverity Issues Reported 2014-07-25 16:41:17 +05:30
Santhosh Edukulla
2018d7d977 Fixed Coverity Issues Reported 2014-07-25 16:39:16 +05:30
Santhosh Edukulla
3bb344281a Fixed Coverity issues Reported 2014-07-25 16:38:15 +05:30
Koushik Das
47d6a64b31 CLOUDSTACK-7182: NPE while trying to deploy VMs in parallel in isolated network
The following changes are made:
- Check to see if network is implemented changed from 'state == Implementing||Implemented' to 'state == Implemented'.
The earlier check was a hack to prevent the issue described below.
- At the time of implementing network (using implementNetwork() method), if the VR needs to be deployed then
it follows the same path of regular VM deployment. This leads to a nested call to implementNetwork() while
preparing VR nics. This flow creates issues in dealing with network state transitions. The original call
puts network in "Implementing" state and then the nested call again tries to put it into same state resulting
in issues. In order to avoid it, implementNetwork() call for VR is replaced with below code.
2014-07-25 15:17:35 +05:30
Hugo Trippaers
676b2d1569 Fix overflow before widening issues reported by Coverity 2014-07-24 13:22:14 +02:00
Hugo Trippaers
f275f293bb Fix CID 1114608 Store virtualsize in the the virtualsize column 2014-07-24 12:21:37 +02:00
Bharat Kumar
da55aff64f CLOUDSTACK-7158 listCapacity API missing types for certain zones 2014-07-24 14:33:51 +05:30
Saksham Srivastava
0f85e649b6 CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack 2014-07-24 10:45:51 +05:30
amoghvk
c804660c74 CLOUDSTACK-7168: Revert "Fixed Coverity Issues reported" that broke CI
This reverts commit 4523490d44160b054de9e943f72db1d0ce06054a.
2014-07-23 11:37:36 -07:00
Santhosh Edukulla
4523490d44 Fixed Coverity Issues reported
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-07-22 18:03:36 +05:30
Mike Tutkowski
b080eaf327 Updates to the way resizing a volume works 2014-07-17 21:09:19 -06:00
Edison Su
771b53b342 CLOUDSTACK-4725: if storage pool has different path, but the uuid is the same, then treat them as the same storage pool 2014-07-16 16:38:17 -07:00
Hugo Trippaers
e78bb1d225 Switch the catch to Throwable. Uncaught exceptions in a scheduled
threadpool executor will not report or log uncaught exceptions but will
kill the thread causing unexplained timeouts in CS.
2014-07-16 16:24:55 +02:00
Koushik Das
aacf8ef77b Findbugs fixes in cloud-utils project and a few other places 2014-07-15 14:23:17 +05:30
amoghvk
33d6bc278f Adding missing modified file 2014-07-14 17:42:27 -07:00
amoghvk
62e63a1bf7 CLOUDSTACK-6358: Missing patches in master for VMware 2014-07-14 16:54:10 -07:00
Amogh Vasekar
09069fcc87 CLOUDSTACK-6358: Add missing patches in master for KVM 2014-07-14 16:51:55 -07:00
amoghvk
6831ed4026 CLOUDSTACK-6358: Missing patches in master branch 2014-07-14 15:17:58 -07:00
Sanjay Tripathi
f275eb1ff9 CLOUDSTACK-7029: listCapacity fails when podid argument is specified. 2014-07-09 12:09:33 +05:30
Alena Prokharchyk
f4d2034755 CLOUDSTACK-7081: db upgrade fixes - a) added description for cloud.volumes.iso_id field b) removed duplicated unique key "id_2" from cloud.storage_pool table 2014-07-08 14:14:07 -07:00
Mike Tutkowski
62c18ca3fa Fixing an issue in the AbstractStoragePoolAllocator's filter method where zone-wide storage of HypervisorType.Any is skipped 2014-07-07 22:16:58 -06:00
Alena Prokharchyk
5a96d8ef5c CLOUDSTACK-7073: Added domainId field to the user table in order to restrict duplicated users creation on the db level 2014-07-07 16:21:38 -07:00
Likitha Shetty
8e112858d3 CLOUDSTACK-7071. Upgrade to CCP 4.2 fails in case a VMware setup has multiple zones mapping to the same VMware datacenter.
If 2 or more CloudStack zones map to the same VMware datacenter, mark the zones as legacy zones.
2014-07-07 16:38:56 +05:30
Santhosh Edukulla
a600d8408e Fixed Resource Leaks, null dereferences, few other issues reported by coverity 2014-07-04 16:17:58 +05:30
ynojima
1e72e5a818 CLOUDSTACK-6935 remove iSCSI storage filtering logic for Root volume
since there is no reason to filter it out
2014-07-01 19:57:19 -06:00
ynojima
32ed9d86ec Revert "Fixing an issue introduced with Review Request 22717"
This reverts commit 12e92e10ffbd9f86ebff11c2a1b22c5bafafb3d1.
2014-07-01 19:54:11 -06:00
Santhosh Edukulla
97d296bfbd Fixed Coverity reported performance issues like inefficient string concatenations, wrong boxing or unboxing types, inefficent map element retrievals
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-07-01 22:06:25 +02:00
Mike Tutkowski
12e92e10ff Fixing an issue introduced with Review Request 22717 2014-06-26 23:56:11 -06:00
Nitin Mehta
80ef915fd5 CLOUDSTACK-7000: ListSnapshotPolicy should list by policyid. Introduce updateSnapshotPolicy command
(cherry picked from commit fce21439facea267d958d8939059ba65afb3578a)
2014-06-26 11:38:41 -07:00
Hugo Trippaers
05b79a127a Fix the license headers Nitin forgot. 2014-06-25 16:07:00 +02:00
Hugo Trippaers
ab0dca0385 Catch possible exceptions in finally so they won't shadow the original exception. 2014-06-25 15:51:29 +02:00
Hugo Trippaers
cd0ef09344 Fix typo and add the right exception to the error map. 2014-06-25 15:51:28 +02:00