Rohit Yadav
f40e31e061
CLOUDSTACK-7563: Fix potential NPE in checking answer
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit d42e3df9cf43b0ad46d406c6ab5b1d8c811d0239)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-12-02 16:46:09 +05:30
Loic Lambiel
34e8483e80
CLOUDSTACK-7404: Failed to start an instance when originating template has been deleted
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
(cherry picked from commit c1bf7eeeeeb3bd4dad384225d411e21859cce470)
2014-12-01 13:04:34 +01:00
Laszlo Hornyak
3577423da9
removed executable flags from java classes
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-11-23 19:49:01 +01:00
Anthony Xu
02e22dba7d
CLOUDSTACK-7742:
...
root cause:
when vmsync reports system VM is down, CCP doesn't release the VM resource before starting it.
fix:
make sure cleanup is called for a VM when it is reported as Stopped
2014-11-19 16:30:56 -08:00
Edison Su
67113ff0b2
CLOUDSTACK-7946:
...
remove leftover state in volume and snapshot table in case of mgt server
shutdown during storage operation.
Reviewed-by: Min
2014-11-19 16:06:37 -08:00
Sanjay Tripathi
dda2994936
CLOUDSTACK-7940: Exception printed completely on the UI. Not in a readable format.
2014-11-19 15:59:03 +05:30
Kishan Kavala
4e896938ee
BUG-ID: CLOUDSTACK-5324 when router requires upgrade throw ResourceUnavailableException with scope VirtualRouter. API willl return generic Network Unavailable error.
...
Reviewed-By: Damoder
2014-11-19 09:46:56 +05:30
Devdeep Singh
cffae8eef0
CLOUDSTACK-6924. To attach a volume if a volume needs to be moved to another storage
...
pool, the source and destination pools cannot be local and cluster/zone and vice versa.
Cloudstack detects it and throws a exception. However, the end user only sees an
unexpected exception and not the reason for failure. Fixed it by making sure the
reason for the failure is correctly captured and shown to the end user.
2014-11-14 11:19:19 +05:30
Santhosh Edukulla
ef6ec7b276
Fixed few coverity issues like invalid boxing unboxing issues, resource leaks, null dereferences
2014-11-13 17:26:24 +05:30
Koushik Das
2685ed36cc
CLOUDSTACK-7880: Creating shared network results in exception
...
This is due to event publish being wrapped in a transaction, moved it outside of transaction scope.
2014-11-11 16:35:20 +05:30
Damodar
781648fb10
CLOUDSTACK-7792: Usage Events to be captured based on Volume State Machine
2014-11-10 15:19:02 +05:30
Nitin Mehta
a8b89bea4f
CLOUDSTACK-7870: When Vm deployments fail and end in error state volume count should be decremented
2014-11-09 23:01:28 -08:00
Koushik Das
49115e0333
CLOUDSTACK-7867: Delete network resulting in exception
...
Publish event was getting called from within a DB transaction which is not allowed.
2014-11-08 13:46:54 +05:30
Koushik Das
0327c2b13e
CLOUDSTACK-7421
...
Unnecessary exception in MS logs while removing default NIC from VM. Following changes are made:
1. Changed the exception from CloudRuntimeException to InvalidParameterValueExecption.
2. Moved out validation logic to UserVMManagerImpl from VirtualMachineManagerImpl.
3. Handling InvalidParameterValueException from async API calls so that they are not logged as ERROR in MS logs.
2014-11-04 17:34:07 +05:30
Min Chen
684889f0b5
CLOUDSTACK-7833: VM Async work jobs log "Was unable to find lock for the key vm_instance" errors as warning
2014-11-03 10:52:47 -08:00
Santhosh Edukulla
1aef5cba66
Fixed Coverity Issues
2014-11-03 16:45:30 +05:30
Hugo Trippaers
4ebaf0a583
Bump master version to 4.6.0-SNAPSHOT after branching 4.5.0-SNAPSHOT
2014-10-29 14:54:23 +01:00
Min Chen
94969b0654
CLOUDSTACK-7778: Start VM checkWorkItem loop should also check VM DB state before going into idle waiting to exit faster.
2014-10-23 14:28:23 -07:00
Daan Hoogland
8218ce0fe2
unexplained happy flow for restart network modified
2014-10-23 20:57:33 +02:00
Anthony Xu
4a13f81485
when host is pingtimeout and CCP can not determine the host status, put the host to Alert status , no VM HA.
2014-10-22 15:14:46 -07:00
Mike Tutkowski
97aa02ceb0
Commits related to taking snapshots that live on primary storage
2014-10-22 12:44:33 -06:00
Anthony Xu
70112bd145
CLOUDSTACK-7761:
...
Revert "when system VM ping times out, stop system VM"
This reverts commit ee23be1942001ab732cfb3ad50fa24163cb88a48.
2014-10-21 17:19:57 -07:00
Mike Tutkowski
57dacf99a2
Changed "boolean connectVolumeToHost(VolumeInfo, Host, DataStore)" to "boolean grantAccess(DataObject, Host, DataStore)"
...
Changed "void disconnectVolumeFromHost(VolumeInfo, Host, DataStore)" to "void revokeAccess(DataObject, Host, DataStore)"
2014-10-21 16:01:14 -06:00
Min Chen
4b8bfe2627
CLOUDSTACK-7563: Fix potential NPE from FingBugs.
2014-10-14 11:19:39 -07:00
Santhosh Edukulla
0a9742f914
Fixed few coverity issues
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-10-14 17:16:50 +05:30
Edison Su
d233f39c82
disable parallel for xenserver. Also for vmware, if full.clone is enabled and migratecommand will have the behavor of start/stop command
2014-10-09 17:14:57 -07:00
Santhosh Edukulla
31a42d2b7a
Fixed few coverity patches
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-10-09 11:45:26 +05:30
Anthony Xu
847e1e47ae
when system VM ping times out, stop system VM
2014-09-30 12:35:44 -07:00
Hugo Trippaers
1c94017ff6
CID-1241966 Fix potential null deref
2014-09-30 11:27:51 +02:00
Devdeep Singh
55b4ead495
CLOUDSTACK-7598: When a vm deployed by cloudstack is stopped on the hypervisor
...
(outside cloudstack), the state of the vm is not updated in cloudstack db. The
ping task was not checking for resource (host) status by default. The power
state of the vms is returned as part of the resource status. Fixed the issue by
making sure ping task atleast tries once to get the resource status.
2014-09-25 13:13:56 +05:30
Jayapal
8c8c54f9f5
CLOUDSTACK-7622: Fixed deleting network when provider is disable
2014-09-25 10:31:51 +05:30
Harikrishna Patnala
c55bc0b2d1
CLOUDSTACK-7534: ResetVM for VM with attached datadisk fails when enable.ha.storage.migration is false
...
Separate global config to enable/disable Storage Migration during normal deployment
Introduced a configuration parameter named enable.storage.migration
2014-09-24 16:35:23 +05:30
Hugo Trippaers
8a13f44b44
Remove duplicate field in constructor
2014-09-18 16:02:26 +02:00
Daan Hoogland
7f440854f7
CLOUDSTACK-7184 retry-wait loop config to deal with network glitches
...
(cherry picked from commit a29f954a269c992307f0410df88ca4ac7a0b82a0)
Conflicts:
engine/orchestration/src/com/cloud/agent/manager/DirectAgentAttache.java
2014-09-18 12:55:05 +02:00
Rohit Yadav
2cd99e3e72
CID-1116245: Lock for getting answers from SynchronousListener
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-18 11:56:29 +02:00
Rohit Yadav
3640c61207
CID-1116248: Synchornize method in SynchronousListener
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-18 11:54:31 +02:00
Anthony Xu
e5a91e40dd
in tagCommand, AsyncJobExecutionContext doesn't need to be created if it doesn't exist
2014-09-17 18:15:41 -07:00
Min Chen
1b15efb5f0
CLOUDSTACK-7563: ClassCastException in VirtualMachineManagerImpl in
...
handling various Agent command answer.
2014-09-16 12:12:17 -07:00
Min Chen
d5a8f1d875
CLOUDSTACK-7553: Clean up cached agentMap and pingMap in case of agents
...
connecting back to a different MS.
2014-09-15 17:37:51 -07:00
Nitin Mehta
0a4ab3251a
CLOUDSTACK-7513: listServiceOfferings API when called with VM's id also returns offerings to which it cant be upgraded. Adding the logic that when vmid is passed it looks for compatible offerngs using the storage type (local/shares), storage tags and also compute (cpu,speed, memory) in case the vm is running.
...
Also changed the scaleVm API to upgrade only when the destination offering has storage tags as a subset of current offering tags.
2014-09-15 11:02:34 -07:00
Bharat Kumar
2b7b837b28
CLOUDSTACK-6099 live migration is failing for vm deployed using dynaic compute offerings with NPE
2014-09-10 13:26:24 +02:00
Kishan Kavala
6f7c4863a2
CLOUDSTACK-7473: Vm migration is not supported for LXC. When host is put in maintenance mode, stop the Vms instead of migrating
2014-09-04 20:59:19 +05:30
Hugo Trippaers
dc3f0cbc63
Improve the handling of the findbug exclude files
2014-09-03 10:41:22 +02:00
Likitha Shetty
8ce6eba549
CLOUDSTACK-7415. Host remains in Alert after vCenter restart.
...
Management server PingTask should update PingMap entry for an agent only if it is already present in the Management Server's PingMap.
2014-08-25 13:24:28 +05:30
Santhosh Edukulla
19ffc93e2e
Fixed few coverity reported issues:Aug22 2014
2014-08-21 17:09:27 +05:30
Likitha Shetty
7dbff9b42c
CLOUDSTACK-7371. [VMware] Enabling primary storage maintenance fails when storages are across cluster.
...
1. While destroying a ROOT volume do the lookup of the associated VM under the DC and not just cluster.
2. In case of VMware, during VM start if a volume is being recreated no need to detach the old volume because
we now expunge it immediately and don't wait for the storage cleanup task to run.
2014-08-20 10:51:18 +05:30
Olivier Lemasle
de424061b2
CLOUDSTACK-7006: Restore template ID in ROOT volume usages
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-08-18 10:14:26 -04:00
Koushik Das
8bc7ae695d
CLOUDSTACK-7182: NPE while trying to deploy VMs in parallel in isolated network
...
- Check to see if network is implemented changed from 'state == Implementing||Implemented' to 'state == Implemented'.
The earlier check was a hack to prevent the issue described below.
- At the time of implementing network (using implementNetwork() method), if the VR needs to be deployed then it follows
the same path of regular VM deployment. This leads to a nested call to implementNetwork() while preparing VR nics. This
flow creates issues in dealing with network state transitions. The original call puts network in "Implementing" state
and then the nested call again tries to put it into same state resulting in issues. In order to avoid it, implementNetwork()
call for VR is replaced with below code.
2014-08-18 10:43:04 +05:30
Min Chen
fee2bfce49
CLOUDSTACK-7344:VOLUME.DELETE usage event missing for VM's in ERROR
...
state.
2014-08-13 22:15:47 -07:00
Santhosh Edukulla
e4d6cd8e6a
Fixed coverity reported concurrency issues
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-08-05 12:16:08 +05:30