34060 Commits

Author SHA1 Message Date
davidjumani
03ad702c1b
server: Set free memory to zero if greater than total memory (#4571)
Fixes https://github.com/apache/cloudstack/issues/4566

Sets `memoryintfreekbs` to zero if it is greater than `memorykbs`. Caused by KVM returning the RSS memory of the process running the VM rather than the free memory inside the VM.

Co-authored-by: dahn <daan.hoogland@gmail.com>
2021-03-30 14:05:46 +05:30
Gabriel Beims Bräscher
d6a74272a4
plugins: Add 'break' at RedifshClient request re-try loop (fixed issue from 4846) (#4864)
* Break loop if no exception on http request

* Add new tests ensuring the correct execution flow of the RedfishClient retry

* Log retry as "retry attempt %d/%d"

* Fix string.format parameters order at RedfishClient.retryHttpRequest
2021-03-29 16:25:47 +05:30
sureshanaparti
89111110cb
server: Remove the rule(s) validation with api names while importing role, to be in sync with the create role permission behavior (#4840)
This PR removes the rule(s) validation with api names while importing a role. This will be in sync with the current create role permission behavior.
2021-03-29 16:23:43 +05:30
Wei Zhou
b8884efa7f
server: create DB entry for storage pool capacity when create storage pool (#4805)
* server: create DB entry for storage pool capacity when create storage pool

* Revert "server: create DB entry for storage pool capacity when create storage pool"

This reverts commit e790167bfe8cdebc80c8a51cb0191184edc40afd.

* server: create DB entry for storage pool capacity when create zone-wide storage pools
2021-03-29 16:21:24 +05:30
Hoang Nguyen
caa55a5742
ui: fix page size on mobile view (#4765) 2021-03-29 16:20:22 +05:30
Hoang Nguyen
3e8dbc0584
ui: add cancel button missing on dialog (#4763) 2021-03-29 16:19:38 +05:30
Hoang Nguyen
642878063d
ui: Auto-focus input, form (#4762)
* autofocus into the first element (form/dialog)

* add autofocus missing

* add autofocus to missing elements
2021-03-29 16:19:26 +05:30
Pearl Dsilva
97176690b8
server: Fix issue with volume resize on VMWare (deploy as-is templates) (#4829)
This PR fixes the issue pertaining to volume resize on VMWare for deploy as-is templates. VMware deploy as-is templates are those that are deployed as per the specification in the imported OVF. Hence override root disk size will not be adhered to for such templates. Moreover, when we deploy VMs in stopped state and resize the volume, the root disk doesn't get resized but the volume size is merely updated in the DB.
This PR also includes the following (for deploy as-is templates):
- Disables overriding root disk size during VM deployment on the UI
- Disables selection of compute offerings with root disk size specified, at the time of deployment
- Provided users with the option to deploy VM is stopped state via UI (so as to give an option to users to resize the volumes before starting the VM)

Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2021-03-29 12:54:47 +05:30
Daan Hoogland
918c3bd3d5 Merge release branch 4.14 to 4.15
* 4.14:
  tests: Extend wait time after interrupt (#4815) (#4866)
2021-03-25 17:45:31 +01:00
davidjumani
0094cf44e1
tests: Extend wait time after interrupt (#4815) (#4866)
Co-authored-by: dahn <daan.hoogland@gmail.com>

Co-authored-by: dahn <daan.hoogland@gmail.com>
2021-03-25 10:04:08 +01:00
Wei Zhou
952b242722
kvm: Do not set backing file format of DATADISK in vm start/migration (#4800)
* kvm: Do not rebase DATADISK in vm start/migration

* #4800: add comment and use isBlank
2021-03-24 20:22:51 +01:00
Rohit Yadav
9b1d1e6de3
systemvmtemplate: new template for 4.15.1 (#4793)
Update new systemvmtemplate for 4.15.1.0; synced:
http://download.cloudstack.org/systemvm/4.15/

A new template is necessary due to many security fixes over the last year, the 4.15.0 systemvmtemplate was created about a year ago.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2021-03-24 17:08:46 +05:30
Hoang Nguyen
5df1337f27
ui: fix update template permission (#4744) 2021-03-24 17:02:48 +05:30
Rohit Yadav
90bd4ba23b
Revert "plugins: Add 'break' at RedifshClient request re-try loop (#4846)" (#4861)
This reverts commit 96dd7280f69f940c077e27fdca67263f24f9c4c9.
2021-03-24 12:53:32 +05:30
Pearl Dsilva
546bf3d5a2
server: Update vm_template table to set template as removed on deletion (#4748)
* Update vm_template table removed field when template is deleted

* Update method name

* address comment

* Extracted code to separate methods

* Address test failure

* refactor test cleanup

Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2021-03-24 12:41:03 +05:30
Gabriel Beims Bräscher
96dd7280f6
plugins: Add 'break' at RedifshClient request re-try loop (#4846)
* Break loop if no exception on http request

* Add new tests ensuring the correct execution flow of the RedfishClient retry

* Log retry as "retry attempt %d/%d"
2021-03-24 12:24:40 +05:30
davidjumani
61de2371ab
ui: Disable login button until redirected (#4857) 2021-03-24 12:18:19 +05:30
Rakesh
dab7d29bb2
systemvm: Load modules to support NAT traversal in VR (#4777)
Load necessary modules so that VPN connection works properly
2021-03-24 12:13:31 +05:30
Wei Zhou
40d93af16c
vpc: dnsmasq is not started if use.external.dns is true (#4806)
* vpc: dnsmasq is not started if use.external.dns is true

* Revert "vpc: dnsmasq is not started if use.external.dns is true"

This reverts commit ee58fe0787dfd2353a0c95717c20fc2465946257.

* #4806 vpc: fix zone dns1/dns2 are missing in vpc VR when restart vpc or vpc VR
2021-03-24 12:12:33 +05:30
davidjumani
bd79e1a9d4
ui: Consider overprovisioning factor when displaying allocated progress bar (#4850) 2021-03-23 19:24:50 +05:30
Hoang Nguyen
eaefc2a69f
ui: Fix the styles action button (#4856) 2021-03-23 19:22:59 +05:30
Hoang Nguyen
a53ecacf41
ui: Fill out the search filter form field after performing a filter (#4855)
* Fill out the search filter form field after performing a filter

* fix button reset not work when refresh page
2021-03-23 19:21:44 +05:30
Abhishek Kumar
83b568ecde
ui: fix add cluster form for vmware (#4841)
Filter null values else API returns error.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2021-03-22 12:14:29 +05:30
Pearl Dsilva
6262366d85
ui: Fix add primary store during Zone Deployment for PreSetup protocol (#4845)
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2021-03-22 12:13:21 +05:30
davidjumani
58954354fd
tests: Extend wait time after interrupt (#4815)
Co-authored-by: dahn <daan.hoogland@gmail.com>
2021-03-19 11:14:39 +01:00
Hoang Nguyen
faf27e2b39
listview: goto account info instead of list account (#4767) 2021-03-18 13:18:38 +05:30
Hoang Nguyen
6836a94b0e
ui: create a new component and display the instance group as autocomplete (#4820) 2021-03-18 13:13:31 +05:30
Hoang Nguyen
d105d6a770
ui: Show display text instead of name (#4831) 2021-03-18 13:13:18 +05:30
sureshanaparti
b658cf12d0
ui: Added info / tooltip for add role and import role dialogs in the UI (#4836) 2021-03-18 13:13:08 +05:30
Pearl Dsilva
45e6800501
ui: Fix route to ISO From VM's Info Card / Detail View (#4839)
* ui: Correct route to ISO on Info Card

* Change label based on template/iso

Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2021-03-18 13:11:32 +05:30
davidjumani
f07e4d347e
ui: Show vm name along with password (#4821) 2021-03-17 17:44:47 +05:30
davidjumani
c2b378c62c
novnc: Hide fullscreen button when not connected (#4783) 2021-03-17 17:42:42 +05:30
Rakesh
e2664197ec
server: Fix NPE while cloudstack agent failed to connect to mgt server (#4779)
* Fix NPE while cloudstack agent failed to connect to mgt server

If `ramOvercommitRatio` field is missing in user_vm_details table
is missing then agent throws NPE after restarting

It is because in user_vm_details, there are 'cpuOvercommitRatio' for all
vms, but for vms the field 'ramOvercommitRatio' is missing in the table.

* code feedback
2021-03-17 17:42:02 +05:30
Wei Zhou
4c88021f81
novnc: Fix vm console is not working on firefox if language is not English (#4833) 2021-03-17 17:40:42 +05:30
davidjumani
a291dea26a
ui: Fixes for action messages and forms (#4824)
* ui: Fixes for storage

* ui: fixes for compute

* ui: Fixes for network and accounts

* ui: Fixes for domain

* ui: Fixes for infra
2021-03-17 17:38:26 +05:30
davidjumani
9caa535eb6
ui: Show label for view console action (#4823) 2021-03-17 17:37:38 +05:30
Pearl Dsilva
136252d65d
server: Maintain order or project owners added to account (#4822)
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2021-03-17 17:36:46 +05:30
davidjumani
abcd07c93f
ui: change createAccount to use post (#4812) 2021-03-17 17:35:19 +05:30
Pearl Dsilva
d81141ed37
Project Role Permission: Change default permission type to 'Deny' (#4832)
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2021-03-17 17:33:30 +05:30
Rohit Yadav
3f84b9ab42 Merge remote-tracking branch 'origin/4.14' into 4.15 2021-03-11 13:31:46 +05:30
Michael
1cfb44994f
db: add schema upgrade from 4.15.0.0 to 4.15.1.0 (#4574) 2021-03-11 13:24:29 +05:30
Abhishek Kumar
a691e87f0c
ui: fix update vm details wrt backend changes (#4670)
PR #4629 made changes in updateVirtualMachine behaviour wrt readonly details.
This change updates UI wrt new behaviour.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2021-03-11 13:17:23 +05:30
Abhishek Kumar
8aa765ac39
server: delete template on storage over capacity threshold (#4691)
* server: delete template on storage over capacity threshold

While deleting template for a specific zone, check should be done only for writable secondary storages and not for storages with available capacity threshold.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix for ISOs and refactor

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* remove writable store check

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix exception message

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2021-03-11 13:15:40 +05:30
Rohit Yadav
057ad2b7d9
usage: return guest OS uuid, guest OS name, category ID and name (#4755)
This fixes the ostype ID returned in listUsageRecords API response to
be uuid instead of internal DB ID and also returns the os category ID
(uuid) and name.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2021-03-11 13:08:55 +05:30
Pearl Dsilva
14366cdd6c
centos: Mask libvirtd sockets which prevents cloudstack-agent from being setup (#4756)
* Prevent adding --listen parameter when libvirt version > 5.6

* mask libvirtd sockets

* remove unused import

Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2021-03-11 13:08:09 +05:30
Abhishek Kumar
025b654b5d
server: use network details from nic network (#4772)
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2021-03-11 13:06:44 +05:30
davidjumani
9454edd0f3
ui: Show memory allocated percentage when migrating vm (#4784) 2021-03-11 13:06:11 +05:30
Abhishek Kumar
7a9d43e959
test: fix listVolumes call for detach volume migration check (#4785)
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2021-03-11 13:05:37 +05:30
davidjumani
8510344129
ui: Show vm name in info card in deployvm (#4786) 2021-03-11 13:04:28 +05:30
davidjumani
c6e8b8c4d5
ui: Show displayname in compute list view (#4787) 2021-03-11 13:03:56 +05:30