25275 Commits

Author SHA1 Message Date
Rohit Yadav
c06ca09b54 engine/storage: add NPE check, break if parent snapshot is null
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-18 17:20:09 +05:30
Rohit Yadav
065c556cf5 CLOUDSTACK-8166: add boundary checks in various usage parsers
- Add boundary condition to continue looping if creation data is after end date
- Add null pointer fix for create snapshot bug

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-18 17:11:07 +05:30
SrikanteswaraRao Talluri
2c515395d7 CLOUDSTACK-8161: mark the data volume related operations on LXC as skipped if RBD storage pool is not available
Signed-off-by: SrikanteswaraRao Talluri <talluri@apache.org>
2015-01-16 18:45:19 +05:30
Wei Zhou
e09308a1d4 CLOUDSTACK-7219: Cannot display Cluster Settings for missing commit 95e41fdf0da50c165a9317847058fce4efeddbcf
(cherry picked from commit 71103772b7502ff3a9f9af101652fe431cb8f630)
2015-01-16 10:57:49 +01:00
Rohit Yadav
59b2cbafa1 developer: re-add deleted configuration
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-15 20:05:45 +05:30
Rohit Yadav
188924751e CLOUDSTACK-7219: Fix NPE, log warning when config item is missing from scope
- Cherry picked from Daan's fix 63fbd16dd11388bd93cdbec4ea7fe6de37aa7fc5
- Added another check if configDepot returned null
- Removed developer prefill values

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-15 19:13:40 +05:30
Rohit Yadav
b99d950dd3 appliance: fix Debian iso url, fixes failing Jenkins builds
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-15 15:31:27 +05:30
Erik Weber
7885a6c4ef Add absolute schema references to support MySQL 5.6 better
(cherry picked from commit 396936ea5e84d079394664fd1d0596a94e159855)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-14 20:32:40 +05:30
Pierre-Yves Ritschard
5ea7414746 move ConstantTimeComparator to utils
(cherry picked from commit b2393c31ed8f689e45227f12371fc042c9dbd0e4)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-14 20:25:32 +05:30
Pierre-Yves Ritschard
162c5af6f8 Use constant-time comparison functions when checking signatures
This limits the likeliness of timing attacks against the API.
See http://codahale.com/a-lesson-in-timing-attacks/ for the
full rationale.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Conflicts:
	server/src/com/cloud/api/ApiServer.java
	server/src/com/cloud/user/AccountManagerImpl.java

(cherry picked from commit 9b4e39e837af498599859c4a6687eb8bf9f8ad89)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-14 20:25:21 +05:30
René Moser
9a677595fa CLOUDSTACK-8154: fix UI for API change
Signed-off-by: René Moser <mail@renemoser.net>
(cherry picked from commit 07d96aab843a3f191e3cfbff57560d821938076a)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-14 16:36:08 +05:30
René Moser
5df6ee4f7c CLOUDSTACK-8154: Fix typo in response name string: there is an extra 's'
Signed-off-by: René Moser <mail@renemoser.net>
(cherry picked from commit c7ebd13d02948fd2ca2d6e4245127e01a2f7579e)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-14 16:36:01 +05:30
Rohit Yadav
921ad057de CLOUDSTACK-8155: Remove unwanted whitespaces from json response
This removes extra whitespaces from the JSON serialized response.
After the fix, tested to work with:
- Present UI
- CloudMonkey
- Old buggy json parsers

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-14 02:40:00 +05:30
Rohit Yadav
6bec69844d CLOUDSTACK-8037: Require signed AuthnRequest, adds more security
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-14 02:40:00 +05:30
Ashutosh K
2ed76b2a55 CLOUDSTACK-8143: Corrected a test in BVT test_routers.py 2015-01-13 16:43:01 +05:30
K@clogeny.com
17e1922439 CLOUDSTACK-8137: Fixed cleanup issue in sec group tests in test_escalations_instances.py
Signed-off-by: SrikanteswaraRao Talluri <talluri@apache.org>
2015-01-13 15:49:23 +05:30
Ashutosh K
613aa8ea28 CLOUDSTACK-8135: Fixed cleanup issue in test_escalations_instances.py
Signed-off-by: SrikanteswaraRao Talluri <talluri@apache.org>
2015-01-13 15:47:57 +05:30
Ashutosh K
b8184d1e74 CLOUDSTACK-8149: Code-refactor - test_VirtualRouter_alerts.py
Signed-off-by: SrikanteswaraRao Talluri <talluri@apache.org>
2015-01-13 15:22:22 +05:30
Ashutosh K
032a003905 CLOUDSTACK-8147: Fixed typo in test case test_redundant_router.py
Signed-off-by: SrikanteswaraRao Talluri <talluri@apache.org>
2015-01-13 15:22:15 +05:30
Gaurav Aradhye
9278ac1130 CLOUDSTACK-8145: Adding new test to test blocker bugs and modifying other test case to work around the bug
Signed-off-by: SrikanteswaraRao Talluri <talluri@apache.org>
2015-01-13 15:22:06 +05:30
David Nalley
d161642f69 make the date command actually work 2015-01-12 17:46:12 -05:00
Daan Hoogland
94e6b7587d CID-1256275 regression: resource leak in systemvm update code
(cherry picked from commit 06d4458d0a9de5be7a7bf590678eb4b03989e9a1)

Conflicts:
	engine/schema/src/com/cloud/upgrade/dao/Upgrade442to450.java
2015-01-12 20:51:51 +01:00
Rohit Yadav
23de431f96 CLOUDSTACK-8037: Fix attribute detection, tested to work with onelogin.com
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-12 19:40:05 +05:30
Wei Zhou
2720a1b49f CLOUDSTACK-8146: Resource count of primary storage does not consider the detached volumes
(cherry picked from commit b528047fb6f1c199e5e1cfe991a10b72a2b32a49)
2015-01-12 12:30:09 +01:00
Rohit Yadav
4358714381 CLOUDSTACK-8035: Generate and store X509Cert and reuse this for SAML
The fix generates X509Certificate if missing from DB and uses that for eternity.
SAML SP metadata remains same since it's using the same X509 certificate and
it remains same after restarts. The certificate is serialized, base64 encoded
and stored in the keystore table under a specific name. For reading, it's
retrieved, base64 decoded and deserialized.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-12 16:47:31 +05:30
Rohit Yadav
734bd70173 CLOUDSTACK-8037: URL encode cookie values with UTF8 as per version 1
As per Version 1 cookies, certain characters are now allowed such as space,
colons etc but they should be url encoded using UTF8 encoding. The frontend
has a cookie value unboxing method that removes any double quotes that are added.

As per the doc http://download.oracle.com/javase/6/docs/api/java/net/URLEncoder.html
values are application/x-www-form-urlencoded and as per
http://www.w3.org/TR/html4/interact/forms.html#h-17.13.4 whitespaces are encoded
as +, therefore '+' are replaced by %20 (whitespace).

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-12 14:02:36 +05:30
Rohit Yadav
b2b496288d CLOUDSTACK-8034: Hash user IDs for SAML authentication
The User table's UUID column is restricted to 40 chars only, since we don't
know how long the nameID/userID of a SAML authenticated user will be - the fix
hashes that user ID and takes a substring of length 40 chars. For hashing,
SHA256 is used which returns a 64 char length string.

- Fix tests, add test cases
- Improve checkSAMLUser method
- Use SHA256 one way hashing to create unique UUID for SAML users

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-12 13:33:57 +05:30
Wei Zhou
1e8476d38a CLOUDSTACK-8140: CS fails to start after secstorage/consoleproxy.service.offering is set to uuid
(cherry picked from commit 84c44b63140e8acf2336549040bda9c0a8f2ff66)
2015-01-06 10:26:04 +01:00
Jessica Wang
744c1a1b03 CLOUDSTACK-7383: UI > Instances menu > detail view > TakeSnapshot action should be hidden when VM's hypervisor is LXC. 2015-01-02 14:06:28 -08:00
Jessica Wang
775e4d34c3 CLOUDSTACK-8141: UI > use Project view > Infrastructure > zone > physical network > Public traffic type > do not pass projectId to listNetworks API. 2015-01-02 11:33:57 -08:00
Jessica Wang
85e88e9cbc CLOUDSTACK-8139: UI > create compute offering > server-side only supports one single host tag instead of multiple host tags. So, change UI to take in only one single host tag instead of multiple host tags in create compute dialog. 2014-12-31 16:21:13 -08:00
Gaurav Aradhye
94237a4c5b CLOUDSTACK-8116: Moved ldap data to configurableData section in test_data.py and made related changes in the test case
Signed-off-by: SrikanteswaraRao Talluri <talluri@apache.org>
2014-12-24 10:38:05 +05:30
Gaurav Aradhye
239150c558 CLOUDSTACK-8117: Increase the allowed margin (+/-) for memory of VM on hyperv used to equate with the memory specified in service offering
Signed-off-by: SrikanteswaraRao Talluri <talluri@apache.org>
2014-12-24 10:36:33 +05:30
Ashutosh K
5a6eb3b6e1 CLOUDSTACK-8099: Fixed missing import in test_dynamic_compute_offering.py
Signed-off-by: SrikanteswaraRao Talluri <talluri@apache.org>
2014-12-23 15:05:23 +05:30
Chandan Purushothama
ddcbfb43bc CLOUDSTACK-7788: Fixed the script 'test_dynamic_compute_offering.py' to be run only on hardware 2014-12-23 15:05:14 +05:30
Gaurav Aradhye
125c1c27fc CLOUDSTACK-8098: Fixed VM snapshot issue in smoke/test_vm_snapshots.py
Signed-off-by: SrikanteswaraRao Talluri <talluri@apache.org>
2014-12-23 14:59:55 +05:30
SrikanteswaraRao Talluri
f18e00abf1 Revert "CLOUDSTACK-7762 -[Automation] - Fix test failure for test_02_revert_vm_snapshots in smoke/test_vm_snapshots.py"
This reverts commit f510ef995baaa9addefc22ff0330cd51dee1dd95.
2014-12-23 14:59:46 +05:30
Gaurav Aradhye
1413efcac3 CLOUDSTACK-8096: Fixed test_ssvm.py for issues while checking the result of diagnostic scripts
Signed-off-by: SrikanteswaraRao Talluri <talluri@apache.org>
2014-12-23 14:24:32 +05:30
Chandan Purushothama
ab3af7b014 CLOUDSTACK-7769 - Fixed test_ssvm.py script 2014-12-23 14:23:49 +05:30
Koushik Das
e0c495d357 Revert "CLOUDSTACK-7872: network getting shutdown inspite of running VM's in the network"
This reverts commit 0bd34d389f93b56e74a6bb04054c8e419bf8571e.

Network GC is broken with out-of-band VM movements due to the original commit, so reverting.
2014-12-23 11:56:40 +05:30
Sangeetha Hariharan
3736d9435a CLOUDSTACK-7762 -[Automation] - Fix test failure for test_02_revert_vm_snapshots in smoke/test_vm_snapshots.py 2014-12-22 13:55:07 +05:30
Gaurav Aradhye
588e7dc811 CLOUDSTACK-8100: Fixed pep8 issues in test_vpc.py
Signed-off-by: SrikanteswaraRao Talluri <talluri@apache.org>
2014-12-22 13:53:10 +05:30
Ashutosh K
a2fa2e4911 CLOUDSTACK-8095: Fixed Iso attach issue in test_escalations_instances.py
Signed-off-by: SrikanteswaraRao Talluri <talluri@apache.org>
2014-12-22 13:53:01 +05:30
Koushik Das
788fe5a273 CLOUDSTACK-8103: Vmsync marks VM as stopped even after failing to stop it in HV
During vmsync if StopCommand (issued as part of PowerOff/PowerMissing report) fails to stop VM (since VM is running on HV),
don't transition VM state to "Stopped" in CS db. Also added a check to throw ConcurrentOperationException if vm state is not
"Running" after start operation.
2014-12-22 12:31:34 +05:30
Min Chen
c5d3a73c67 CLOUDSTACK-8101: volume sync not working as expected - MS restart during
upload volume leaves volume in hung state.
2014-12-19 16:43:02 -08:00
Jessica Wang
a29a1e0600 CLOUDSTACK-8102: UI > Quick Install Wizard > update admin > should encode parameter value once instead of twice before sending it to API. 2014-12-19 15:41:42 -08:00
Jessica Wang
48e996f43e CLOUDSTACK-6666: UI > network > VPC > Router > Public IP Addresses > IP Address detailView > Configuration tab > Port Forwarding > Select VM screen > implement keyword search. 2014-12-19 14:26:42 -08:00
Jessica Wang
a771c7d496 CLOUDSTACK-6666: UI > network > VPC > Router > Public IP Addresses > IP Address detailView > Configuration tab > Load Balancing > Select VM screen > implement keyword search. 2014-12-19 14:25:32 -08:00
Ashutosh K
6c722c9d21 CLOUDSTACK-8087: Fixed test_vpc_on_host_maintenance.py
Signed-off-by: SrikanteswaraRao Talluri <talluri@apache.org>
2014-12-19 10:36:14 +05:30
Gaurav Aradhye
0db63d87aa CLOUDSTACK-8084: Fixed test_17_add_nic_different_zone in test_add_remove_network.py
Signed-off-by: SrikanteswaraRao Talluri <talluri@apache.org>
2014-12-19 10:36:02 +05:30