673 Commits

Author SHA1 Message Date
abhishek
362e67d724 adding failover protection case for when the mgmt svr crashes in the middle of executing something; along with custom response for cert 2010-11-01 09:04:51 -07:00
abhishek
7b87aad660 fixed a bug in the listener flow; now handling the application of certs to existing cpvms and new cpvms based on a fork in the logic in the console proxy resource 2010-11-01 09:04:51 -07:00
abhishek
abd64eddd1 adding more exception handling and debugging support 2010-11-01 09:04:51 -07:00
root
3752a4eb31 making the logic more robust, testing more corner cases, improving efficiency and changing the schema 2010-11-01 09:04:51 -07:00
abhishek
9c80911e52 more changes 2010-11-01 09:00:58 -07:00
abhishek
d9ebb7147c improving efficiency by reducing the number of db lookups, whilst updating the custom certificates across multiple console proxies when the command is issued. Now, we use in memory hashmaps for hosts to get the hostids for cphosts, which eliminates the need to make a db lookup for every cpvm that needs to be rebooted 2010-11-01 09:00:58 -07:00
abhishek
4d2e126ea1 more cpvm refactoring 2010-11-01 09:00:58 -07:00
kishan
b08037d22c bug 6851: use specified account properties instead of admin, resourceType enum instead of type
status 6851: resolved fixed
2010-11-01 19:19:33 +05:30
kishan
3a0f30a049 bug 6408: remove security groups/port forwarding service in virtual network case
status 6408: resolved fixed
2010-11-01 14:28:03 +05:30
nit
1b88b0eae4 bug 6748: Correcting secondary storage space utilization on the dashboard. The fix will update the existing db entry and will create a new entry for the first time only.
status 6748: resolved fixed
2010-11-01 12:16:07 +05:30
edison
5c88bb936b Oops, == doesn't work... 2010-10-29 19:51:24 -07:00
edison
d0c68cd4a7 add a timeout (5 minutes) to wait for KVM agent host connecting to mgt svr, during adding host->discover 2010-10-29 19:18:07 -07:00
Kris McQueen
24551eea3a Add constants for API command parameter names and for API response parameter names. Update the commands with the new constants rather than custom strings. Update several of the responses with the constants. Not all the responses have been updated, this is still work in progress... 2010-10-29 17:20:40 -07:00
edison
f526a92b08 Only allow to attach a volume to a vm, when they are created by the same hypervisor. 2010-10-29 15:48:26 -07:00
Kris McQueen
a9349cb815 bug 6857: if the dispatcher recieves an IllegalArgumentException, bubble that up to the response so the caller gets a useful message 2010-10-29 14:07:23 -07:00
Kris McQueen
519633cd38 bug 6763: restore the volume lock when creating a snapshot for the volume to ensure only one thread is creating the snapshot at a time. 2010-10-29 13:53:00 -07:00
Kris McQueen
88dac13bb0 use the API response date format when serializing response objects 2010-10-29 13:23:29 -07:00
will
9cc5aaa978 Fixed listTemplates to use the template type. 2010-10-29 13:17:32 -07:00
Alex Huang
96a4aa6f2b checkin to allow regular code path 2010-10-29 12:16:58 -07:00
Alex Huang
14f80f2e13 domain router up and running...now on to patching through the network between the domain router and the vm 2010-10-29 12:16:58 -07:00
anthony
b00a9174e2 always add master first when adding host 2010-10-29 11:07:51 -07:00
kishan
ad3c18a46c bug 6789: release router lock after commiting transaction
status 6789: resolved fixed
2010-10-29 16:22:19 +05:30
Kris McQueen
ebac4539d0 it's possible createSnapshotDB will return null, handle that case. However, if createSnapshotDB returns null because there was no work to do (empty snapshot) we should probably throw an exception that reports that fact instead of returning null and throwing an internal error 2010-10-28 17:52:37 -07:00
Kris McQueen
642b8a56f4 If the create command returns null for whatever reason, throw an exception so it aborts scheduling the async job to act on the created object 2010-10-28 17:52:37 -07:00
Kris McQueen
640a3dc239 bug 6818: if the userAccount is null, the user is either removed or does not exist. Since we can't log them out in those cases, just skip saving the logout event (and hence avoid the NPE).
status 6818: resolved fixed
2010-10-28 17:52:37 -07:00
Kris McQueen
2f9e91a9ae bug 6738: honor groupid when listing vms (restrict the list to just that group)
status 6738: resolved fixed
2010-10-28 16:27:07 -07:00
Kris McQueen
50a72d7f71 bug 6740: update the group for a VM if a group name is given
status 6740: resolved fixed
2010-10-28 16:27:07 -07:00
Kris McQueen
6435991086 bug 6782: somehow in my testing I missed this exception when creating the event for USER_DELETE. The change is to get the userAccount by 'idIncludingRemoved' just like getting the account. The proper userAccount object is returned and the event is successfully created.
status 6782: resolved fixed
2010-10-28 14:32:13 -07:00
Kris McQueen
7531525252 Add commented code out for the old style (2.1.x) JSON async job responses. The XML responses are still a TODO. In order to get this to fully revert back to 2.1.x style responses, some commands will need to be modified to set the responseName to be something like getResultObjectName(), and there's an example of this in StopVMCmd. 2010-10-28 14:32:13 -07:00
Kris McQueen
9eb851db60 bug 6809, 6712: standardize the domain router response to use guestmacaddress instead of macaddress
status 6809, 6712: resolved fixed
2010-10-28 14:32:13 -07:00
will
c5fef26f11 ListTemplates will no longer return any SystemVM templates. I am using a startsWith() string match for now since we used to make this comparision by ID with a single hypervisor. 2010-10-28 13:28:33 -07:00
nit
c9069303ce Code clean up for Extract functionality and making it more robust. 2010-10-28 18:45:12 +05:30
will
f0a4449ec3 ListTemplates now return the hypervisor type. 2010-10-27 19:50:36 -07:00
Kris McQueen
50c175d6c1 bug 6799: forgot to add the exception response in my commit for this bug... 2010-10-27 18:23:23 -07:00
Kris McQueen
484f334d7a bug 6799: if there's an exception executing the Async command, create an error response with the appropriate information so that queryAsyncJobResult returns the relevant information
status 6799: resolved fixed
2010-10-27 18:23:23 -07:00
Kris McQueen
901f52eb99 bug 6782: incremental checkin for deleting an account. Since there was a change to findById to not find removed objects, these NPEs pop up from time to time where we expected to find the object previously and now it's not found. Since the account is getting deleted, do a findByIdIncludingRemoved to make sure the actual account object is retrieved. 2010-10-27 18:23:23 -07:00
Kris McQueen
9056653e17 Change the API Implementation annotation to use the manager's class rather than an enum. This allows methods for new managers to be added trivially rather than having to modify the dispatcher to load a new manager class. 2010-10-27 12:23:31 -07:00
edison
a29b897b7f bug 1974: set memory size from service offering before starting router
status 1974: resolved fixed
2010-10-27 12:00:11 -07:00
Kris McQueen
ae9b6d4fe1 bug 6776: for some reason, we checked for zoneId = -1 in registerTemplate and applied it to all zones, but this wasn't done for registerIso. Oh well, make the change for registerIso and things seem happy again
status 6776: resolved fixed
2010-10-26 17:55:00 -07:00
Kris McQueen
c9d9a18ace bug 6746: use loadbalancer name rather than the command's name for updating the load balancer; use the load balancer's account id rather than the load balancer id when searching for the load balancer owner
status 6746: resolved fixed
2010-10-26 17:40:29 -07:00
Alex Huang
4f9f249218 make console proxy work again with the new network configuration 2010-10-26 17:37:29 -07:00
Kris McQueen
e63d17dd41 bug 6739: stopSystemVm needs to return the appropriate VM instance type. The manager methods were returing VMInstanceVO, which is not sufficient for getting, for example, active viewer sessions from the console proxy object. Make sure the right VO object is returned, and all the data should be available for the API to generate a full response.
status 6739: resolved fixed
2010-10-26 17:33:53 -07:00
Kris McQueen
a788d2cb2e bug 6736: rebootSystemVm should return the vm properties, not success true/false.
status 6736: resolved fixed
2010-10-26 17:19:55 -07:00
Kris McQueen
95da86ef1a bug 6733: re-throw ServerApiExceptions when dispatching API commands rather than logging them and throwing a generic INTERNAL_ERROR exception
status 6733: resolved fixed
2010-10-26 16:54:42 -07:00
Kris McQueen
28bcbc3bdd bug 6732: there is no longer a manual policy, so add in special handling for deleting manual snapshots. Also, in the process of deleting the snapshot, the snapshot might need to be retrieved from the database, so be sure to find including removed.
status 6732: resolved fixed
2010-10-26 16:47:21 -07:00
Kris McQueen
8fafc892d3 bug 6730: if a volume was never attached to a VM, then the poolId will be null and this will be flagged as not on shared storage. Since the code was deleting detached volumes only on shared storage, the never-attached volume was in an undeletable state. Instead, allow deletion of any detached volume, regardless of storage pool until some technical reason limits this from happening.
Also, the UI was not allowing volumes to be deleted due to a bug in looking at the vmname property of the volume.  The 'if' conditional always returned true that the volume was attached to a VM to due a boolean logic error.

status 6730: resolved fixed
2010-10-26 14:56:44 -07:00
abhishek
a698c0327d adding more logging around successful cert upload 2010-10-26 14:27:26 -07:00
abhishek
c6588c0e25 adding some error return handling to api dispatcher, and cleaning up some of the code paths to return the right error messages 2010-10-26 14:27:26 -07:00
root
42f1ff92a9 resolved merge conflicts after git pull --rebase 2010-10-26 14:27:26 -07:00
abhishek
f64abad8f5 completed the listener logic. Based on the startup command, we will try and update a cust cert to a new running cpvm, and fail if such a cert doesn't exist in the cert table in our db. 2010-10-26 14:27:26 -07:00