33170 Commits

Author SHA1 Message Date
Wei Zhou
96cfe27504
db upgrade: fix sql exception: Access denied; you need (at least one of) the SUPER privilege(s) for this operation (#4533) 2020-12-14 11:40:33 +05:30
lujiefsi
2aa7fac9ac
CLOUDSTACK-10423:Potential sensitive information disclosure (#4536)
* fixing CLOUDSTACK-10423

* make the message clear

Co-authored-by: lujie <lujie@foxmail.com>
2020-12-14 11:40:23 +05:30
lujiefsi
3689b9da41
jobs: The patch remove the password from resultObject and make it be humanreadable (#4538)
This PR fixes CLOUDSTACK-10425.

Co-authored-by: lujie <lujie@foxmail.com>
2020-12-14 11:39:54 +05:30
Rohit Yadav
bd38f0647f Merge remote-tracking branch 'origin/4.14' 2020-12-11 13:25:37 +05:30
davidjumani
28c67d267b
listphysicalnetworks: Honouring keyword parameter (#4511) 2020-12-11 13:14:41 +05:30
Pearl Dsilva
edd5f23e8b
Fix NPE when Volume exists on secondary store but doesn't have a download URL (#4530)
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2020-12-11 13:12:39 +05:30
Sina Kashipazha
160cdfb948
apidoc issue (#4532)
* Fix sed command failure in Mac OS.

* FIX, Removed the buggy line that I copied from Stackoverflow.
2020-12-11 13:11:44 +05:30
Rohit Yadav
e5b7733498 Merge remote-tracking branch 'origin/4.14'
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2020-12-10 14:58:23 +05:30
Wei Zhou
9de679ea1c
db: Fix description of volume.stats.interval which is in milliseconds not seconds (#4526) 2020-12-10 14:32:16 +05:30
Wei Zhou
1a47719588
kvm: set cpu topology only if cpucore per socket is positive value (#4527)
This PR fixes a regression issue in #4497

In cloudstack 4.14 or before, the cpu topology is set only when cpucore per socket is set (to 4 or 6).
in other conditions, there is no cpu topology in vm xml definition.

with #4497, vm will have cpu topology in its xml definition, if cpucore per socket is not set.

    <topology sockets='<vm cpu cores>' cores='1' threads='1'/>
Not sure if it causes any issue. I think it would be better not to add this part in vm xml definition if cpucore per socket is not set.
2020-12-10 14:29:28 +05:30
Rohit Yadav
e0242d5793
xenserver: check and eject patch vbd for systemvms (#4525)
XenServer 7.1 has an file descriptor/tapdisk iso-caching issue where new systemvm.iso are not recognised and inside the VR/ssvm/cpvm file IO error is seen. This was only reproducible with XS7.1 (intermittently), the fix was to check and eject the systemvm.iso (old/stale/cached), then insert the new systemvm.iso and then eject it.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2020-12-10 00:42:41 +05:30
Wei Zhou
74982c5e76
Fix warning when setup cloudstack-common (#4523) 2020-12-09 18:30:59 +01:00
Wei Zhou
93f3d35207
kvm: FIX cpucorespersocket is not working on KVM (#4497) 2020-12-09 15:07:51 +01:00
Alexandru Bagu
cd356c0513
change debug to warn for unknown exceptions (#4521)
Co-authored-by: Alexandru Bagu <abagu@bsss-MacBook-Pro.local>
2020-12-09 12:24:54 +01:00
Rohit Yadav
6718be00d0 Merge remote-tracking branch 'origin/4.14' 2020-12-08 14:02:29 +05:30
Pearl Dsilva
837372488f
Fix failure in validating IP address in case of multiple Management Servers (#4507)
* Fix failure in validating IP address in case of multiple Management Servers

* refactor code

Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2020-12-08 13:42:24 +05:30
Andrija Panic
e5c29c392e
Update log output for FirstFitPlanner (#4515) 2020-12-07 11:50:20 +01:00
Rohit Yadav
02f80d3370
ui: deprecate old UI and move to legacy to be served at /client/legacy (#4518)
As notified in the 4.14.0.0 release notes, this deprecates the legacy UI
and moves it under the ui/legacy directory which will be served at
/client/legacy URL path. This will also ensure that users upgrading or
installing 4.15.0.0 will get the new UI by default. This will also make
it simpler to remove the old UI for future 4.16/master releases.

Co-authored-by: Daan Hoogland <daan.hoogland@shapeblue.com>
2020-12-05 20:36:59 +05:30
Daan Hoogland
fb1e903532 Merge branch '4.14' 2020-12-03 15:11:59 +01:00
Wei Zhou
83ae6d7c01 integration test: skip vlan of public ip range in get_free_vlan 2020-12-03 15:10:43 +01:00
Wei Zhou
03e65a1266 vpc vr: plugin nics by this order: public/private/guest 2020-12-03 15:10:43 +01:00
Wei Zhou
627070c5f8 vpc vr: fix Conflicting device id on private gw nic 2020-12-03 15:10:43 +01:00
Rohit Yadav
5bea0a1ea4 Merge remote-tracking branch 'origin/4.14' 2020-12-02 14:29:34 +05:30
davidjumani
93ff156222
Adding zone name to physicalnetworkresponse (#4510) 2020-12-02 14:01:22 +05:30
davidjumani
7f5eb6463e
Disallowing udp for lb rules for haproxy (#4501)
* Disallowing udp for lb rules

* Revert "Disallowing udp for lb rules"

This reverts commit a5f43014c9dded01d199d55a84fd6cdc4d10c90b.

* Adding check for udp rules for haproxy

* Adding defensive check
2020-12-02 13:59:03 +05:30
Rohit Yadav
df07e27921 Merge remote-tracking branch 'origin/4.14' 2020-12-01 14:04:53 +05:30
Pearl Dsilva
e4a504b084
Make global setting non-dynamic (#4505)
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2020-12-01 14:00:35 +05:30
davidjumani
afebfd5bbf
Adding cpuallocated percentage and value to host and hostsformigrationresponse (#4499)
* Adding cpuallocatedwithoverprovisoning to hostresponse and hostsformigrationresponse

* Adding cpuallocatedpercentage and cpuallocatedvalue
2020-12-01 13:56:19 +05:30
Wei Zhou
e82813b509
kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs (#4496)
* kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs

* remove _params
2020-11-30 16:22:16 +05:30
Wei Zhou
e8ee8e9fbe
fix failures with test_multiple_nic_support.py (#4495) 2020-11-30 16:21:46 +05:30
davidjumani
2eef0e5af3
Fix hosts for migration count (#4500)
* Fixing count for findHostsForMigration

* Changing list name
2020-11-25 15:34:23 +05:30
Wei Zhou
4fb69e695c
sql: Fix Zones are returned in a random order (#3934) (#4494) 2020-11-25 15:30:43 +05:30
Daan Hoogland
e9ce381c56 Merge branch '4.14' 2020-11-25 09:04:53 +01:00
Wei Zhou
a979ab9050 integration test: update steps 2020-11-25 08:40:16 +01:00
Wei Zhou
6a91b8ace7 integration test: add private gateway in test 2020-11-25 08:40:16 +01:00
Wei Zhou
b2d8fffeea integration test: verify public nics state 2020-11-25 08:40:16 +01:00
Wei Zhou
8a68617eee bugfix #9 vpc vr: Add PREROUTING rule for vm with static nat to multiple private gateways 2020-11-25 08:40:16 +01:00
Wei Zhou
69c0f71cf7 bugfix #8 vpc: add rule for traffic between vm and private gateway 2020-11-25 08:40:16 +01:00
Wei Zhou
a8c9b4531b bugfix #7 vpc vr: allow servers in private gateway to reach internet via the VPC VR if it is gateway 2020-11-25 08:40:16 +01:00
Wei Zhou
8fb2efee1c bugfix #6 vpc vr: Add iptables rules for ACL of private gateway 2020-11-25 08:40:16 +01:00
Wei Zhou
7e6f484332 Revert "Fix Policy Based Routing for private gateway static routes (#3604)"
This reverts commit 82d94a87c56e1414d155271cff2481175640bc20.
2020-11-25 08:40:16 +01:00
Wei Zhou
66d3e1f6d4 Revert "Add private gateway IP to router initialization config"
This reverts commit 65cb22216aa1d5d6257f99d4ad84f80c319cdea9.
2020-11-25 08:40:16 +01:00
Wei Zhou
5cc6fedb1f Revert "Handle private gateways more reliably"
This reverts commit f4f9b3ab4ef2ef34e4d8a04c6ebfbf0784497227.
2020-11-25 08:40:16 +01:00
Wei Zhou
51f3756030 bugfix #4 vpc vr: Do NOT send Nic plug in/out command to Stopped/Stopping VR 2020-11-25 08:40:16 +01:00
Wei Zhou
655ed10655 bugfix #2 vpc vr: fix issue if static nat is disabled but still other IP used by lb/pf 2020-11-25 08:40:16 +01:00
Wei Zhou
f5ab87c153 bugfix #3 apply ip dessociation before unplugging a nic so ip is marked as add:false in ips.json 2020-11-25 08:40:16 +01:00
Wei Zhou
6491a69d63 bugfix #2 vpc: Fix remove first public ip will remove all ips on the nic 2020-11-25 08:40:16 +01:00
Rohit Yadav
8e03374c29 Merge remote-tracking branch 'origin/4.14' 2020-11-23 16:00:41 +05:30
Wei Zhou
81ac9f90ab
vr: fix python exception when configure VRs (#4489)
before
```
root@r-27-VM:/var/cache/cloud# /opt/cloud/bin/configure.py monitor_service.json
ERROR:root:Command 'ip link show eth0 | grep 'state DOWN'' returned non-zero exit status 1
```

with this change
```
root@r-27-VM:/var/cache/cloud# /opt/cloud/bin/configure.py monitor_service.json
root@r-27-VM:/var/cache/cloud#
```
2020-11-23 14:09:40 +05:30
Rakesh
beb1edcdbc
api: Add vpcid in usage network response (#4361)
* Add vpcid in usage network response

Currently vpcid is displayed in listUsageNetworks response.
Add the vpcid so that we can see to which vpc, the network belongs

* use new function to get removed
2020-11-23 14:02:25 +05:30