We shouldn't clean up class-scope resources(_cleanup). We should create local
ones(cleanup) then clean it.
So:
cls._cleanup would be used for class-scope resources.
self.cleanup would be used for each unit.
This result in countless test case failure because many test case units didn't
clean up after it.
The regression test result should be improved quite a bit after this change.
During switchover of master->backup->master, the rvr goes through
UNKNOWN, FAULT, MASTER/BACKUP. In case of improper transition the state
is FAULT. Include additional state check in the tests.
(cherry picked from commit 0c699394f246bc2b052a22d88b3f938ba8a72770)
Each module of redundant router contains related tests for
services, network rules, upgrades, redundancy etc.
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
