31354 Commits

Author SHA1 Message Date
Jorge Maldonado Ventura
0e8fbdb35f install: Fix URL error from installation instructions (#2564) 2018-04-12 13:51:00 +05:30
Rafael Weingärtner
91d9821149 [CLOUDSTACK-10230] User should not be able to use removed “Guest OS type” (#2404)
* [CLOUDSTACK-10230] User is able to change to “Guest OS type” that has been removed

Users are able to change the OS type of VMs to “Guest OS type” that has been removed. This becomes a security issue when we try to force users to use HVM VMs (Meltdown/Spectre thing). A removed “guest os type” should not be usable by any users in the cloud.
2018-04-12 09:48:59 +02:00
Rafael Weingärtner
bbc9204665
[CLOUDSTACK-10226] CloudStack is not importing Local storage properly (#2401)
* [CLOUDSTACK-10226] CloudStack is not importing Local storage properly

CloudStack is importing as Local storage any XenServer SR that is of type LVM or EXT. This causes a problem when one wants to use both Direct attach storage and local storage. Moreover, CloudStack was not importing all of the local storage that a host has available when local storage is enabled. It was only importing the First SR it sees.

To fix the first problem we started ignoring SRs that have the flag shared=true when discovering local storages. SRs configured to be shared are used as direct attached storage, and therefore should not be imported again as local ones.
To fix the second problem, we started loading all Local storage and importing them accordingly to ACS.

* Cleanups and formatting
2018-04-10 08:49:07 -03:00
Rafael Weingärtner
b08f9e053f
[CLOUDSTACK-10301] Allow updating the network ACL list name and Description (#2462)
* [CLOUDSTACK-10301] Allow updating the network ACL list name and description

* Fixes suggested by Daan
2018-04-10 08:46:52 -03:00
Rohit Yadav
50042680b0 Merge branch '4.11' 2018-04-10 00:31:38 +05:30
ernjvr
bb09caf8dc packaging: remove deprecated tomcat based sysconfig file for centos (#2538)
Remove deprecated tomcat configuration file instead of moving it, since moving it prevented the 4.11 upgrade from overwriting it with the new jetty configurations. Also added systemctl daemon-reload to refresh daemon services so that management server can start up seamlessly after the upgrade.

Fixes #2537
2018-04-10 00:31:09 +05:30
dahn
2756d41039
manual mapped ldap fix (#2517)
* translate groovy test for ADLdapUserManagerImpl to java

* fixed by returning the actual result instead of false

* unit test case for manual mapped user in ldap
2018-04-09 17:38:49 +02:00
Rohit Yadav
44da7575b8 Merge branch '4.11' 2018-04-09 20:47:06 +05:30
Rohit Yadav
9cf1532f0e
debian: remove old usage jars during upgrade (#2552)
This removes old cloudstack-usage jars during upgrade as part of
the pre-install step of cloudstack-usage deb package.

This fixes #2542.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2018-04-09 17:21:06 +05:30
Rafael Weingärtner
e198ff21b3
Create an easy way to enable the Java remote Debug for ACS (#2535)
The idea is to create a property in /etc/defaults/cloudstack-management that can be enabled/disabled (uncommented/commented) to control the enabling of Java remote debug in CloudStack's JVM.
2018-04-06 07:17:17 -03:00
René Moser
3221a55361
Add issue template for github issues (#2526) 2018-04-04 13:23:26 +02:00
dahn
1c253a6086 indicate scope of tests in checklist (#2522)
In cloudstack no-one person or organisation will ever be able to run all tests involving all kinds of hardware. make the checklist more realistic in this perspective.
2018-04-03 07:06:25 -03:00
Daan Hoogland
9124f97447 Merge release branch 4.11 to master
* 4.11:
  CLOUDSTACK-10287 package require open jdk 1.8 (#2519)
  make Broadcast- and IsolationURI visible to admin (#2520)
2018-04-03 08:18:37 +02:00
dahn
cff4032f00
CLOUDSTACK-10287 package require open jdk 1.8 (#2519) 2018-04-02 22:01:41 +00:00
dahn
23ae6762bd
make Broadcast- and IsolationURI visible to admin (#2520) 2018-04-02 21:55:18 +00:00
Christian Oliff
5dca01cacc Fix Successfully typo (#2515) 2018-03-30 08:54:16 -03:00
Rohit Yadav
41895561a7 Merge branch '4.11'
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2018-03-30 16:21:06 +05:30
Rohit Yadav
43f2a28d65 Merge branch '4.10' into 4.11 2018-03-30 16:17:37 +05:30
Rohit Yadav
5dcc3c2c54 Merge branch '4.9' into 4.10
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2018-03-30 16:16:11 +05:30
Rohit Yadav
78abb353ac Tagging release 4.9.3.1 on branch robot-tls-fix.
-----BEGIN PGP SIGNATURE-----
 
 iQIcBAABCAAGBQJas0g9AAoJEEhCSCEO49iEUzIP/3cBrkhQuaGTNA5NEsNuT3ca
 BI6bUkH5Jm0LWGvCxRvg4ZwZgzAO7KUb1CzEqlG/F+YC6PHUMgi+41wcPKdIjKGB
 VXHkmVkHGNUCjXG8YO7cBODA1VsqyFa2NUTe4kJKIlJ6SBJ7amUFEEMgH5nk5oIO
 LlNg9LetNqlTpBTkKVUkkOKVou+nLSoB46SnQ+mmlaT1uwIK8JpCeZQ5KmNsutnX
 mWsiu7T50ItJYrN0ZxEIhDX/7WZhTK1ogkkorNpRbSAHjhjwsaJrhLOdmuXAFHur
 R0zMSshU9U/nOuaOLwSnxmJirKyhuop++ZsOSLKgzHE2cj0bOfdWCdzPapJTpFls
 /DP96Pahu+GyelS2buBhfNDnOL2kdtcyXpwBxGxG3rXnd6bSL3rbLbBhgwQF5XeU
 XEVl0Bwyydo9kycefxrq0DY5I73zBRE3f/6fs+Xz2UNqUWI6QJDL6e/s0IXhZBs+
 JwGrcB1QTDRi3H6SgVM1cb1Ih7d4dIyFgpPSK6EUC9jbl3y9KvlnhiXU3Z9M0lpo
 WDFkeiy0V5MEMR6EusC/b1EeJCFicmnj1azlbwUVaRyUGgY6l8DarwwBHX23fnyW
 exY9STXjNrWWRI3FSTiWorW6i+c+xgZ41uxNDSc2hUejCmDhrpV7TLypRLT4hvYp
 95QU/OSZCw81IVmw1uOD
 =Ql9D
 -----END PGP SIGNATURE-----

Merge tag '4.9.3.1' into 4.9

Tagging release 4.9.3.1 on branch robot-tls-fix.
2018-03-30 16:14:17 +05:30
Rafael Weingärtner
060715e9f5
[CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools (#2414)
* [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools

Due to a race condition between multiple management servers, in some rare cases, CloudStack is creating multiple file SRs to the same secondary folder. This causes a problem when introducing the SR to the XenServer pools, as “there will be VDIs with duplicated UUIDs“. The VDIs are the same, but they are seen in different SRs, and therefore cause an error.

The solution to avoid race conditions between management servers is to use a deterministic srUuid for the file SR to be created (we are leaving XenServer with the burden of managing race conditions). The UUID is based on the SR file path and is generated using  UUID#nameUUIDFromBytes. Therefore, if there is an SR with the generated UUID, this means that some other management server has just created it. An exception will occur and it will contain a message saying 'Db_exn.Uniqueness_constraint_violation'. In these unlikely events, we catch the exception and use the method retrieveAlreadyConfiguredSrWithoutException to get the SR that has already been created for the given mount point.
2018-03-29 15:55:42 -03:00
Mike Tutkowski
e68f5cea67 Only use the host if its Resource State is Enabled. (#2512) 2018-03-29 17:43:22 +00:00
Rafael Weingärtner
3868886546
Fix the name of the column used to hold IPv4 range in 'vlan' table. (#2492) 2018-03-29 10:39:19 -03:00
Rafael Weingärtner
36f4645154 [CLOUDSTACK-10332] Users are not able to change/edit the protocol of an ACL rule (#2496)
* [CLOUDSTACK-10332] Users are not able to change/edit the protocol of an ACL rule

* Code formatting
2018-03-29 08:06:50 +00:00
ernjvr
7647e104b2 CLOUDSTACK-10278 idempotent column addition (#2449)
* CLOUDSTACK-10278 - WIP: need to test this script before create a pull request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all lines, that end with a semicolon in existing proc, onto one line because com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored procs

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all lines, that end with a semicolon in existing proc, onto one line because com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored procs
2018-03-28 11:19:08 +00:00
lzh3636
c1c587fffe CLOUDSTACK-10334: Fix inadequate information for handling catch clauses (#2510)
* Add log stack traces

* Change log stack traces

Add original stack trace to the new throw and delete the error logs
2018-03-28 07:02:15 -03:00
Rohit Yadav
ba61b512b2 [Merge 4.11] CLOUDSTACK-10341: Reduce systemvmtemplate size (#2506)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2018-03-28 13:21:59 +05:30
Rohit Yadav
986ecfa7e9
CLOUDSTACK-10341: Reduce systemvmtemplate size, install nftables (#2506)
This reduces systemvmtemplate size by 600MB and installs nftables,
updates iptables. This also fixes a failing smoke test.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2018-03-28 13:11:51 +05:30
Rohit Yadav
95d10c251a
[Merge 4.11] CLOUDSTACK-10227: Fix mkdir path for centos rpms (#2513)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2018-03-27 22:53:59 +05:30
Rohit Yadav
48e6989da4
CLOUDSTACK-10227: Fix mkdir path for centos rpms (#2513)
This fixes the mkdir path `/usr/bin` for el6/7 rpms.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2018-03-27 22:52:37 +05:30
Rohit Yadav
8f881ce08b [Merge 4.11] CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer (#2465)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2018-03-27 17:12:26 +05:30
Rafael Weingärtner
0afcec60f4 [CLOUDSTACK-10307] Remove unused things from HostDaoImpl (#2438)
* Remove unused code from CloudZonesStartupProcessor

* Removed unused @Component annotation from HostDaoImpl And unused method
2018-03-27 10:46:25 +00:00
Khosrow Moossavi
535e6153cc CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer (#2465)
Publishing boot args both to grub and xenstore-data and let
cloud-early-config decides if the VM is in PV or HVM mode
to read from correct source.
2018-03-27 15:48:37 +05:30
Rohit Yadav
9222da2d62 [Merge 4.11] CLOUDSTACK-10319: Allow TLSv1, v1.1 for XenServer, Vmware (#2507)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2018-03-26 14:17:57 +05:30
Rohit Yadav
c4cc679c3b
CLOUDSTACK-10319: Allow TLSv1, v1.1 for XenServer, Vmware (#2507)
This reverts changes from #2480, instead moves TLS settings to
java ciphers settings config file. It should be sufficient to enforce
TLS v1.2 on public facing CloudStack services:
- CloudStack webserver (Jetty based)
- Apache2 for secondary storage VM
- CPVM HTTPs server

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2018-03-26 14:16:49 +05:30
Wido den Hollander
9733a10ecd CLOUDSTACK-10221: Allow IPv6 when creating a Basic Network (#2397)
Since CloudStack 4.10 Basic Networking supports IPv6 and thus
should be allowed to be specified when creating a network.

Signed-off-by: Wido den Hollander <wido@widodh.nl>
2018-03-26 07:36:57 +00:00
Marc-Aurèle Brothier
ca1760a46b CLOUDSTACK-10320 - Invalid pair for response object breaking response parsing (#2481) 2018-03-23 16:55:22 +00:00
Rohit Yadav
9753cc3681 Merge branch '4.11'
CLOUDSTACK-10341: VR minor fixes to systemvmtemplate (#2468)
CLOUDSTACK-10340: Add setter to hypervisorType in VMInstanceVO (#2504)

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2018-03-23 12:00:20 +05:30
René Moser
c8dcc64b65 CLOUDSTACK-10341: VR minor fixes to systemvmtemplate (#2468)
- Fixes rsyslog: fix config error in rsylslog.conf

Feb 26 08:09:54 r-413-VM liblogging-stdlog[19754]: action '*' treated as ':omusrmsg:*' - please use ':omusrmsg:*' syntax instead, '*' will not be supported in the future [v8.24.0 try http://www.rsyslog.com/e/2184 ]
Feb 26 08:09:54 r-413-VM liblogging-stdlog[19754]: error during parsing file /etc/rsyslog.conf, on or before line 95: warnings occured in file '/etc/rsyslog.conf' around line 95 [v8.24.0 try http://www.rsyslog.com/e/2207 ]

- Run apache2 only after cloud-postinit

- Increase /run size for VR with 256M RAM

root@r-395-VM:~# systemctl daemon-reload
Failed to reload daemon: Refusing to reload, not enough space available on /run/systemd. Currently, 15.8M are free, but a safety buffer of 16.0M is enforced.

tmpfs            23M  6.5M   16M  29% /run
2018-03-23 11:52:29 +05:30
Rohit Yadav
2a068696f8
CLOUDSTACK-10340: Add setter to hypervisorType in VMInstanceVO (#2504)
This adds a missing setter to set hypervisorType in VMInstanceVO.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2018-03-23 11:48:13 +05:30
Rohit Yadav
1ee66e0165 Updating pom.xml version numbers for release 4.9.3.1
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
4.9.3.1
2018-03-22 11:37:50 +05:30
Rohit Yadav
d9fb660df9 CLOUDSTACK-10322: Fix Robot Attack upgrade bountycastle
This upgrades bountycasle version v1.59 to fix for robot attack.
In addition, this disables TLSv1.0 as it is deprecated both in
use by management server, agents and in apache2 configs.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2018-03-22 11:10:43 +05:30
nvazquez
1c99fd7388 Merge branch '4.11' 2018-03-21 08:12:59 -03:00
Olivier Lemasle
3e62ce9c1b CLOUDSTACK-10331: Remove reference to deleted script vm_snapshots.js (#2497) 2018-03-21 08:00:17 -03:00
Nicolas Vazquez
6a75423779 CLOUDSTACK-10231: Asserted fixes for Direct Download on KVM (#2408)
Several fixes addressed:

- Dettach ISO fails when trying to detach a direct download ISO
- Fix for metalink support on SSVM agents (this closes CLOUDSTACK-10238)
- Reinstall VM from bypassed registered template (this closes CLOUDSTACK-10250)
- Fix upload certificate error message even though operation was successful
- Fix metalink download, checksum retry logic and metalink SSVM downloader
2018-03-20 19:24:46 +05:30
Rafael Weingärtner
cd3a128090
[CLOUDSTACK-10329] Button in ACL rules page to export all rules as a CSV file (#2494) 2018-03-20 07:36:24 -03:00
Khosrow Moossavi
af52b1a873 CLOUDSTACK-10268: Fix typo (#2495)
This fixes typo introduced in PR #2433
2018-03-19 11:46:29 +05:30
Rohit Yadav
9645d9c34c Merge branch '4.11' 2018-03-19 11:42:22 +05:30
Rohit Yadav
1ad04cbc9b
CLOUDSTACK-10330: Add PULL_REQUEST_TEMPLATE (#2489)
This adds a standard pull request template.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2018-03-19 11:40:57 +05:30
Rafael Weingärtner
8a3943b763 CLOUDSTACK-10132: Fix POM of "agent-lb" project (#2491)
Post fwd merging, this fixes build issues.
2018-03-16 08:04:22 +05:30