Daan Hoogland
87fb09997d
CLOUDSTACK-8656: return false from equals if not the same class
...
why ignore the exception and then return false anyway?
2015-08-04 14:38:48 +02:00
Daan Hoogland
21fd2b9b8e
CLOUDSTACK-8656: config file closing should not throw an exception
...
but log it if it does anyway
2015-08-04 14:37:07 +02:00
Daan Hoogland
e2b6237464
CLOUDSTACK-8656: debug messages on interupted exceptions
2015-07-30 16:03:10 +02:00
Daan Hoogland
85e002b230
CLOUDSTACK-8656: filling empty catch block with info messages
...
using regexp "catch\s*\(\s*(Exception|Throwable)\s*\w*\)\s*\{\s*\}"
2015-07-30 15:51:52 +02:00
Sten Spans
e63a56d650
Update NiciraNvpGuestNetworkGuruTest.java
...
add partial vxlan tests
2015-07-30 12:47:49 +02:00
Sten Spans
d03505acc2
Update NiciraNvpGuestNetworkGuru.java
...
Add support for VXLAN as isolation method
2015-07-29 15:45:41 +02:00
wilderrodrigues
96ad6f6ccd
CLOUDSTACK-8590 - Refactoring NiciraNVP resource
...
- Change the retry() method to return Answer.createUnsupportedCommandAnswer(command) instead of throwing an exception
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
This closes #546
2015-07-01 15:04:58 +02:00
wilderrodrigues
c6013303e9
CLOUDSTACK-8590 - Refactoring NiciraNVP resource
...
- Increasing test coverage
- resource package: 86.7%
- utils package: 95.1%
- wrapper package: 97.5%
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-07-01 15:04:58 +02:00
wilderrodrigues
644458f5ac
CLOUDSTACK-8590 - Refactoring NiciraNVP resource
...
- Adding remaining command wrappers
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-07-01 15:04:58 +02:00
wilderrodrigues
b54126918b
CLOUDSTACK-8590 - Refactoring NiciraNVP resource
...
- Adding NiciraNvpCreateLogicalRouterCommandWrapper
- Adding NiciraNvpDeleteLogicalSwitchPortCommandWrapper
- Adding NiciraNvpFindLogicalSwitchPortCommandWrapper
- Adding NiciraNvpUpdateLogicalSwitchPortCommandWrapper
- Decoupling private methods from NiciraNvpResource
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-07-01 15:04:57 +02:00
wilderrodrigues
b4ce81ab6c
CLOUDSTACK-8590 - Refactoring NiciraNVP resource
...
- Adding NiciraNvpDeleteLogicalSwitchPortCommandWrapper
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-07-01 15:04:57 +02:00
wilderrodrigues
361ab5ddbd
CLOUDSTACK-8590 - Refactoring NiciraNVP resource
...
- Adding NiciraNvpCreateLogicalSwitchPortCommandWrapper
- Removing unsued field from NiciraNvpResourceTest
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-07-01 15:04:57 +02:00
wilderrodrigues
28c1da969d
CLOUDSTACK-8590 - Refactoring NiciraNVP resource
...
- Adding command wrappers NiciraNvpCreateLogicalSwitchCommandWrapper and NiciraNvpDeleteLogicalSwitchCommandWrapper
- Refactoring the retry mechanism
- Applying the new retry mechanism to current wrappers and old methods in NiciraNvpResource
- Adding 2 tests
- Fixing the testRetries() in NiciraNvpResourceTest class
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-07-01 15:04:57 +02:00
wilderrodrigues
27c9651b32
CLOUDSTACK-8590 - Refactoring NiciraNVP resource
...
- Refactoring NiciraNvpResource
- Added NiciraNvpUtilities and NiciraNvpCreateLogicalSwitchCommandWrapper
- Removing 1 execute methods form NiciraNvpResource
- Added 1 unit test
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-07-01 15:04:56 +02:00
wilderrodrigues
6a51294d19
CLOUDSTACK-8590 - Refactoring NiciraNVP resource
...
- Refactoring NiciraNvpResource
- Added NiciraNvpMaintainCommandWrapper
- Removing 1 execute methods form NiciraNvpResource
- Added 1 unit test
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-07-01 15:04:56 +02:00
wilderrodrigues
0d943d5426
CLOUDSTACK-8590 - Refactoring NiciraNVP resource
...
- Refactoring NiciraNvpResource
- Added NiciraNvpRequestWrapper
- Removing 1 execute methods form NiciraNvpResource
- Added 1 unit test
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-07-01 15:04:56 +02:00
wilderrodrigues
fc478604e8
CLOUDSTACK-8590 - Refactoring NiciraNVP resource
...
- Adding the NiciraNvpWrapper
- This class will keep track of all Wrappers of the Nicira NVP Plugin
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-07-01 15:04:56 +02:00
Rafael da Fonseca
34d097f349
Fix 4 findbugs warnings in JuniperSrxResource Data should be read and written in UTF-8 to the SRX Buffers were being used for reading but not for writing, PrintWriter was auto-flushing and code was explicitly flushing again, causing unnecessary operation to be performed.
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #399
2015-06-15 21:49:43 +03:00
Rafael da Fonseca
6f330f7ab6
Fix findbugs warning in PaloAltoResource.java Unnecessary boxing/unboxing of primitive value
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #427
2015-06-15 12:09:43 +03:00
Rafael da Fonseca
1494487f72
Fix findbugs warning in NetscalerResource.java Unnecessary boxing/unboxing of primitive value
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #426
2015-06-15 12:09:41 +03:00
Rafael da Fonseca
980d858c34
Add import statements, remove unused FileReader import
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #393
2015-06-15 12:07:49 +03:00
Rafael da Fonseca
9ad8c70baa
Fix findbugs encoding warning, all .xml files contain only utf-8/us-ascii compatible characters
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-06-15 12:07:49 +03:00
Rafael da Fonseca
509c83bc74
Fix findbugs encoding warning in JuniperSrxResource All .xml files contain only utf-8/us-ascii compatible characters. If special characters are added to these files in the future, UTF-8 should be used for cross platform compatibility
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #398
2015-06-15 12:03:56 +03:00
Rafael da Fonseca
aeccd8afdf
Fix findbugs encoding issue This is done by calling HttpMethodBase's getResponseBodyAsString() which properly lookup the specified encoding in the request's Content-Type header This also avoids instantiation of two extra strings on the println() and return statements
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #394
2015-06-15 11:59:09 +03:00
Rafael da Fonseca
c5437d216f
Fix malformed closing tag on comments in cisco .xml files
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #369
2015-06-08 09:41:13 +02:00
Rafael da Fonseca
b9b13d764d
Fix another case of unnecessary boxing JuniperSrxResource.java:1280, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.JuniperSrxResource.removeDestinationNatRules(Long, Map, List)
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #367
2015-06-08 09:41:07 +02:00
Rafael da Fonseca
039d632ad3
Fix 3 more findbugs performance alerts, creating Long and Integer unnecessarily F5BigIpResource.java:297, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:703, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:889, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.F5BigIpResource
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #366
2015-06-08 09:40:59 +02:00
Rafael da Fonseca
9bac84a3f7
Fix last ocurrence of unnecessary boxing detected by findbugs CiscoVnmcResource.java:266, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.CiscoVnmcResource.getIpRangeFromCidr(String)
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #368
2015-06-08 09:39:02 +02:00
Rafael da Fonseca
65383fb8fa
Fix another findbugs high priority warning JuniperSrxResource.java:2617, ES_COMPARING_STRINGS_WITH_EQ, Priority: High Comparison of String objects using == or != in com.cloud.network.resource.JuniperSrxResource.manageApplication(JuniperSrxResource$SecurityPolicyType, JuniperSrxResource$SrxCommand, JuniperSrxResource$Protocol, int, int)
...
This now correctly compares strings
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #364
2015-06-08 09:30:38 +02:00
Koushik Das
d423df66cc
CLOUDSTACK-8301: Enable configuring local storage use for system VMs at zone level
...
Code cleanup, added helper method to get default system offering based on "system.vm.use.local.storage".
2015-05-19 21:32:14 +05:30
Koushik Das
3f7e31ed05
CLOUDSTACK-8301: Enable configuring local storage use for system VMs at zone level
...
Made system.vm.use.local.storage a zone level configuration.
2015-05-19 21:32:14 +05:30
Rohit Yadav
069aa4e5f3
CLOUDSTACK-8433: remove awsapi db usage and add upgrade cleanup path
...
- Removes awsapi db properties usage across codebase
- Removes references from spring xmls, test cases and TransactionLegacy
- Adds sql command to drop database cloudbridge in schema-451to460-cleanup.sql
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-06 15:22:04 +02:00
Rohit Yadav
df3dea58a2
CLOUDSTACK-6139: Fix regression, allow zone level systemvm localstorage config
...
From b3f18e7d74a0f09db9977554a6c7648b7edbc33d, the zone level systemvm local
storage setting never worked as it needed to be moved to config depot.
(cherry picked from commit 279efb04324249a2e1a5487b58b40a723baf4600)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
2015-05-01 15:27:40 +02:00
KC Wang
581f3b79a3
findbugs and PMD fixes
...
This closes #168
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
2015-04-15 11:30:04 +05:30
Daan Hoogland
e459ccfa6b
rat: new license copy from sibling test class
2015-04-12 19:56:00 -05:00
Daan Hoogland
951ffb1f03
empty comments needed for license?
2015-04-13 02:07:56 +02:00
Daan Hoogland
21e18b1e60
rats are rodents
2015-04-12 21:04:08 +02:00
Daan Hoogland
d3a98ab0d0
findbugs: comparison of wrapper classes should use equals
2015-04-12 21:00:21 +02:00
Daan Hoogland
67719b1be0
findbugs: pattern in used in split method
2015-04-12 20:57:20 +02:00
Daan Hoogland
6f2fb92364
findbugs: .equals() on wrapper class
2015-04-12 20:27:23 +02:00
Daan Hoogland
9f8a40acd5
findbugs: unnecesarry null return in utility function removed;
...
Category BAD_PRACTICE
2015-04-12 20:23:26 +02:00
KC Wang
01864ef77c
CLOUDSTACK-6697: bigswitch networking plugin update
...
1. provide compatibility with the Big Cloud Fabric (BCF) controller
L2 Connectivity Service in both VPC and non-VPC modes
2. virtual network terminology updates: VNS --> BCF_SEGMENT
3. uses HTTPS with trust-always certificate handling
4. topology sync support with BCF controller
5. support multiple (two) BCF controllers with HA
6. support VM migration
7. support Firewall, Static NAT, and Source NAT with NAT enabled option
8. add VifDriver for Indigo Virtual Switch (IVS)
This closes #151
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-09 13:02:02 +05:30
wilderrodrigues
3d22a16c4f
Bump priority stragety is no longer used for redundant virtual routers
...
- With the changes added by the rVPC work, the bump priority became deprecated.
This commit includes a refactor to get it removed from the following resources:
* Java classes
* domain_router table - removing the is_priority_bumpup column
* Fixing unit tests
All changes were tested with:
XenServer 6.2 running under our VMWare zone
CloudStack Management Server running on MacBook Pro
MySql running on MackBook Pro
Storage Type: Local
2015-04-02 21:50:49 +02:00
Rohit Yadav
3c429ee6b5
Merge remote-tracking branch 'sbp/feature/persisten-systemvm-redundant-vpc-REBASE'
...
This closes #118
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-17 15:44:57 +05:30
Antonio Fornie
09bd847040
Vpc redundancy enabled. Including Vpc & Vpc Offering creation. Marvin tests and UI.
2015-03-16 11:38:05 +01:00
Rajani Karuturi
843f6b1691
CLOUDSTACK-5236 : ability to identify where the user is from (ex. LDAP)
...
Added a source column to the user table.
Source now has only two values UNKNOWN,LDAP with UNKNOWN being the
default and is an enum is com.cloud.User.
When the source is UNKNOWN, the old method of authenticating against all
the available authenticators is used. If a source is available, only
that particular authenticator will be used.
added overloaded methods in AccountService to createUserAccount and
createUser with source specified.
(cherry picked from commit 5da733072e838c830720909ef5ba27ef6ce6d0b0)
2015-03-16 14:53:53 +05:30
Rohit Yadav
c8901a7990
utils: use a better extended implementation of SSLSocketFactory
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit b4a5a32a7488ecd93f295670e7f641fc32198aa7)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-13 17:32:07 +05:30
Funs
c27c69438b
hypervisors: add OVM3 plugin that supports OVM 3.2.1/3.3.x
...
This is a plugin that puts in ovm3 support ranging from 3.3.1 to 3.3.2. Basic
functionality is in here, advanced networking etc..
Snapshots only work when a VM is stopped now due to the semantics of OVM's raw
image implementation (so snapshots should work on a storage level underneath the
hypervisor shrug)
This closes #113
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-12 11:33:42 +05:30
Laszlo Hornyak
873649eb3b
CLOUDSTACK-8294: fix for java 1.8 build
...
The test testFindSecurityProfileByUuid built an assumptio on the order of the arguments after transforming through a HashMap.
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2015-03-01 13:20:51 +01:00
Rohit Yadav
a75ff23131
CLOUDSTACK-8273: fix baremetal account creation
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit e000646790597cb6c245311f57761b41d23a4e34)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalVlanManagerImpl.java
2015-02-27 15:55:09 +05:30