85 Commits

Author SHA1 Message Date
John Bampton
6f4503488b
pre-commit: apply end-of-file-fixer to all files (#7551) 2023-08-02 13:47:21 +02:00
John Bampton
11d45654a6
misc: fix spelling (#7206)
This PR fixes spellings
2023-05-23 11:06:16 +05:30
John Bampton
6401c850b7
Fix spelling (#6064)
* Fix spelling

- `interupted` to `interrupted`
- `paramter` to `parameter`

* Fix more typos
2022-03-08 13:02:35 -03:00
Daniel Augusto Veronezi Salvador
ddd2fcaf2d
Refactor few process of VirtualMachineManagerImpl and improve logs (#4966)
* Improve logs

* Remove unnecessary comments

* Use diamond inference

* Fix some logs

* Remove unnecessary unboxing

* Create method to handle job result

* Remove unused vars and fix some logics

* Extract code to method and few adjusts

* Use CollectionUtils

* Extract pending work job validation to method

* Create new constructors

* Extract work job and info creation to a method

* Extract submit async job to a method

* Extract find vm by id to a method

* Change log level from trace to debug

* Remove unnused methods and add logs

* Undo code remotion

* Remove asserts and fix conditionals

* Address @GabrielBrascher reviews

* Remove double quotes from keys in manual json

* Undo code remotion

* Add object to log

* Remove statement from try/catch

* Implement toString with ReflectionToStringBuilderUtils

* Fix errors related to merge main

Co-authored-by: Daniel Augusto Veronezi Salvador <daniel@scclouds.com.br>
2021-11-23 11:22:21 +01:00
Xia Li
f1149bcb09
[CLOUDSTACK-10408] Fix String.replaceAll() to replace() for bet… (#3275)
* [CLOUDSTACK-10408] Fix String.replaceAll() to replace() for better performance

* improve with replace char but string

Co-authored-by: Rohit Yadav <rohit@apache.org>
2020-01-30 12:06:15 +01:00
Marc-Aurèle Brothier
893a88d225 CLOUDSTACK-10105: Use maven standard project structure in all projects (#2283)
Remove maven standard module (which only a few were using) and get ride of maven customization for the projects structure.

- moved all directories to src/main/java, src/main/resources, src/main/scripts, src/test/java, src/test/resources
- grep scan to search for src/com and src/org left over
- grep for <project>/scripts to fix pom.xml configuration
- remove custom <build> configuration in pom.xml

Signed-off-by: Marc-Aurèle Brothier <m@brothier.org>
2018-01-20 03:19:27 +05:30
Rohit Yadav
abfcd5b95f CLOUDSTACK-9632: Upgrade bouncy castle to version 1.55
- Upgrades Maven dependency version to v1.55
- Fixes bountycastle usages and issues
- Adds timeout to jetty/annotation scanning
- Fixes servlet issue, uses servlet 3.1.0
- Downgrade javassist used by reflections to fix annotation process errors
- Make console-proxy-rdp bc dependency same as rest of the codebase
- Picks up PR #1510 by Daan

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2016-12-06 17:24:24 +05:30
Rodrigo
01034ea8d6 Removed Unused Void Class
Removed the class Void.java from
/cloud-framework-ipc/src/org/apache/cloudstack/framework/async/Void.java
since the method public void AsyncMethod(Object realParam,
AsyncCompletionCallback<Void> callback) does not 
exist and it does not seemed to be used in another place.
Also, removed an unnecessary comment in
/cloudstack-framework/ipc/test/org/apache/cloudstack/framework/codestyle/AsyncSampleListenerStyleCaller.java
2016-03-13 14:35:51 -03:00
Daan Hoogland
ea886910d8 CLOUDSTACK-8656: messages about classloader issues in ipc framwork 2015-08-04 14:06:06 +02:00
Daan Hoogland
e2b6237464 CLOUDSTACK-8656: debug messages on interupted exceptions 2015-07-30 16:03:10 +02:00
Daan Hoogland
85e002b230 CLOUDSTACK-8656: filling empty catch block with info messages
using regexp "catch\s*\(\s*(Exception|Throwable)\s*\w*\)\s*\{\s*\}"
2015-07-30 15:51:52 +02:00
Daan Hoogland
f15eaec254 coverity 1116759: possible null-pointer before indexOf-call move the if-block inside the next, guarded one
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #600
2015-07-17 13:12:26 +02:00
Daan Hoogland
8849d506cb coverity 1116718: neglected jarinputstream when no entry found
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-07-17 13:12:26 +02:00
Rafael da Fonseca
441a13252a Re-run travis
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #454
2015-06-17 12:15:23 +02:00
Rafael da Fonseca
9f7c379a88 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in RpcProviderImpl.java Assert isn't used in prod runtime
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-17 12:15:23 +02:00
Rafael da Fonseca
89a07084c5 Fix findbugs DMI_RANDOM_USED_ONLY_ONCE warning in TransportAddress.java Changed to recommended SecureRandom instead of Random
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #416
2015-06-15 12:09:22 +03:00
Rafael da Fonseca
4e0fe469dd Fix findbugs DMI_RANDOM_USED_ONLY_ONCE warning in ServerTransportProvider.java Changed to recommended SecureRandom instead of Random Moved initializers to constructor
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #415
2015-06-15 12:09:20 +03:00
Min Chen
ffaabdc13f CLOUDSTACK-7832: Move some job db update and item purge to
completeAsyncJob transaction to avoid MySQL deadlock.
2014-11-03 10:41:36 -08:00
Hugo Trippaers
a265d7b505 Fix a bug that prevented me from starting CS.
No idea why this error suddenly pops up, this is old (but wrong) code.
2014-10-29 16:59:00 +01:00
Santhosh Edukulla
0a9742f914 Fixed few coverity issues
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-10-14 17:16:50 +05:30
Min Chen
a2d85c8cae CLOUDSTACK-7566:Many jobs getting stuck in pending state and cloud is
unusable.
2014-09-16 15:14:08 -07:00
Santhosh Edukulla
0ca3b4a4e4 Fixed coverity reported concurrency issue
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-08-06 10:15:39 +05:30
Min Chen
25580c7cd1 CLOUDSTACK-6859:Management Server PermGen run out of memory after some
time due to class leak.
2014-06-06 23:57:26 -07:00
Kelven Yang
09ec127470 CLOUDSTACK-6743: Use edge-triggering in MessageDetector to handle bogus wakeup gracefully. Level triggering plus bogus wakeup can cause a tight loop to spin 2014-05-21 16:17:39 -07:00
Ding Yuan
c031eb7d38 CLOUDSTACK-6242: exception handling improvements
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-04-15 08:07:15 +02:00
Kelven Yang
66486d4322 BUG-ID: CS-19697: Deal with possible DB deadlock issue, return the job into queue for next turn 2014-04-02 14:59:04 -07:00
Kelven Yang
b6cc6dd8e3 CLOUDSTACK-6305: protect lock leaking from unhandled exception 2014-03-28 15:30:07 -07:00
Kelven Yang
7164fc6e73 CLOUDSTACK-5696: Fix sync issue with out-of-band changes 2014-01-15 13:11:02 -08:00
wilderrodrigues
226b193488 Fix for Coverity issues CID_1116744, CID_1116718 and CID_1116682, all related to resource leak
Signed-off-by: Daan Hoogland <daan@onecht.net>
2013-11-27 14:20:29 +01:00
Alex Huang
d620df2bdd Reformatted all of the code. 2013-11-21 06:15:26 -08:00
Alex Huang
224f479974 Removed trailing spaces 2013-11-21 04:08:01 -08:00
Alex Huang
e4b22d0fca Replace all tabs, particularly the ones in the comments 2013-11-21 03:39:58 -08:00
Alex Huang
8d62744681 Reformat all source code. Added checkstyle to check the source code 2013-11-20 07:26:53 -08:00
Darren Shepherd
aed5e9dc2a Add Manage Context framework
The managed context framework provides a simple way to add logic
to ACS at the various entry points of the system.  As threads are
launched and ran listeners can be registered for onEntry or onLeave
of the managed context.  This framework will be used specifically
to handle DB transaction checking and setting up the CallContext.
This framework is need to transition away from ACS custom AOP to
Spring AOP.
2013-10-02 13:09:52 -07:00
Alex Huang
4ba359c3fe Moved VirtualMachineManager into engine 2013-08-19 14:13:28 -07:00
Alex Huang
dd0536f9d3 Changed tabs to space 2013-08-02 11:07:54 -07:00
Alex Huang
1e1ee902a2 Moved over the new jobs framework from vmsync. This has not been integrated into the server package yet. Will do that next 2013-07-30 15:00:58 -07:00
Prasanna Santhanam
de38cd815f Fix typo in class name
AsyncRpcConext -> AsyncRpcContext

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-06-29 13:50:25 +05:30
Alex Huang
3047929367 Merged 2013-05-10 16:21:43 -07:00
Alex Huang
e0d8f01ecd Removed framework-api which is completely useless. Changed framework-ipc to reference gson itself. Move VOs into engine-schema. 2013-05-06 16:34:16 -07:00
Min Chen
db65dfbb12 Work around an issue in using IPC callback for
HypervisorTemplateAdapter.
2013-05-06 15:10:31 -07:00
Kelven Yang
d44e25efba add unit test to message bus in master branch 2013-04-29 14:36:03 -07:00
Kelven Yang
85e73d18f5 Refactor message bus facitlity to avoid confusing with event bus for external notification, planning to use it in VMSync 2013-04-29 14:36:03 -07:00
Edison Su
a22403edcd squash changes into one giant patch 2013-02-21 11:22:48 -08:00
Kelven Yang
ed17281f0d Accissibility fix when invoking callback method 2013-01-03 17:55:47 -08:00
Kelven Yang
3435ee0604 Get rid of due-mode in AsyncCallFuture, it is too confusing and we don't have a use case of it 2013-01-03 17:43:32 -08:00
Kelven Yang
107fccdf69 Add AsyncCallFuture 2013-01-03 17:24:26 -08:00
Kelven Yang
6504fc6b09 Enforce strong typing for getting result from AsyncMethod 2013-01-02 15:48:45 -08:00
Edison Su
d99161399e so many traps in rpc call: you can't use aop in a thread, you need to intercept finalize call etc 2012-12-24 02:37:32 -08:00
Kelven Yang
1d5019c3d0 add RPC client side implementation 2012-12-20 17:55:06 -08:00