diff --git a/api/src/com/cloud/event/EventTypes.java b/api/src/com/cloud/event/EventTypes.java index c69439bd471..8adf074e265 100755 --- a/api/src/com/cloud/event/EventTypes.java +++ b/api/src/com/cloud/event/EventTypes.java @@ -25,8 +25,7 @@ public class EventTypes { public static final String EVENT_VM_START = "VM.START"; public static final String EVENT_VM_STOP = "VM.STOP"; public static final String EVENT_VM_REBOOT = "VM.REBOOT"; - public static final String EVENT_VM_DISABLE_HA = "VM.DISABLEHA"; - public static final String EVENT_VM_ENABLE_HA = "VM.ENABLEHA"; + public static final String EVENT_VM_UPDATE = "VM.UPDATE"; public static final String EVENT_VM_UPGRADE = "VM.UPGRADE"; public static final String EVENT_VM_RESETPASSWORD = "VM.RESETPASSWORD"; diff --git a/server/src/com/cloud/vm/UserVmManagerImpl.java b/server/src/com/cloud/vm/UserVmManagerImpl.java index 838df1b1e33..e5e9ce5b5f4 100755 --- a/server/src/com/cloud/vm/UserVmManagerImpl.java +++ b/server/src/com/cloud/vm/UserVmManagerImpl.java @@ -3125,7 +3125,7 @@ public class UserVmManagerImpl implements UserVmManager, UserVmService, VirtualM } userId = accountAndUserValidation(id, account, userId,vmInstance); - + if (displayName == null) { displayName = vmInstance.getDisplayName(); } @@ -3140,25 +3140,31 @@ public class UserVmManagerImpl implements UserVmManager, UserVmService, VirtualM throw new CloudRuntimeException("Unable to find virual machine with id " + id); } - if (group != null) { - addInstanceToGroup(id, group); + String description = ""; + + if(displayName != vmInstance.getDisplayName()){ + description += "New display name: "+displayName+". "; + } + + if(ha != vmInstance.isHaEnabled()){ + if(ha){ + description += "Enabled HA. "; + } else { + description += "Disabled HA. "; + } } - boolean haEnabled = vm.isHaEnabled(); - _vmDao.updateVM(id, displayName, ha); - if (haEnabled != ha) { - String description = null; - String type = null; - if (ha) { - description = "Successfully enabled HA for virtual machine " + vm.getHostName(); - type = EventTypes.EVENT_VM_ENABLE_HA; - } else { - description = "Successfully disabled HA for virtual machine " + vm.getHostName(); - type = EventTypes.EVENT_VM_DISABLE_HA; + + if (group != null) { + if(addInstanceToGroup(id, group)){ + description += "Added to group: "+group+"."; } - // create a event for the change in HA Enabled flag - EventUtils.saveEvent(userId, accountId, EventVO.LEVEL_INFO, type, description, null); } + + _vmDao.updateVM(id, displayName, ha); + + // create a event for the change in HA Enabled flag + EventUtils.saveEvent(userId, accountId, EventVO.LEVEL_INFO, EventTypes.EVENT_VM_UPDATE, "Successfully updated virtual machine: "+vm.getHostName()+". "+description, null); return _vmDao.findById(id); }