apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Update error message when no snapshot strategy is found while creating snapshot (#11455)

Browse Source
This commit is contained in:
João Jandre 2025-08-18 05:44:20 -03:00 committed by GitHub
parent 5a90da3276
commit f2d635683b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
View File

@ -2795,6 +2795,8 @@ public class VolumeServiceImpl implements VolumeService {
} catch (CloudRuntimeException cre) { } catch (CloudRuntimeException cre) {
logger.error("Take snapshot: {} failed", volume, cre); logger.error("Take snapshot: {} failed", volume, cre);
throw cre; throw cre;
} catch (UnsupportedOperationException ex) {
throw ex;
} catch (Exception e) { } catch (Exception e) {
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
logger.debug("unknown exception while taking snapshot for volume {} was caught", volume, e); logger.debug("unknown exception while taking snapshot for volume {} was caught", volume, e);

6
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
View File

@ -3814,10 +3814,8 @@ public class VolumeApiServiceImpl extends ManagerBase implements VolumeApiServic
@Override @Override
@ActionEvent(eventType = EventTypes.EVENT_SNAPSHOT_CREATE, eventDescription = "taking snapshot", async = true) @ActionEvent(eventType = EventTypes.EVENT_SNAPSHOT_CREATE, eventDescription = "taking snapshot", async = true)
public Snapshot takeSnapshot(Long volumeId, Long policyId, Long snapshotId, Account account, boolean quiescevm, public Snapshot takeSnapshot(Long volumeId, Long policyId, Long snapshotId, Account account, boolean quiescevm, Snapshot.LocationType locationType, boolean asyncBackup,
Snapshot.LocationType locationType, boolean asyncBackup, Map<String, String> tags, List<Long> zoneIds, List<Long> poolIds, Boolean useStorageReplication) Map<String, String> tags, List<Long> zoneIds, List<Long> poolIds, Boolean useStorageReplication) throws ResourceAllocationException {
throws ResourceAllocationException {
final Snapshot snapshot = takeSnapshotInternal(volumeId, policyId, snapshotId, account, quiescevm, locationType, asyncBackup, zoneIds, poolIds, useStorageReplication); final Snapshot snapshot = takeSnapshotInternal(volumeId, policyId, snapshotId, account, quiescevm, locationType, asyncBackup, zoneIds, poolIds, useStorageReplication);
if (snapshot != null && MapUtils.isNotEmpty(tags)) { if (snapshot != null && MapUtils.isNotEmpty(tags)) {
taggedResourceService.createTags(Collections.singletonList(snapshot.getUuid()), ResourceTag.ResourceObjectType.Snapshot, tags, null); taggedResourceService.createTags(Collections.singletonList(snapshot.getUuid()), ResourceTag.ResourceObjectType.Snapshot, tags, null);

5
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
View File

@ -1621,7 +1621,8 @@ public class SnapshotManagerImpl extends MutualExclusiveIdsManagerBase implement
if (snapshotStrategy == null) { if (snapshotStrategy == null) {
_snapshotDao.remove(snapshotId); _snapshotDao.remove(snapshotId);
logger.debug("No strategy found for creation of snapshot [{}], removing its record from the database.", snapshot); logger.debug("No strategy found for creation of snapshot [{}], removing its record from the database.", snapshot);
throw new CloudRuntimeException(String.format("Can't find snapshot strategy to deal with snapshot:%s", snapshot.getSnapshotVO())); throw new UnsupportedOperationException(String.format("Unable to find a snapshot strategy to create snapshot [%s] of volume [%s]. Please check the logs.",
snapshot.getSnapshotVO(), volume.getUuid()));
} }
SnapshotInfo snapshotOnPrimary = snapshotStrategy.takeSnapshot(snapshot); SnapshotInfo snapshotOnPrimary = snapshotStrategy.takeSnapshot(snapshot);
@ -1672,7 +1673,7 @@ public class SnapshotManagerImpl extends MutualExclusiveIdsManagerBase implement
} catch (Exception e) { } catch (Exception e) {
logger.debug("post process snapshot failed", e); logger.debug("post process snapshot failed", e);
} }
} catch (CloudRuntimeException cre) { } catch (CloudRuntimeException | UnsupportedOperationException cre) {
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
logger.debug("Failed to create snapshot" + cre.getLocalizedMessage()); logger.debug("Failed to create snapshot" + cre.getLocalizedMessage());
} }