bug 11513: another customer hits the same issue by associate ip in the basic zone

Reviewed-by: alena@citrix.com
This commit is contained in:
Edison Su 2011-09-21 19:11:37 -07:00
parent 211c7099a6
commit ee59c26e93

View File

@ -552,7 +552,7 @@ public class NetworkManagerImpl implements NetworkManager, NetworkService, Manag
if (ipOwner == null) {
throw new InvalidParameterValueException("Unable to find account " + accountName + " in domain " + domainId + ", permission denied");
}
_accountMgr.checkAccess(caller, null, ipOwner);
DataCenterVO zone = null;
@ -561,6 +561,10 @@ public class NetworkManagerImpl implements NetworkManager, NetworkService, Manag
if (zone == null) {
throw new InvalidParameterValueException("Can't find zone by id " + zoneId);
}
if (zone.getNetworkType() == NetworkType.Basic) {
throw new InvalidParameterValueException("Can't associate ip in basic zone");
}
if (Grouping.AllocationState.Disabled == zone.getAllocationState() && !_accountMgr.isRootAdmin(caller.getType())) {
throw new PermissionDeniedException("Cannot perform this operation, Zone is currently disabled: " + zoneId);