apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-11-02 11:52:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

CLOUDSTACK-7706: Coverity defects

Browse Source 
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
This commit is contained in:
Harikrishna Patnala 2014-11-11 15:00:42 +05:30 committed by Santhosh Edukulla
parent 5759857ffc
commit edf1047a20
6 changed files with 4 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
View File

@ -167,15 +167,15 @@ public class CreateServiceOfferingCmd extends BaseCmd {
}
public Boolean getOfferHa() {
return offerHa == null ? false : offerHa;
return offerHa == null ? Boolean.FALSE : offerHa;
}
public Boolean GetLimitCpuUse() {
return limitCpuUse == null ? false : limitCpuUse;
return limitCpuUse == null ? Boolean.FALSE : limitCpuUse;
}
public Boolean getVolatileVm() {
return isVolatile == null ? false : isVolatile;
return isVolatile == null ? Boolean.FALSE : isVolatile;
}
public String getStorageType() {

2
api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java
View File

@ -227,7 +227,7 @@ public class RegisterTemplateCmd extends BaseCmd {
}
public Boolean isDynamicallyScalable() {
return isDynamicallyScalable == null ? false : isDynamicallyScalable;
return isDynamicallyScalable == null ? Boolean.FALSE : isDynamicallyScalable;
}
public Boolean isRoutingType() {

3
api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java
View File

@ -43,9 +43,6 @@ public class ListCfgCmdTest extends TestCase {
private ManagementService mgr;
private ResponseGenerator responseGenerator;
@Rule
public ExpectedException expectedException = ExpectedException.none();
@Override
@Before
public void setUp() {

3
api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java
View File

@ -40,9 +40,6 @@ public class UpdateCfgCmdTest extends TestCase {
private ConfigurationService configService;
private ResponseGenerator responseGenerator;
@Rule
public ExpectedException expectedException = ExpectedException.none();
@Override
@Before
public void setUp() {

4
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
View File

@ -1950,10 +1950,6 @@ public class ConfigurationManagerImpl extends ManagerBase implements Configurati
DomainVO domainVO = null;
if (userId == null) {
userId = User.UID_SYSTEM;
}
if (domainId != null) {
domainVO = _domainDao.findById(domainId);
}

3
server/src/com/cloud/server/ManagementServerImpl.java
View File

@ -1696,9 +1696,6 @@ public class ManagementServerImpl extends ManagerBase implements ManagementServe
if (scope != null && !scope.isEmpty()) {
// getting the list of parameters at requested scope
if (id == null) {
throw new InvalidParameterValueException("Invalid id null, id is needed corresponding to the scope");
}
sc.addAnd("scope", SearchCriteria.Op.EQ, scope);
}