From be781804f1eba28d028a7ecfb57b08a47679b22b Mon Sep 17 00:00:00 2001
From: Hoang Nguyen <hoangnm@unitech.vn>
Date: Tue, 6 Apr 2021 19:05:58 +0700
Subject: [PATCH 1/3] ui: fix physical network setup in zone wizard (#4892)

---
 .../views/infra/zone/ZoneWizardLaunchZone.vue | 18 +++----
 .../ZoneWizardPhysicalNetworkSetupStep.vue    | 50 +++++++++----------
 2 files changed, 34 insertions(+), 34 deletions(-)

diff --git a/ui/src/views/infra/zone/ZoneWizardLaunchZone.vue b/ui/src/views/infra/zone/ZoneWizardLaunchZone.vue
index d456827d8a1..7191f1935fd 100644
--- a/ui/src/views/infra/zone/ZoneWizardLaunchZone.vue
+++ b/ui/src/views/infra/zone/ZoneWizardLaunchZone.vue
@@ -222,13 +222,13 @@ export default {
         this.$emit('stepError', step, this.stepData)
       }
     },
-    trafficLabelParam (trafficTypeID, physicalNetworkID) {
+    trafficLabelParam (trafficTypeID, physicalNetworkIndex) {
       const hypervisor = this.prefillContent.hypervisor.value
-      physicalNetworkID = this.isAdvancedZone ? physicalNetworkID : 0
+      physicalNetworkIndex = this.isAdvancedZone ? physicalNetworkIndex : 0
       let physicalNetwork = []
       let trafficConfig = null
       if (this.prefillContent.physicalNetworks) {
-        physicalNetwork = this.prefillContent.physicalNetworks[0].traffics.filter(traffic => traffic.type === trafficTypeID)
+        physicalNetwork = this.prefillContent.physicalNetworks[physicalNetworkIndex].traffics.filter(traffic => traffic.type === trafficTypeID)
         trafficConfig = physicalNetwork.length > 0 ? physicalNetwork[0] : null
       }
       let trafficLabel
@@ -476,13 +476,13 @@ export default {
             try {
               if (!this.stepData.stepMove.includes('addTrafficType' + index + key)) {
                 if (traffic.type === 'public') {
-                  await this.addTrafficType('Public')
+                  await this.addTrafficType('Public', index)
                 } else if (traffic.type === 'management') {
-                  await this.addTrafficType('Management')
+                  await this.addTrafficType('Management', index)
                 } else if (traffic.type === 'guest') {
-                  await this.addTrafficType('Guest')
+                  await this.addTrafficType('Guest', index)
                 } else if (traffic.type === 'storage') {
-                  await this.addTrafficType('Storage')
+                  await this.addTrafficType('Storage', index)
                 }
                 this.stepData.stepMove.push('addTrafficType' + index + key)
               }
@@ -1605,8 +1605,8 @@ export default {
         })
       })
     },
-    addTrafficType (trafficType) {
-      const getTrafficParams = this.trafficLabelParam(trafficType.toLowerCase())
+    addTrafficType (trafficType, index) {
+      const getTrafficParams = this.trafficLabelParam(trafficType.toLowerCase(), index)
       let params = {}
 
       params.trafficType = trafficType
diff --git a/ui/src/views/infra/zone/ZoneWizardPhysicalNetworkSetupStep.vue b/ui/src/views/infra/zone/ZoneWizardPhysicalNetworkSetupStep.vue
index 08ed2382af0..2ea3f390524 100644
--- a/ui/src/views/infra/zone/ZoneWizardPhysicalNetworkSetupStep.vue
+++ b/ui/src/views/infra/zone/ZoneWizardPhysicalNetworkSetupStep.vue
@@ -60,31 +60,6 @@
             <a-icon type="delete" class="traffic-type-action" @click="deleteTraffic(record.key, traffic, $event)"/>
           </a-tag>
         </div>
-        <a-modal
-          :title="$t('label.edit.traffic.type')"
-          :visible="showEditTraffic"
-          :closable="true"
-          :maskClosable="false"
-          :okText="$t('label.ok')"
-          :cancelText="$t('label.cancel')"
-          @ok="updateTrafficLabel(trafficInEdit)"
-          @cancel="cancelEditTraffic"
-          centered
-        >
-          <a-form :form="form">
-            <span class="ant-form-text"> {{ $t('message.edit.traffic.type') }} </span>
-            <a-form-item v-bind="formItemLayout" style="margin-top:16px;" :label="$t('label.traffic.label')">
-              <a-input
-                v-decorator="['trafficLabel', {
-                  rules: [{
-                    required: true,
-                    message: $t('message.error.traffic.label'),
-                  }]
-                }]"
-              />
-            </a-form-item>
-          </a-form>
-        </a-modal>
         <div v-if="isShowAddTraffic(record.traffics)">
           <div class="traffic-select-item" v-if="addingTrafficForKey === record.key">
             <a-select
@@ -162,6 +137,31 @@
     >
       <span>{{ $t('message.required.traffic.type') }}</span>
     </a-modal>
+    <a-modal
+      :title="$t('label.edit.traffic.type')"
+      :visible="showEditTraffic"
+      :closable="true"
+      :maskClosable="false"
+      :okText="$t('label.ok')"
+      :cancelText="$t('label.cancel')"
+      @ok="updateTrafficLabel(trafficInEdit)"
+      @cancel="cancelEditTraffic"
+      centered
+    >
+      <a-form :form="form">
+        <span class="ant-form-text"> {{ $t('message.edit.traffic.type') }} </span>
+        <a-form-item v-bind="formItemLayout" style="margin-top:16px;" :label="$t('label.traffic.label')">
+          <a-input
+            v-decorator="['trafficLabel', {
+              rules: [{
+                required: true,
+                message: $t('message.error.traffic.label'),
+              }]
+            }]"
+          />
+        </a-form-item>
+      </a-form>
+    </a-modal>
   </div>
 </template>
 <script>

From 7208fac18be25c6518fd0fe5dd7efcba08b4e714 Mon Sep 17 00:00:00 2001
From: Miklos Barabas <mbarabas@gmail.com>
Date: Wed, 7 Apr 2021 07:54:07 +0200
Subject: [PATCH 2/3] mvn: using forked version of trilead-ssh2 (from
 org.jenkins-ci) (#4099)

* using forked version of trilead-ssh2 (from org.jenkins-ci)
- upgrade to support newer algorithms

* Update latest jar release

Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: Rohit Yadav <rohit@apache.org>
---
 pom.xml                                        | 18 ++++++++++++++++--
 test/pom.xml                                   |  2 +-
 utils/pom.xml                                  |  3 ++-
 .../java/com/cloud/utils/ssh/SshHelper.java    |  2 +-
 4 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/pom.xml b/pom.xml
index 9ac0bddebb8..f497032c69f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -165,7 +165,7 @@
         <cs.servicemix.version>3.4.4_1</cs.servicemix.version>
         <cs.servlet.version>4.0.1</cs.servlet.version>
         <cs.tomcat-embed-core.version>8.5.61</cs.tomcat-embed-core.version>
-        <cs.trilead.version>1.0.0-build222</cs.trilead.version>
+        <cs.trilead.version>build-217-jenkins-27</cs.trilead.version>
         <cs.vmware.api.version>6.7</cs.vmware.api.version>
         <cs.winrm4j.version>0.5.0</cs.winrm4j.version>
         <cs.xapi.version>6.2.0-3.1</cs.xapi.version>
@@ -334,7 +334,7 @@
                 <version>${cs.xstream.version}</version>
             </dependency>
             <dependency>
-                <groupId>com.trilead</groupId>
+                <groupId>org.jenkins-ci</groupId>
                 <artifactId>trilead-ssh2</artifactId>
                 <version>${cs.trilead.version}</version>
             </dependency>
@@ -739,6 +739,20 @@
         </dependency>
     </dependencies>
 
+    <repositories>
+        <repository>
+            <id>repo.jenkins-ci.org.releases</id>
+            <url>http://repo.jenkins-ci.org/releases/</url>
+            <snapshots>
+                <enabled>false</enabled>
+            </snapshots>
+        </repository>
+        <repository>
+            <id>repo.jenkins-ci.org.public</id>
+            <url>http://repo.jenkins-ci.org/public/</url>
+        </repository>
+    </repositories>
+
     <build>
         <defaultGoal>install</defaultGoal>
         <plugins>
diff --git a/test/pom.xml b/test/pom.xml
index 41112bf7ac1..735bcf26505 100644
--- a/test/pom.xml
+++ b/test/pom.xml
@@ -37,7 +37,7 @@
             <artifactId>log4j</artifactId>
         </dependency>
         <dependency>
-            <groupId>com.trilead</groupId>
+            <groupId>org.jenkins-ci</groupId>
             <artifactId>trilead-ssh2</artifactId>
         </dependency>
         <dependency>
diff --git a/utils/pom.xml b/utils/pom.xml
index 8612e8a25dc..481631d3cdd 100755
--- a/utils/pom.xml
+++ b/utils/pom.xml
@@ -79,8 +79,9 @@
             <artifactId>jasypt</artifactId>
         </dependency>
         <dependency>
-            <groupId>com.trilead</groupId>
+            <groupId>org.jenkins-ci</groupId>
             <artifactId>trilead-ssh2</artifactId>
+            <version>${cs.trilead.version}</version>
         </dependency>
         <dependency>
             <groupId>com.amazonaws</groupId>
diff --git a/utils/src/main/java/com/cloud/utils/ssh/SshHelper.java b/utils/src/main/java/com/cloud/utils/ssh/SshHelper.java
index 537ebe7277b..d5cd91aff76 100644
--- a/utils/src/main/java/com/cloud/utils/ssh/SshHelper.java
+++ b/utils/src/main/java/com/cloud/utils/ssh/SshHelper.java
@@ -260,7 +260,7 @@ public class SshHelper {
      * does not have an exit status, it returns true to break the loop; otherwise, it returns
      * false.
      */
-    protected static boolean canEndTheSshConnection(int waitResultTimeoutInMs, com.trilead.ssh2.Session sess, int conditions) throws SshException {
+    protected static boolean canEndTheSshConnection(int waitResultTimeoutInMs, com.trilead.ssh2.Session sess, int conditions) throws SshException, InterruptedException {
         if (isChannelConditionEof(conditions)) {
             int newConditions = sess.waitForCondition(ChannelCondition.EXIT_STATUS, waitResultTimeoutInMs);
             throwSshExceptionIfConditionsTimeout(newConditions);

From 262285639e356917459eba69e63abf3d19564047 Mon Sep 17 00:00:00 2001
From: Rakesh <rakeshv.com@gmail.com>
Date: Wed, 7 Apr 2021 07:55:52 +0200
Subject: [PATCH 3/3] kvm: Disable shrinking QCOW2 volumes (#4679)

Since QCOW2 volumes cannot be resized to lower value in any case,
just disable it in backend.
---
 .../main/java/com/cloud/storage/VolumeApiServiceImpl.java | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java b/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
index dc3bf04396d..9f956c898c7 100644
--- a/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
+++ b/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
@@ -1061,6 +1061,14 @@ public class VolumeApiServiceImpl extends ManagerBase implements VolumeApiServic
              * This will be checked again at the hypervisor level where we can see
              * the actual disk size.
              */
+            if (currentSize > newSize) {
+                VolumeVO vol = _volsDao.findById(cmd.getEntityId());
+                if (vol != null && ImageFormat.QCOW2.equals(vol.getFormat()) && !Volume.State.Allocated.equals(volume.getState())) {
+                    String message = "Unable to shrink volumes of type QCOW2";
+                    s_logger.warn(message);
+                    throw new InvalidParameterValueException(message);
+                }
+            }
             if (currentSize > newSize && !shrinkOk) {
                 throw new InvalidParameterValueException("Going from existing size of " + currentSize + " to size of " + newSize + " would shrink the volume."
                         + "Need to sign off by supplying the shrinkok parameter with value of true.");