apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixed coverity reported concurrency issues

Browse Source 
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
This commit is contained in:
Santhosh Edukulla 2014-08-05 12:13:45 +05:30
parent d26e5163d4
commit e4d6cd8e6a
2 changed files with 2 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/src/com/cloud/resource/ServerResourceBase.java
View File

@ -236,7 +236,7 @@ public abstract class ServerResourceBase implements ServerResource {
} }
protected List<String> getWarnings() { protected List<String> getWarnings() {
synchronized (this) { synchronized (_warnings) {
final ArrayList<String> results = _warnings; final ArrayList<String> results = _warnings;
_warnings = new ArrayList<String>(); _warnings = new ArrayList<String>();
return results; return results;
@ -244,7 +244,7 @@ public abstract class ServerResourceBase implements ServerResource {
} }
protected List<String> getErrors() { protected List<String> getErrors() {
synchronized (this) { synchronized (_errors) {
final ArrayList<String> result = _errors; final ArrayList<String> result = _errors;
_errors = new ArrayList<String>(); _errors = new ArrayList<String>();
return result; return result;

15
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java
View File

@ -577,21 +577,6 @@ public class AgentManagerImpl extends ManagerBase implements AgentManager, Handl
return attache; return attache;
} }
protected boolean notifyCreatorsOfConnection(StartupCommand[] cmd) throws ConnectionException {
boolean handled = false;
for (Pair<Integer, StartupCommandProcessor> monitor : _creationMonitors) {
if (s_logger.isDebugEnabled()) {
s_logger.debug("Sending Connect to creator: " + monitor.second().getClass().getSimpleName());
}
handled = monitor.second().processInitialConnect(cmd);
if (handled) {
break;
}
}
return handled;
}
@Override @Override
public boolean start() { public boolean start() {
startDirectlyConnectedHosts(); startDirectlyConnectedHosts();