apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-11-02 11:52:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

managed-storage: handle VM start in a new cluster on different host (#2656)

Browse Source 
Example: A VM that uses managed storage is stopped. The VM is then started on a different host in the same cluster. The Start operation fails.

To get around this issue, you must either start the VM up on the same host or on a host in a different cluster.

The reason is due to a slightly erroneous check in VolumeOrchestrator.prepare.

To solve this issue, we should be checking if the cluster ID changes, not if the host ID changes.
This commit is contained in:
Mike Tutkowski 2018-05-21 04:52:33 -06:00 committed by Rohit Yadav
parent acc5fdcdbd
commit e471a46a05
1 changed files with 16 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
View File

@ -1344,30 +1344,29 @@ public class VolumeOrchestrator extends ManagerBase implements VolumeOrchestrati
StoragePool pool;
for (VolumeTask task : tasks) {
if (task.type == VolumeTaskType.NOP) {
pool = (StoragePool)dataStoreMgr.getDataStore(task.pool.getId(), DataStoreRole.Primary);
if (task.pool != null && task.pool.isManaged()) {
long hostId = vm.getVirtualMachine().getHostId();
Host host = _hostDao.findById(hostId);
volService.grantAccess(volFactory.getVolume(task.volume.getId()), host, (DataStore)pool);
}
vol = task.volume;
// For a zone-wide managed storage, it is possible that the VM can be started in another
pool = (StoragePool)dataStoreMgr.getDataStore(task.pool.getId(), DataStoreRole.Primary);
// For zone-wide managed storage, it is possible that the VM can be started in another
// cluster. In that case, make sure that the volume is in the right access group.
if (pool.isManaged()) {
long oldHostId = vm.getVirtualMachine().getLastHostId();
long hostId = vm.getVirtualMachine().getHostId();
Host lastHost = _hostDao.findById(vm.getVirtualMachine().getLastHostId());
Host host = _hostDao.findById(vm.getVirtualMachine().getHostId());
if (oldHostId != hostId) {
Host oldHost = _hostDao.findById(oldHostId);
DataStore storagePool = dataStoreMgr.getDataStore(pool.getId(), DataStoreRole.Primary);
long lastClusterId = lastHost == null || lastHost.getClusterId() == null ? -1 : lastHost.getClusterId();
long clusterId = host == null || host.getClusterId() == null ? -1 : host.getClusterId();
storageMgr.removeStoragePoolFromCluster(oldHostId, vol.get_iScsiName(), pool);
if (lastClusterId != clusterId) {
if (lastHost != null) {
storageMgr.removeStoragePoolFromCluster(lastHost.getId(), vol.get_iScsiName(), pool);
volService.revokeAccess(volFactory.getVolume(vol.getId()), oldHost, storagePool);
DataStore storagePool = dataStoreMgr.getDataStore(pool.getId(), DataStoreRole.Primary);
volService.revokeAccess(volFactory.getVolume(vol.getId()), lastHost, storagePool);
}
volService.grantAccess(volFactory.getVolume(vol.getId()), host, (DataStore)pool);
}
}
} else if (task.type == VolumeTaskType.MIGRATE) {