From e3b3a18aefb8364543cb162a289dabd3ff8293a5 Mon Sep 17 00:00:00 2001 From: Rohit Yadav Date: Thu, 21 Aug 2014 11:34:44 +0200 Subject: [PATCH] ConfigurationManagerImpl: Fix NPE when trying to access method on null object Before checking obj.length, the fix is to check that the obj is not null Signed-off-by: Rohit Yadav --- .../src/com/cloud/configuration/ConfigurationManagerImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java index bcd87da832a..bfa79a29dc2 100755 --- a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java +++ b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java @@ -407,7 +407,7 @@ public class ConfigurationManagerImpl extends ManagerBase implements Configurati String mgtCidr = _configDao.getValue(Config.ManagementNetwork.key()); if (mgtCidr == null || mgtCidr.trim().isEmpty()) { String[] localCidrs = NetUtils.getLocalCidrs(); - if (localCidrs.length > 0) { + if (localCidrs != null && (localCidrs.length > 0)) { s_logger.warn("Management network CIDR is not configured originally. Set it default to " + localCidrs[0]); _alertMgr.sendAlert(AlertManager.AlertType.ALERT_TYPE_MANAGMENT_NODE, 0, new Long(0), "Management network CIDR is not configured originally. Set it default to "